Time Nick Message 12:03 sfan5 it'd be nice if we could get more reviews on #14964 12:03 ShadowBot https://github.com/luanti-org/luanti/issues/14964 -- SDL: Use scancodes for keybindings by y5nw 12:31 [MatrxMT] Hey guys, it looks like the Lua API docs wrongly use "basecolor_red" instead of the correct "color_red". When I search on GitHub for "basecolor", I can't find any commits/PRs that show when this was changed. See the current usage of the "color_" syntax in line 45 of minetest_game/mods/dye/init.lua. I've never really used git much or created an issue before so that's why I'm reporting here, if that's okay. 12:31 [MatrxMT] Links: 12:31 [MatrxMT] https://github.com/luanti-org/luanti/blob/master/doc/lua_api.md 12:31 [MatrxMT] https://github.com/luanti-org/minetest_game/blob/master/mods/dye/init.lua 12:36 MTDiscord the example in lua_api.md is just that: an example, it need not correspond to what MTG does. 12:36 MTDiscord if anything the example should probably be distanced further from MTG. MTG docs != Luanti docs. 12:44 [MatrxMT] Ah I get your point. Though the example references wool and dye, which are defined in MTG. Plus I was sort of expecting the docs to be centered around MTG - I suppose a note/warning could be made to clarify this to new modders. Do you know if other games like VL also have their own wool/dye groups which would act like the example? 12:44 [MatrxMT] The example was this: 12:44 [MatrxMT] ```lua 12:44 [MatrxMT] { 12:44 [MatrxMT] type = "shapeless", 12:44 [MatrxMT] output = "wool:red", 12:44 [MatrxMT] recipe = {"wool:white", "group:dye,basecolor_red"}, 12:44 [MatrxMT] } 12:44 [MatrxMT] ``` 12:48 MTDiscord yeah i found the example 12:49 MTDiscord i don't know if another game has groups that work like this and it doesn't matter 12:49 MTDiscord many of the examples used to come from MTG historically, but MTG may very well have changed since then 12:56 [MatrxMT] So instead of updating the legacy examples to match the current MTG, they are just left as legacy? This confused me when I tried to use the basecolor_red syntax in a crafting recipe because the other examples still worked in MTG. I feel like this inconsistency should be fixed by warning users about this and explaining the concept that MTG is not everything (if not already done). What do you think? 13:00 MTDiscord i don't think it's very important. but feel free to make a PR to make it more clear. 13:02 MTDiscord it looks like credits.json is invalid JSON due to a trailing comma. this causes a crash if you were on the "about" tab: https://forum.luanti.org/viewtopic.php?p=442729. the problem probably depends on your jsoncpp version, so you would need an older system-provided jsoncpp which is stricter and does not allow trailing commas to be able to reproduce. 13:02 [MatrxMT] I just grepped mineclonia's codebase a bit and apparently they still use the basecolor_red syntax. Hmm I think it should be made more clear in the docs. I've never made a PR before though but I can try sometime. 13:02 [MatrxMT] E.g. 13:02 [MatrxMT] $ grep -Ri basecolor 13:02 [MatrxMT] ... (other occurences) 13:02 [MatrxMT] ITEMS/mcl_dyes/init.lua: groups = {basecolor_magenta=1, excolor_red_violet=1,unicolor_red_violet=1}, 13:02 [MatrxMT] ITEMS/mcl_dyes/init.lua: groups = {basecolor_red=1, excolor_red=1, unicolor_light_red=1}, 13:03 [MatrxMT] Anyways, I'll give you space for your issue now 13:04 sfan5 @luatic I guess we should add an unit test that checks the validity 13:05 sfan5 https://github.com/open-source-parsers/jsoncpp/commit/781eec4da8049c56f1c5d53d14cbed55b2f42895 jsoncpp 1.9.3 or newer allows trailing commas 13:06 sfan5 bold of them to enable this by default 13:07 sfan5 the default config also allows comments :D 13:17 sfan5 I suppose changing parse_json to be strict would be a bad idea 15:25 MTDiscord when will 5.11 come to the play store? 16:18 SFENCE #15451 is now ready for review as a first step of adding iOS support. 16:18 ShadowBot https://github.com/luanti-org/luanti/issues/15451 -- Make Luanti buildable for iOS and iPhoneSimulator and runnable on iPhoneSimulator by sfence 19:26 MTDiscord I'm pretty sure it already is there 19:27 MTDiscord Interesting. On my device, samsung galaxy s22, I cannot install 5.11 from either the play store or fdroid 19:28 MTDiscord I have it for a time already 19:28 MTDiscord A week or more 19:29 MTDiscord A different Samsung device 19:29 MTDiscord I guess my device is no longer compatible, which is weird 19:35 [MatrxMT] I see rollout on Google Play is only at 10% so far, that would be the reason why 19:35 [MatrxMT] The minimum Android version is still 5.0 19:36 [MatrxMT] For f-droid I don't know 19:36 MTDiscord 5.11 is on F-Droid =) 19:45 Krock works for me on Android 5.1. You could try to self-sign the APK (even though it already should be signed), backup your files, uninstall the old app and install the new. For development builds that always worked on my end. 20:18 MTDiscord sure but I don't care enough to build for android :] 20:18 MTDiscord I'll just wait, thanks! 21:32 Krock You could also the builds from the GitHub Artifacts and self-sign them if there's yet none in the releases page. 21:33 Krock *take the builds