Time  Nick       Message
10:09 sfan5      rubenwardy: any comments on #15885?
10:09 ShadowBot  https://github.com/luanti-org/luanti/issues/15885 -- Make remote media exclusively use GET for hash set by sfan5
10:10 sfan5      also can you run a cdb search for `register_lbm`? ideally with enough context to see at a glance if "run_at_every_load" is set
11:33 rubenwardy sfan5: any performance testing? It has the benefit of making remote media much easier to host for server owners, so should increase adoption. Can use static hosting
11:43 sfan5      the only difference is for the index.mth request, which should not have a relevant performance difference
17:31 MTDiscord  <josiah_wi> I don't even see an attempt in the mod loading code to identify directories as being mods. Am I missing it?
17:32 MTDiscord  <josiah_wi> The unit tests include a comment // Test in non worlddir to ensure no mods are found, but it looks to me like any directory found in the specified is assumed to be a mod.
17:33 MTDiscord  <josiah_wi> What's wrong, the code or the unit test?
17:38 MTDiscord  <josiah_wi> Looks like the code is wrong. I have a fix, but let me do some more testing, because this seems like a pretty significant change.
17:40 MTDiscord  <josiah_wi> I found the verification code, but the verification is ignored.
17:54 MTDiscord  <josiah_wi> Alright, opened a PR.
19:39 MTDiscord  <herowl> Yeah, had that when switching git branches (or was it stash?). Git leaves behind empty folders in some cases, and Luanti would crash at startup, because a "mod" is missing init.lua or such.