Time  Nick       Message
09:10 tenplus1   Hi folks
09:10 tenplus1   What is the simplest way to show the inventory screen using a command ?
09:51 rubenwardy the decision to merge all of MTG's documentation into a single text file rather than keeping it per mod is quite annoying
09:52 rubenwardy tenplus1:   core.show_formspec(player:get_player_name(), "", player:get_inventory_formspec())
09:52 rubenwardy although this won't update with set_inventory_formspec
09:54 tenplus1   thanks rubenwardy, am looking for the simplest way to show sfinv formspecs via node clicking
09:56 tenplus1   using that command works but some of the sfinv tabs no longer work properly though :(
10:00 tenplus1   same with the function you posted for the sfinv feature on git, appears but buttons no longer work
10:02 rubenwardy yeah set_inventory_formspec won't work
10:09 tenplus1   this is the reason I asked for the new feature for sfinv mod itself so it can handle everything it needs to directly and show the formspec page the mod needs
10:11 tenplus1   I think it's the formname part that's causing issue: core.show_formspec(playername, formname, formspec)
14:55 MTDiscord  <josiah_wi> sfan5,  e39e47b introduced a dangling reference to getKeySetting. The code looks like maybe it was unfinished or something?
14:57 MTDiscord  <josiah_wi> You did that last year to remove the unnecessary value copy, but I think you forgot to put the new object in the cache and instead returned a reference to the temporary. So there are two bugs; the cache is not updated, and there's a dangling reference.
15:00 MTDiscord  <josiah_wi> Sorry, I think your fix was actually right, sfan.
15:00 MTDiscord  <josiah_wi> It's the recent scancode PR that adjusted your fix and completely broke it.
15:08 MTDiscord  <josiah_wi> Phew, it's a false positive.
15:27 MTDiscord  <luatic> further discussion: https://github.com/luanti-org/luanti/issues/15922
15:36 sfan5      I don't remember touching this code
15:37 sfan5      looks like I did though
15:38 sfan5      and in fact I don't see why the same issue shouldn't apply to my own code
15:39 sfan5      however from a quick grep it looks like all usages of getKeySetting() are not keeping the return value around (as a reference)
15:40 MTDiscord  <josiah_wi> Lar's concern applies. I was reading too fast and confused about the semantics and ended up casting blame inappropriately. I ask for your forgiveness.
15:43 MTDiscord  <luatic> it looks like the code is probably fine (i was a bit unsure that there would be a bug, hence why i just voiced my concern), but i think it is not obvious why it is fine and will remain fine in the future so we should probably do something about that
17:32 Krock      Will merge #15908 and #15917 in somewhat precise 10 minutes
17:32 ShadowBot  https://github.com/luanti-org/luanti/issues/15908 -- [NO SQUASH] Two fixes I guess by SmallJoker
17:32 ShadowBot  https://github.com/luanti-org/luanti/issues/15917 -- Do not discover mod directories that fail parsing by JosiahWI
20:45 sfan5      planning to merge #15912, #15885 in 10m
20:45 ShadowBot  https://github.com/luanti-org/luanti/issues/15912 -- [no sq] Increase strictness for item registration / overrides by sfan5
20:45 ShadowBot  https://github.com/luanti-org/luanti/issues/15885 -- Make remote media exclusively use GET for hash set by sfan5