Time Nick Message 01:16 MTDiscord sfan5: pretty sure overlay tiles get colorized 01:16 MTDiscord Dirt with grass blocks rely on that IIRC 06:27 sfan5 hmm, right 07:58 MTDiscord who thought it was a good idea to expose and document all the internal parameters of dump... 09:47 MTDiscord git blame goes brrr :juanchi_face: 13:17 sfan5 @luatic the matrix tests seem to rarely fail for no reason https://github.com/luanti-org/luanti/actions/runs/14590712098/job/40925114706?pr=16064#step:5:607 15:08 sfan5 whats the coredev opinion on adding an aux2 key on short notice? 15:08 sfan5 only problem is see where to fit it for Android 16:19 [MatrxMT] LGTM for the short term, but maybe also add a remark that we do want to eventually have mod-provided keybindings 16:55 Krock sfan5: What would you want to use it for? There would have to be a mod API for it. Otherwise it's just a regular hotkey. 16:56 [MatrxMT] I think that would be short-sighted. We'd never be able to get rid of Aux2 again, even when a proper solution arrives, because of backwards compat. And we're on a good way to a proper solution now, with the SDL keybinding progress and a touch controls editor 16:56 sfan5 Krock: nothing, let modders check it with get_player_control() 16:59 [MatrxMT] The "Android issue" is really just a symptom of a bigger underlying issue: Aux keys are meaningless by themselves. They will mean different things depending on the game and possibly context, so Luanti cannot provide a reasonable description/icon for them in the keybindings menu or in the touch controls 16:59 [MatrxMT] or a reasonable keybinding, or a reasonable position in the touch controls 16:59 Krock the game would need to provide a specific translation string 17:02 [MatrxMT] There's this comment which makes the problems of just adding more Auxes obvious, describing all the workarounds you'd need: https://github.com/luanti-org/luanti/issues/11446#issuecomment-880360833 17:04 [MatrxMT] Krock: at that point, we're not that far from https://github.com/luanti-org/luanti/issues/11446#issuecomment-883458358 /#12488 anymore 17:04 ShadowBot https://github.com/luanti-org/luanti/issues/12488 -- Support custom key binds (with keyboard and touchscreen support) 17:04 sfan5 well what hecks described is just "add auxN and then do (more stuff)" 17:05 Krock grorp: nice find. yes. that goes into a similar direction. 17:05 [MatrxMT] Krock: yes, that's what I meant by "the proper solution" 17:06 sfan5 luatic's proposed solution looks a bit different, relying on SSCSM(?) 17:06 [MatrxMT] sfan5: more stuff to make it usable 17:06 MTDiscord i would ideally like SSCSM but it's also doable without 17:08 sfan5 I know there's more but my point is that adding an aux2 now is not necessarily incompatible with a future solution 17:09 sfan5 modders have basically been asking for more custom keys for years and it doesn't look like a custom keybinding solution is around the corner 17:09 sfan5 so I'm sure they'd rather have aux2 right now than a better solution in 2 years 17:33 [MatrxMT] For the record: one idea I had in mind with secondary keybindings is that we could use that (in a followup) to fully decouple keyboard/mouse control from e.g. touch controls; the latter can be represented by e.g. adding GameKeyType as a KeyPress variant 17:34 [MatrxMT] Although I have admittedly not yet looked into how doable this is 18:51 v-rob According to my research for #16071, Shift + Esc is not used by any major window managers by default. But if anyone is willing to check for their particular setup, I'd be much obliged. 18:51 ShadowBot https://github.com/luanti-org/luanti/issues/16071 -- Change exit keybinding and fix bug in allow_close[] by v-rob 18:54 MTDiscord Seems fine for me on xfce 19:38 sfan5 merging #16060, #16058, #16056, #16050 in 10m 19:38 ShadowBot https://github.com/luanti-org/luanti/issues/16060 -- Improve usability of Prometheus metrics backend by sfan5 19:38 ShadowBot https://github.com/luanti-org/luanti/issues/16058 -- Switch to smallint for position keys (x,y,z) in postgres backend by sfan5 19:38 ShadowBot https://github.com/luanti-org/luanti/issues/16056 -- Move profiler calls out of hot path in ClientMap by sfan5 19:38 ShadowBot https://github.com/luanti-org/luanti/issues/16050 -- [nosq] Small doc fixes by Desour 19:40 sfan5 #16013 too 19:40 ShadowBot https://github.com/luanti-org/luanti/issues/16013 -- [no squash] Fix for blocks sometimes not being updated on the client plus some RemoteClient improvements by lhofhansl 21:54 MTDiscord Shift + Esc brings up the process manager in firefox. That only happens if firefox is focussed ofc, which might happen in wasm. 22:11 [MatrxMT] so I'm sure they'd rather have aux2 right now than a better solution in 2 years 22:12 [MatrxMT] That's true. I'd say "let's do it", if it wasn't for my concern that if we add Aux2, we'll be stuck with that UX kludge forever due to backwards compat once games start using it. 22:13 [MatrxMT] It would be another confusing, and in many situations useless, button in the touch controls, occupying valuable screen space. This would be acceptable for a temporary/short-term solution, but not if it has to stay. How can we get rid of it again once we have a proper solution? 23:34 v-rob One possibility is to make Aux2 opt-in by the game, so the button doesn't show up unless it's enabled. Presumably, you could also use this to disable Aux1 if it's irrelevant to your game. 23:34 MTDiscord i mean, you could already use zoom as aux2 if it didnt have the hardcoded stupid hud 23:36 MTDiscord https://github.com/luanti-org/luanti/issues/13760 and https://github.com/luanti-org/luanti/issues/12951 23:36 v-rob @bastrabun: That was part of the reason I chose Shift + Esc, since other applications use it for non-window manager stuff. 23:36 v-rob In any case, you can prevent Process Manager from opening with preventDefault() from JavaScript, so that's no problem.