Time Nick Message 00:30 MTDiscord +1 for a minetest sam as a built in "engine primitive" 😉 06:30 MTDiscord In theory particles should just have a mesh drawtype, and primitives should also be supported for said drawtype 12:32 PtiLuky Hello guys, C++ dev who is new to this project here. I have a question about something that was probably already discussed several times. But could someone explain me why we only include the .cpp in the cmaje project and not the .h? 12:32 PtiLuky I know it can still compile well, but not including them hides then in our IDE and if I search text in "entier project", my IDE will not give me the occurences in .h for instance 12:37 sfan5 do projects normally include the header files into cmake (how exactly?). seems pointless when they're not directly compiled 12:41 Desour cmake allows to specify HEADERS separately now: https://cmake.org/cmake/help/latest/command/target_sources.html#file-sets 12:41 Desour but we're using 3.12 minimum version 12:42 sfan5 sounds like we could just GLOB for *.h and add them that way if it helps IDEs 12:43 Desour shouldn't the ide be able to find the headers from the include file path (-I in compile_commands.json)? 12:43 PtiLuky Regardless of if you add them separately or in the sources, adding them as part of the project doesn't change anything about compilation, but just shows them in the IDE. 12:43 PtiLuky And yes, doing GLOB sounds enough for this 12:45 PtiLuky the IDE can find them when I do "follow symbol" on the file, or Ctrl + click on the "#include "myfile". So having access, or compiling is not issue. 12:45 PtiLuky But for instance Visual Studio does not show files in the project but in "External Dependencies"; which is considered as being out of the project 12:46 PtiLuky Ahhh wait, so I found a solution to my immediate problem, I have a check box "include External Items" when I do a text search or an occurences search 12:47 PtiLuky so with this being check, my IDE is able to show me the elements in the headers. 12:47 PtiLuky So for the discussion itself I guess the question is rather "are the headers files considered *external* files what we want?". 12:47 PtiLuky Most of the projects I have seen, the headers were added to the sources of the given target. 12:48 PtiLuky But at least I could fix my issue by checking this "include External Items", so I guess current situation is still ok, I was just surprised to not see any header file in the Visual Studio project 12:57 Desour as cmake recoginizes headers by their file extension (according to ), just adding the headers to the sources would work fine. either this or HEADERS file set seems fine to me at least. sounds like a good possible first contribution :) 12:58 sfan5 fwiw the reason I suggested glob is so we don't have the extra work of keeping the headers up to date 12:59 Desour once we have modules, we'll probably have to keep track of them (or rather their module equivalent) anyways 13:09 sfan5 if we get another review on #14135 I think we can safely add it to 5.13 13:09 ShadowBot https://github.com/luanti-org/luanti/issues/14135 -- Add persistent unique identifiers for objects by sfence 13:31 sfan5 planning to merge #16289 in a few hours 13:31 ShadowBot https://github.com/luanti-org/luanti/issues/16289 -- Add core.get_mapgen_chunksize() by sfan5 17:46 Desour meeting in 15 min? 17:47 Krock oh yes. I'd be around. 17:48 MTDiscord sfan, some projects do just put header files in the list of sources in CMake, next to the source files. 17:58 [MatrxMT] I'm here, not sure for how much though 18:02 Krock Meeting starts. Pinging those who reacted. Desour sfan5 18:02 Desour o/ 18:02 Krock It's quite hot here, so I'd like to keep this short 18:02 Krock > It’s the estimated FF + 5.13 RC (Zughy) 18:02 Krock 5.13.0 milestone: https://github.com/luanti-org/luanti/milestone/29 18:03 Krock 5 regressions (roughly). I don't think this is a good time to start an RC 18:03 Krock admittedly no blockers 18:06 Desour we don't have a 5.14 milestone yet (for moving feature PRs into there) 18:06 Krock Desour: look again 18:06 Desour :) 18:07 [MatrxMT] how about postponing it to the next week? 18:07 Krock I doubt much will change, but as long we're releasing once before November, this should be fine :3 18:09 Desour the persistent obj id pr would certainly have a chance in that week 18:12 Krock perhaps. I might look into one or two regressions when I'm again in the mood to do so. 18:12 Krock oh. 14135 that you mentioned is in fact the next topic 18:13 Krock > https://github.com/luanti-org/luanti/issues/14135 for 5.13? 18:13 Desour !title 18:13 Krock It already is in the milestone, so it should make it into 5.13 18:13 Krock Desour: missing MinetestBot, I presume 18:14 Desour mhm, maybe she's still on #minetest-dev 18:14 [MatrxMT] since we're at it, can I add another topic? As a piece of advice from core devs 18:15 Krock sure. I don't have anything to add to that PR anyway at this moment 18:16 [MatrxMT] when I teach teachers how to use Luanti, I see that the worst part is that they don't have the knowledge to host a server where they can do activities with the students altogether 18:16 [MatrxMT] Would https://github.com/luanti-org/luanti/pull/16173 make their life easier? 18:16 Krock Zughy: not just for teachers but LAN parties in general. 18:17 Desour that PR should by ready once sfan's comments are addressed 18:17 Krock alternatively, displaying the local IP would be an option too, although a rather impractical one. 18:18 [MatrxMT] Can you tell me a honest price if I had to ask someone as a commission to implement it? I don't have the knowledge for an estimate 18:18 Krock as for how to use the UI and set up a server in general: this should be explained on the forums or in one/multiple videos (Youtube/PeerTube/Dailymotion) 18:18 [MatrxMT] I'd like to avoid a bounty 18:19 Krock the feature in itself does not seem to be too complicated but implementing it on all platforms would be rather annoying 18:20 celeron55 i think that LAN discovery PR is potentially very good for classroom environments. there's just the 4 points to fix. it's a fairly clean implementation 18:21 celeron55 anyone can do those changes 18:21 Krock celeron55: well aside from that the only comments in the code are actually commented code 18:22 MTDiscord It's also good for home networks where you want a family member or friend to join on a separate device easily 18:23 Krock It is yet unclear to me whether the author would like to continue this implementation at some point or not 18:23 Desour I'd prefer a more standardized implementation over a self-built protocol, as it will be using a fixed port. but I won't stand in the way if this is the only implementation we get 18:24 [MatrxMT] Krock: I don't think they would 18:24 Krock Desour: you need to broadcast a packet on e.g. 192.168.0.255 or similar and that's exactly what's happening here 18:25 [MatrxMT] is it something a skilled dev can finish in, let's say, 10 hours of work? 18:26 celeron55 it needs more testing than finishing, i'd say 18:27 [MatrxMT] I cannot pay all the testers on GH :P 18:29 celeron55 if it was rebased, and then a windows built made, then people could test that it performs similarly to other LAN games 18:29 celeron55 build 18:29 celeron55 * 18:30 Krock the buildbot already generates Win32/64 binaries. It's more practical to debug and program that part on Windows, though. 18:31 Krock a while ago I tried to use Windwos debuggers in Wine and they were generally worse than the crude WinDBG sysinternals tool 18:32 celeron55 well, i suspect there's nothing to debug 18:35 Krock mhm hopefully. 18:37 Krock Zughy: I might have a look into it sometime - but won't promise anything at this point. Maybe someone's faster at picking it up. 18:38 Krock > discuss PRs and issues in 5.13 milestone 18:39 Krock maybe let's do this when there's more devs participate in the next (?) meeting. I'm also not in the mood right now. 18:39 Desour +1 18:45 MTDiscord5 +1 19:02 sfan5 ah oops we had a meeting 19:03 sfan5 i guess we could re-do it tomorrow at the same time 19:07 MTDiscord this lan discovery was working on all platforms last 10 years... 20:22 lhofhansl Hello friends. Merging #16292 in a few. 20:22 ShadowBot https://github.com/luanti-org/luanti/issues/16292 -- MapBlock::getData be gone by lhofhansl 20:36 lhofhansl And... Done.