Time  Nick      Message
14:54 sfan5     merging #16300, #16308, #16303 in 10m or more
14:54 ShadowBot https://github.com/luanti-org/luanti/issues/16300 -- Use unique_ptr for trivial ownership by PtiLuky
14:54 ShadowBot https://github.com/luanti-org/luanti/issues/16308 -- Remove obsolete `SMeshBuffer.h` by appgurueu
14:54 ShadowBot https://github.com/luanti-org/luanti/issues/16303 -- Do not block in httpfetch_request_clear() by sfan5
15:01 PtiLuky   Desour to me "Avoid passing non-const references to functions" sounds more like "in favor of const ref whenever possible".
15:01 PtiLuky   For pointers vs ref, the information of "the nullability has been checked previously" sounds more important and would be lost if raw pointers has been used everywhere...
15:01 PtiLuky   But I guess this is some coding style choice, I can adapt to this for next PR, sorry
15:07 Desour    hm, that's also a way one could read it. but I'm pretty sure it's a dislike against references, as it's in the "C++ features" section. it's also how it's been interpreted by most people so far, AFAIK.
15:08 Desour    anyway, as said, in your PR it's fine imo. I just wanted to let you know that replacing raw ptrs with references everywhere would probably not be welcomed and spare you of useless work :)
15:09 PtiLuky   Yes yes, understood, will avoid changing this kind of things then
17:01 MTDiscord <exe_virus> I also like references over raw pointers for the same reason, so would approve such a thing
17:05 Krock     I'd prefer references to have the -> notation too such that it's clear that a level of indirection happens
17:06 Krock     (but that's a design choice)
17:38 MTDiscord <luatic> i too like to use references if possible. i think there is a benefit to them not using -> notation: it's easy to change something to be a (const) reference.