Time Nick Message 04:49 MTDiscord Technically on server side we have no way how to react on player collision with something? Only entity can react to collision with player, node, etc? Am I right? 04:55 MTDiscord (take this with a grain of salt, might be wrong) believe that to be the case, something like this adoption needed pr would be needed https://github.com/luanti-org/luanti/pull/6219 09:55 PtiLuky Hi, 09:55 PtiLuky sfan5 lhofhansl (and others!) I want to discuss the PR https://github.com/luanti-org/luanti/pull/16329 to avoid polluting the PR with arguing. 09:55 PtiLuky I still don't agree with sfan5 comment, I believe offering the option to have a shader that do not use the _MainShaderUniformSetter_ but its own setter instead is a good design choice, and I find alternatives worse to do... 09:56 PtiLuky But I do agree "responsibility of the caller to create the callbacks (in general)" was a bad suggestion I did, you are right 09:57 PtiLuky About recompiling: I do not understand your point, in this PR I added a irr_ptr field to the shader_info struct, and like this, recompilation of the shader can be done without any issue, even if some shader have their own callbacks, what would be the issue? 09:58 PtiLuky I'd be open to design alternative, but currently to me this callback override still seems the cleanest solution yet 10:04 sfan5 please keep the discussion in the PR 10:05 PtiLuky ok 10:22 sfan5 if you want I can PR the necessary changes to adjust the way it works to my preference, too 10:27 PtiLuky I am totally fine with that too :)