Time  Nick        Message
08:06 sfan5       merging #16357 in the next 3 hours
08:06 ShadowBot   https://github.com/luanti-org/luanti/issues/16357 -- Extend error case tests by sfan5
17:22 SFENCE_arch Do we have problem in Luanti 5.12.0 release under linux? https://pastebin.com/eY2GTEh3
17:26 SFENCE_arch Looks like secure.trusted_mods configuration ha no effect on core.request_insecure_environment
17:27 SFENCE_arch Works whe secure.enable_security is disabled.
17:28 Krock       works for me in 5.13.0-dev using a RUN_IN_PLACE=1 build
17:29 Krock       removing my mod from `secure.trusted_mods` does correctly trigger an assertion
17:32 Krock       also: I'll do the changelog for 5.13.0 this weekend
17:34 SFENCE_arch Hmm... i have just try build from master and same prblem... without run in place... Arch linux...
17:34 Krock       1. did you check whether the mod name is correct in a) minetest.conf and b) mod.conf ?
17:34 Krock       2. did you modify the correct minetest.conf file?
17:35 Krock       3. ensure there's no other Luanti instance writing to the same conf file
17:35 SFENCE_arch It is a reason why I printed current mod name and secure.trusted_mods from settings in erro log.
17:40 Krock       fair
17:41 SFENCE_arch Ok... looks like problem is that I add mod to .minetest/mods via ln -s ...
17:42 SFENCE_arch When I copy it, it works fine.
17:42 SFENCE_arch So it is a question if it is a bug or feature. :D
18:03 Krock       Interestingly, there is no such issue for builtin (which I have symlinked for ... many years)
18:04 Krock       although I remember making a change in this regard recently. I don't know how reasonable symlinking mods would be. It should be possible to symlink the entire "mods" dir.
18:09 SFENCE_arch I have folder with installed mods and I adding mods I have under git in different directory by links. So, common user should not have problem with this.
18:21 SFENCE_arch But it looks like if I link mods dir, it happnes too.
18:22 SFENCE_arch RUN_IN_PLACE=TRUE build.