Time Nick Message 12:30 Krock we're at 100 PR's again. do something :P 12:33 MTDiscord Arguably the do something should have been 3 years ago 12:34 Krock never too late 13:43 MTDiscord As long as there is a large community base contributing PRs and a small subset of them are core devs who can review, you will continue to have a gradual increase in PR backlog. 13:45 MTDiscord A two approval requirement is also a much greater commitment from the review team. Even my work team finds it tough to keep up with a two approval requirement, and most of us are working full time. 13:45 MTDiscord If we can't keep our PR count low you don't even have a chance. 13:48 MTDiscord You can admit you don't have the resources to review everyone's contributions and be selective about what you review to get the best changes in, or you can train the community to be more organized and participate in helping the review process go smoothly. 13:50 MTDiscord Is there any other action you can take? 13:52 Krock Contributors are kindly invited to test the PRs and share their experience with them 13:53 Krock many PRs are also stuck on finding a consensus, where modder opinions would come in handy 13:53 MTDiscord Do modders know that? 13:54 Krock I as a modder do know that 8) 13:54 Krock the PRs would be locked if we didn't want feedback 13:55 Krock to be fair, a simple "LGTM" would not help much. It's about properly judging the concept, reviewing, testing the code 13:56 Krock I've seen server owners provide inputs on certain PRs in the past, which were effectively tested in production. 14:01 aliasstilltaken Feel free to poke server owners if there is something they specifically should test. 14:06 Krock #16339 might be a candidate, for example (requires new mapblocks to be generated). It's mostly a question of how good your world backups are. Just in case something goes wrong. 14:06 ShadowBot https://github.com/luanti-org/luanti/issues/16339 -- [Take 2] Prevent MapBlocks in generation from being unloaded by Montandalar 14:09 repetitivestrain well #16339 has been on my server since July without any issues 14:09 ShadowBot https://github.com/luanti-org/luanti/issues/16339 -- [Take 2] Prevent MapBlocks in generation from being unloaded by Montandalar 14:09 repetitivestrain for what it's worth 14:16 aliasstilltaken +1 will add 16339 to the my server. Any "test is successful if x,y and z is met" or "dont test in prod" ? 14:18 sfan5 re PR backlog: is it increasing long-term? I don't get that impression 14:18 Krock there's a "Testing needed" tag that could be used. However, in this case it's more of a "Testing appreciated, but not entirely necessary to get the PR merged" 14:19 Krock https://www.youtube.com/watch?v=TD1TVZ47xZY&t=18 152 open PRs in 2016 14:19 Krock ~title 14:19 ShadowBot - YouTube 14:19 Krock Thanks ShadowBot 14:20 MTDiscord Stays around 100 now, since that seems to be a point it gets mentioned and some prs handled 15:59 [MatrxMT] Our lowest was around 70, about a year ago 18:21 [MatrxMT] technically the lowest is 0 18:21 [MatrxMT] back in the beginning 20:38 MTDiscord mental pull requests: 20:38 MTDiscord not everything has to be hosted on github