Time Nick Message 13:30 sfan5 merging #16676, #16679, #16674, #16647 in 15m 13:30 ShadowBot https://github.com/luanti-org/luanti/issues/16676 -- OpenGL3: Add subpixel offset for 2D image rendering by ExeVirus 13:30 ShadowBot https://github.com/luanti-org/luanti/issues/16679 -- Show unavailable settings in menu by sfan5 13:30 ShadowBot https://github.com/luanti-org/luanti/issues/16674 -- Clean up header includes by cx384 13:30 ShadowBot https://github.com/luanti-org/luanti/issues/16647 -- Implement core.path_exists() by RisingLeaf 13:59 [MatrxMT] What about #16583? I don't think it needs to be blocked over [&] 13:59 ShadowBot https://github.com/luanti-org/luanti/issues/16583 -- IrrlichtMt: Initial SDL3 support by SmallJoker 14:00 sfan5 i wanted to re-test it 17:14 SFENCE Do we have some kind of hard coded limitation to 60 FPS when Luanti use ogles2? 17:15 MTDiscord is vsync on? 17:16 MTDiscord or fps_max 17:19 SFENCE It is the same minetest.conf as for the normal OpenGL driver, where I have up to 190 FPS. 17:19 SFENCE It can be only "luck" that ANGLE has only lower performance in that way, that it does 60 FPS almost precisely. 17:19 SFENCE FPS max is 200 for that, Vsync is off. 17:23 rubenwardy nvidia? 17:24 MTDiscord maybe related: #15471 17:24 ShadowBot https://github.com/luanti-org/luanti/issues/15471 -- Luanti stuck in vsync, with both vsync disabled in settings, and fps cap set to 4000 17:51 SFENCE No, M2 Apple Silicon (Graphic is integrated in it) 17:58 SFENCE Can I verify it by comment, change some line in Luanti to force vsync disable? 18:00 sfan5 the only place we enable vsync will be in the sdl code 18:05 SFENCE So, it should be somewhere in CIrrDeviceSDL ? 18:57 SFENCE Hmmm... Grep say, that VSync is only used in CEGLManager in irr. Has no effect in CSDLManager. 18:58 SFENCE Maybe a bug? 19:00 sfan5 right, we didn't have vsync working with sdl at all 19:07 MTDiscord https://github.com/luanti-org/luanti/issues/16682 19:34 MTDiscord sfan5: do you think it would make sense to add a link to https://github.com/luanti-org/luanti/pull/16661#discussion_r2532174563 in COpenGLExtensionHandler.cpp to Version >= 300 check? 19:35 MTDiscord it might be useful info, but probably not a thing we usually do? 19:37 sfan5 i don't see much value 19:37 sfan5 in a link that is 19:38 sfan5 could add a comment "The GL 3.0 spec considers float formats color-renderable. This is probably possible on older versions, but we couldn't find the right extension to check". 19:40 MTDiscord well but what I think is that they're already color-renderable if you have ARB_framebuffer_object and ARB_texture_float/ARB_texture_rg 19:41 sfan5 idk about that 19:41 MTDiscord they're just not in a "required formats to be supported for framebuffers by the implementation" list in ARB_framebuffer_object, unlike they are in OpenGL 3.0, so it's not guaranteed to work 19:41 sfan5 either way just put the conclusion/explanation in the comment. nobody will want to dig around in PR comments in the future. 19:51 MTDiscord just went without a comment now, explaining this in a stand-alone comment without writing an essay is more than I can do tonight xD