Time  Nick      Message
11:14 lhofhansl hi all... Planning to merge #16739 in a few minutes.
11:14 ShadowBot https://github.com/luanti-org/luanti/issues/16739 -- Use std::mutex for the env lock (instead of ordered_mutex) by lhofhansl
11:18 lhofhansl And done...
11:18 lhofhansl Also, a request to test out #16783
11:18 ShadowBot https://github.com/luanti-org/luanti/issues/16783 -- Send modified blocks selectively and as soon as possible by lhofhansl
12:49 Krock     ~tell lhofhansl You mention testing 16783 - how would you suggest to test that? To measure the average time between block sends? That'll only tell half the story since we're talking about prioritizing, which means that it'll only become relevant if there are multiple changes to the map at once.
12:49 ShadowBot Krock: OK.
12:50 Krock     Also from what I can see, PrioritySortedBlockTransfer does not do any deduplicating.
12:55 Krock     (potentially resulting in duplicated block sends, see Server::SendBlocks )
13:00 sfan5     there's a "block sending" and "block sent" set somewhere so I'd assume that takes care of it
13:00 sfan5     s/block /blocks //
13:04 Krock     mhm. So RemoteClient::SentBlock would log to infostream if that happens. "m_blocks_sending" is not checked in the sending part of Server::SendBlock
13:34 sfan5     merging #16792, #16790 soon
13:34 ShadowBot https://github.com/luanti-org/luanti/issues/16792 -- Client: Fix crash in 'plantlike' nodes with no textures by SmallJoker
13:34 ShadowBot https://github.com/luanti-org/luanti/issues/16790 -- Fix corner case when unknown node ids run out by Desour