Time Nick Message 09:47 Krock will merge #16796 in 20 minutes 09:47 ShadowBot https://github.com/luanti-org/luanti/issues/16796 -- Serialize: Throw exception on incomplete reads by SmallJoker 10:10 Krock merging 14:14 sfan5 merging #16799, #16774 soon 14:14 ShadowBot https://github.com/luanti-org/luanti/issues/16799 -- Select Mods: Show world mods by cx384 14:14 ShadowBot https://github.com/luanti-org/luanti/issues/16774 -- Keybinds UI: Only show “reset” button if value differs from default by Bedwizen 14:30 Desour I managed to get a test_node_callbacks CI fail: (it does core.place_node and checks if the place_node callback was called) (my PR doesn't touch relevant code, and it succeeds in the PR, just not in my feature branch fork) can mapblocks unload between devtest unittests? 14:32 sfan5 maybe in theory 14:32 sfan5 🤷 14:54 sfan5 pushing https://0x0.st/Pozs.txt in 15m unless someone complains 15:24 Krock I thought there were more date mentions but sure 15:25 Krock Will push https://krock-works.uk.to/u/patches/0001-Serialize-Fix-ItemDef-regression-introduced-by-3d10d.patch afterwards unless someone complains 15:25 Krock fixes https://github.com/luanti-org/luanti/pull/16796#issuecomment-3707115393 - reproduced on the server skywars.telesight.nl (but another 5.4.0 one didn't have the issue...?!?!) 15:26 sfan5 Krock: isn't the "// >= 5.8.0-dev" misplaced with your patch? 15:27 Krock both features were added in 5.8.0-dev 15:27 Krock I could insert another check if you want 15:27 sfan5 no but there should be only one comment, no? 15:28 Krock depends on what the comment should imply :3 removing it... 15:29 Krock if that's fine then I'll go ahead pushing it in 5 minutes 15:29 sfan5 sure 15:29 Krock thanks for the feedback. 16:12 sfan5 should we disable unittests by default in release builds? 16:13 sfan5 by that I mean non-dev, not the BUILD_TYPE 20:17 pgimeno you mean so that users can't do luanti --run-unittests ? 20:18 sfan5 yes 20:19 pgimeno that may be a good idea for android, but not sure about the rest 20:20 pgimeno I mean, asking a bug reporter to run the unit tests sounds like something that might happen 20:20 sfan5 i don't think it ever has, however 20:21 user333_ how are you even going to get an android user to pass arguments to luanti without adb? too complicated for the average user imo 20:21 sfan5 android is not relevant here, because the user can't pass arguments (even with adb) and the unittests *are* already compiled out 20:22 sfan5 this will happen anyway when #16127 is done, but in the meantime we could save some space for our release executable 20:22 ShadowBot https://github.com/luanti-org/luanti/issues/16127 -- Separate executable for unit tests 20:24 sfan5 probably the only people running unittests on a release build are us devs and some Linux distributions 20:24 user333_ i almost never even run unittests 20:24 user333_ only once or twice to test a few issues on specific hardware 20:26 user333_ my current build has unittests enabled and several fail. whatever, it works \_('_')_/ 20:28 MTDiscord also in $year for what, a few mb, does it really matter? its not the 1990s 20:28 MTDiscord not that this is a valid arguement for keeping them in, just pointing out the irony in saving some space 20:29 user333_ 0.1s faster download 20:29 user333_ i agree though, a few extra megabytes doesn't matter THAT much 20:30 MTDiscord people on crappy connections might be true. at least for the windows builds, ditching mtg did sure make it unzip faster 20:31 user333_ though fitting a whole game engine into like 15mb is quite insane 20:32 user333_ the self extracting launcher is just over 11 MB o_O 22:52 Juri Today I learned that doors have inventories 22:52 Juri I wonder what is the reason behind it 22:53 Juri When I was looking at some mapblocks I noticed it, first thought it's a bug but even with just MTG and the default doors mod you'll get empty inventories 22:54 Juri Not even empty inventories, just plain 'ol "EndInventory" 22:56 Juri If anyone knows why that is, I would love to hear from you :) 23:02 sfan5 an inventory with no lists is "no inventory" 23:02 sfan5 every node with metadata has both the key-value map and an inventory 23:05 Juri Oh that makes sense now 23:15 Juri That in turn also means every node with an inventory has empty metadata 23:15 Juri Well inventories are part of the metadata, rather empty meta vars 23:17 Juri In any case thank you, that cleared some confusion I had 23:18 Juri Time to feed WorldEdit a schematic with "fields" but omitting "inventory" :P 23:19 sfan5 pushing https://0x0.st/PoPN.txt in 15m unless someone complains