Time  Nick       Message
11:01 sfan5      merging game#3221, game#3211 soon
11:01 ShadowBot  https://github.com/luanti-org/minetest_game/issues/3221 -- Fix confusing default for enable_fire and enable_tnt by sfan5
11:01 ShadowBot  https://github.com/luanti-org/minetest_game/issues/3211 -- Translation of the game description by alrito28
19:50 Krock      hm. When I close the client while the in-game settings are open, Luanti segfaults in MainMenuManager::deletingMenu
19:51 Krock      I noticed this a few times before but couldn't find the cause of it as I wasn't paying attention when it happened. Nice. That's some new bug hunting task.
19:58 crazylad   that is odd
19:58 crazylad   just reproduced it lol
20:00 crazylad   anyways, was #9368 solved? I think it was PR #11851 (commit 14c7fae), but I'm not sure
20:00 ShadowBot  https://github.com/luanti-org/luanti/issues/9368 -- FormSpec password fields use hidden text width, not "*" width
20:00 ShadowBot  https://github.com/luanti-org/luanti/issues/11851 -- Formspec: Unify argument checks by SmallJoker
20:00 Krock      crazylad: on which version? -dev ?
20:00 crazylad   yes, 5.15.0-dev
20:01 crazylad   idk what commit though
20:01 Krock      my PR should not have fixed that
20:02 Krock      it's not fixed
20:03 Krock      the input box starts scrolling horizontally much later if you input "l" vs "M"
20:03 crazylad   oh
20:04 crazylad   now I see... hmm
20:05 Krock      > s32 cStart = font->getDimension(txtLine->subString(0, cPos).c_str()).Width;
20:08 Krock      CGUIEditBox::breakText() should probably perform the password character transformation into BlockenText that's currently happening in ::draw()
20:09 Krock      the final solution is kept as an exercise for the reader
20:13 rubenwardy reader - please do not
20:15 Krock      why? :(
20:16 crazylad   some problem with modifying Irrlicht code I presume?
20:18 Krock      he would like to provide the fix in an exclusive $10 DLC
20:18 rubenwardy google 'the final solution'
20:19 crazylad   oh
20:19 Krock      oh (Copy)
20:22 lhofhansl  I just closed #16501 for lack of interest (no hard feelings) :)
20:22 ShadowBot  https://github.com/luanti-org/luanti/issues/16501 -- In-Game server should use dedicated_server_step by lhofhansl
20:25 lhofhansl  As another suggestion: Can we at least use the dedicated server step when "Host Server" is the selected in the UI? That way Singleplayer mode would continue to use 1/min(FPS, 60) as server step, but a in-UI hosted server would use the same dedicated server step as a separate server would.
20:26 lhofhansl  IMHO is a not a good experience that a local game and a game hosted through a server would have different physics (due to server step length) and need different optimal emerge queue sizes, etc.
20:27 lhofhansl  If we keep the existing behavior we should at least document this careful in order to avoid confusing folks.
20:27 Krock      the step duration will vary greatly on busy servers, It can make a difference in case of low player counts or activity overall. But aside from potentially wasting some CPU cycles I don't see much of an issue there
20:28 Krock      ...
20:28 crazylad   lol
20:54 crazylad   .... I think I just fixed the problem o_o
20:54 crazylad   https://paste.centos.org/view/e9daeaac
20:54 crazylad   lines 26 through 43 are modified
21:20 sfan5      merging #16803 soon
21:20 ShadowBot  https://github.com/luanti-org/luanti/issues/16803 -- Implement secondary keybindings [UI Proposal 2] by y5nw
21:20 sfan5      weblate update after that
21:21 sfan5      #16808 too
21:21 ShadowBot  https://github.com/luanti-org/luanti/issues/16808 -- Add PlayStation 5 DualSense controller support by thierry-f-78
21:21 sfan5      but actually #16787 has string changes too
21:21 ShadowBot  https://github.com/luanti-org/luanti/issues/16787 -- Add new setting to enable/disable dark mode in main menu by sfan5
21:22 MTDiscord  <wsor4035> #16808 requires #16807 tho?
21:22 ShadowBot  https://github.com/luanti-org/luanti/issues/16808 -- Add PlayStation 5 DualSense controller support by thierry-f-78
21:22 ShadowBot  https://github.com/luanti-org/luanti/issues/16807 -- Fix joystick button toggle actions repeating indefinitely by thierry-f-78
21:22 sfan5      why would it?
21:23 MTDiscord  <wsor4035> in the body of 16808.....  > Depends on: This PR requires the bugfix in #16807 to work correctly (toggle actions fix)
21:23 ShadowBot  https://github.com/luanti-org/luanti/issues/16807 -- Fix joystick button toggle actions repeating indefinitely by thierry-f-78
21:23 sfan5      i mean sure but that's not specific to the ps5 controller
21:23 MTDiscord  <wsor4035> just thought id mention it
21:32 sfan5      i guess the translation updates can wait until tomorrow
21:36 crazylad   sfan5: could #16802 be reviewed?
21:36 ShadowBot  https://github.com/luanti-org/luanti/issues/16802 -- Make "vertlabel[]" formspec element support core.colorize by CrazyladMT
21:38 sfan5      when i have time, sure
21:38 sfan5      one thing I wanted to test was whether the changes cause the rendering to differ from the old way
21:44 crazylad   the old way actually cut off the top half of the first character, but my PR fixes it