Time  Nick      Message
02:24 sofar     here's a different approach: who are our knowledgeable shader folks in the team? I was messing around with shaders yesterday for fun, but out of that came a few very minor, reviewable, short changes that were needed to implement some things in shaders. Instead of pushing a giant blob of changes, I have 5-6 very short (two are 1-liners, most are just moving code blocks out of if/ifdef, etc) patches that may or may not be worth considering. If I can discuss
02:24 sofar     these with maybe 1-2 people who know this stuff then it shouldn't take much time to remove the nonsense before a PR comes out of it.
08:29 sfan5     as usual we don't have a graphics person
12:03 MTDiscord <herowl> sofar: it'd be probably helpful if you pointed at specific changes
12:04 MTDiscord <herowl> If they're atomic and independent, you can just make a WIP PR with those patches, each in separate commit
12:04 MTDiscord <herowl> That way both coredevs and other people can review and comment
15:51 sofar     fair enough. I'll trickle them out one by one.
16:18 sfan5     but don't make one PR each
19:29 MTDiscord <herowl> Exactly, stuff all as commits into one PR