Time  Nick      Message
00:04 MTDiscord <jordan4ibanez> #17305 I literally just ran into needing this to do cool stuff
00:04 ShadowBot https://github.com/luanti-org/luanti/issues/17305 -- Add `listimages[]` element to allow styling inventory slots with textures by CrazyladMT
15:04 sfan5     minetestmapper has a new release now: https://github.com/luanti-org/minetestmapper/releases/tag/20260808
19:23 [MatrxMT] <Zughy> is `register_on_leaveplayer` executed on the same step a player leaves? Like, if I have `mytable[p_name] = {foo = bar}` and I empty it on the aforementioned callback, if a function tries to access that table on the same step the player leaves (e.g. `mytable[p_name].foo`), will it crash?
19:24 [MatrxMT] <Zughy> Asking because I have a function that checks if a player is still online (`get_player_by_name`). It returns true but then the table looks empty and kaboom
19:26 [MatrxMT] <Zughy> ...probably because it's inside an after and there is no guaranteed order?
19:37 Krock     Zughy: the player is removed after that callback is done
19:38 Krock     https://github.com/luanti-org/luanti/blob/master/src/server.cpp#L3152-L3187
19:40 Krock     deletingPeer is called by ReceiveTimeoutMs, which runs in ServerThread
19:42 Krock     AsyncRunStep does the globalstep callback and it is called before handling the incoming packets of the current loop
19:42 [MatrxMT] <Zughy> so is it possible that it goes leaveplayer -> after runs out -> player actually removed?
19:44 Krock     currently I do not see any path that would allow that
19:46 Krock     markForRemoval() is run after running the Lua on_leaveplayer callback. get_connected_players does check against that "marked for removal" and omits any such players
19:47 Krock     thus, what you're describing should not occur.
19:47 Krock     assumptions: 1. this is about server-side modding    2. we're talking about a somewhat recent 5.17.0-dev version, although that code shouldn't have changed recently
19:49 [MatrxMT] <Zughy> nope, 5.16 stable. Probably it's my fault, I'm investigating more, thank you
19:51 Krock     You're welcome.
20:12 crazylad  Krock: I've addressed your comments in #17305
20:12 ShadowBot https://github.com/luanti-org/luanti/issues/17305 -- Add `listimages[]` element to allow styling inventory slots with textures by CrazyladMT
20:13 crazylad  regarding the formspec version bump, a bump might be helpful for other stuff that has been added in 5.17, like text alignment and hypertips
20:15 crazylad  s/might/might also/
20:36 Krock     crazylad: indeed. I'll have a look at it later. Thanks for the update.
21:35 [MatrxMT] <Zughy> Krock: I confirm, it was my fault indeed