Time  Nick           Message
00:42 MTDiscord      <sheriff_u3> Herowl: This has already been put forward to the Voxelibre devs as a bug, I currently have got an issue and pr open to fix it. Should (hopefully) be included in the next release.
10:02 red-001        do we still support Windows vista/xp?
10:03 red-001        could actually switch the Windows code over to BCryptGenRandom if not
10:40 red-001        does anyone know why we use integer keys for the Lua registry?
10:40 red-001        we are like one luaL_ref away from having a very bad time with that
10:42 red-001        luaL_ref grabs it seems the first free integer reference from the registry, so if that's ever called and not all the references are setup it would be quite bad
10:45 Krock          We're considering to officially drop 8.1 because it is end of life
10:45 Krock          not sure where that was discussed
10:51 red-001        okay I'll drop XP support from the RNG PR then
10:51 red-001        the vista+ API is nicer
10:55 red-001        also that integer reference
10:56 red-001        how would people feel about keeping track of the highest registry key we want, and immediately filling it up after newstate?
10:57 red-001        it's really not supported either way, but at least this would work fine with PUC Lua even if a registry entry is missing, I think we might have issues with CSM or any other environment that doesn't use all the keys right now without knowing it
11:24 sfan5          what stops us from just adding a few dummy references "guard page" like
11:31 red-001        is that not what I suggested
11:31 red-001        yeah I think it's a workable solution
11:31 red-001        fill it up lightuserdata guard objects
11:32 red-001        s/it up/it up with
11:56 red-001        #17496 trivial fix for that numerical index thing
11:56 ShadowBot      https://github.com/luanti-org/luanti/issues/17496 -- Reverse RDIX entries used by the engine by red-001
11:57 red-001        okay there's a typo to fix there clearly
11:59 red-001        okay interesting the unit tests are not passing
17:55 siliconsniffer Should all actions on a dialog close it? That seems to be the established convention, except for the error dialog.
18:08 red-001        I  think so, but I already voiced that view before
21:42 MTDiscord      <herowl> @sheriff_u3 In case you haven't noticed, I merged your PR 😄 I just don't like not knowing why the crash was happening in the first place. Hotfix release is of course coming soon™, I just want to throw in together fixes for some other quite important issues.
21:43 MTDiscord      <herowl> That's also why I brought it up in the engine dev channel, I wanted to know if Luanti has changed anything important about mod load order or such
22:31 Sheriff_U3     herowl: Oh I thought you were just some user lol