Time Nick Message 16:22 MTDiscord <.zenonseth> i just noticed that noticeable is mis-spelled in that PR's title 16:23 MTDiscord I'm glad you noticed that 19:11 sfan5 merging #17600 in 15m 19:11 ShadowBot https://github.com/luanti-org/luanti/issues/17600 -- [no squash] Fix endian.h handling and missing includes by sfan5 21:39 MTDiscord Is protocol bump happening in 5.18 release? 21:47 sfan5 we always do that 21:49 MTDiscord <.zenonseth> stares at protocol version table i was checking just this weekend ["5.2.0"] = 39, ["5.3.0"] = 39, ["5.4.0"] = 39, 21:49 MTDiscord <.zenonseth> but yes since then its been incremental 22:06 MTDiscord (you can use formspec versions for those fortunately) 22:09 MTDiscord <.zenonseth> the same protocol versions for diff luanti ver causes a subtle bug in CDB actually, which is i think maybe related to the failing tests, but my attempts at fixing it all failed (And also there were other failures) 22:10 MTDiscord <.zenonseth> i need to get back to that PR sometime, but it's been frustrating to figure out 22:11 rubenwardy it's not really a bug as the engine_version is always provided and takes precedence. So it's an edge case we can largely not care about 22:13 MTDiscord <.zenonseth> fair for production, just was causing some muck-up in tests iirc 22:13 rubenwardy yeah