Time  Nick      Message
08:07 Krock     will merge #17667 #17668 #17682  in 20 minutes
08:07 ShadowBot https://github.com/luanti-org/luanti/issues/17667 -- Fix for objects (that are marked for deactivation) being lost at server shutdown by paradust7
08:07 ShadowBot https://github.com/luanti-org/luanti/issues/17668 -- shell.nix: add libzip by bjorn
08:08 ShadowBot https://github.com/luanti-org/luanti/issues/17682 -- Android: report unzip result from onHandleIntent instead of onDestroy by 9LJ9
08:12 ZenonSet- ok I guess I'll apply my comment suggestion early then :)
08:13 Krock     oops. sorry. Will wait.
08:14 ZenonSet- no problem, its the one you pinged me about (no idea what's going on with my username btw) - if you can just have a quick look to see if it makes sense?
08:15 Krock     sure. I don't know why I copied that number to my "merge list"
08:19 Krock     seems fine
08:21 ZenonSeth thx, approved
08:28 Krock     merging ...
08:31 Krock     done
19:06 ZenonSeth so I had replied to #17640 - it was 4.3K lines of changes, now its over 5K. It's not addressing a raised issue, just jumping into a huge implementation. I'm thinking this might be a possible close? any other opinion? unless this was somehow a known/discussed idea?
19:06 ShadowBot https://github.com/luanti-org/luanti/issues/17640 -- [PoC] Node modifiers by andriyndev
19:07 sfan5     haven't looked at it yet
19:07 ZenonSeth if you do, grab a cup of coffee/tea and settle in for a long read
19:10 sfan5     normally we should discuss large changes in an issue first so nobody wastes time implementing something that we don't want
19:11 ZenonSeth yep i told them that last week >This probably should have been an issue before going straight to implementation.
19:21 sfan5     left a comment
19:23 ZenonSeth thx
21:05 celeron55 that seems similar to a proof-of-concept I did ages ago
21:05 celeron55 mine was able to override any node definition fields in node metadata
21:06 celeron55 this one seems like an overcomplicated version of that, at least API wise
21:07 celeron55 https://github.com/luanti-org/luanti/compare/master...celeron55:minetest:meta_set_nodedef_2
21:08 celeron55 ha, mine was only 2.6k added lines
21:09 celeron55 and most of it is a new node definition serialization format suitable for this purpose
21:10 celeron55 (it's a compact binary one with focus on cross-version compatibility)
21:15 ZenonSeth i like the idea of metadata for some things ilke light level more. Others like texture selection or node selection, we already have potential solutions for with param2 as was mentioned in PR. I still think the PR is just going to take way too much time to review to get it merged at 5k+ now