Time Nick Message 17:31 sfan5 opinions needed on #17761 17:31 ShadowBot https://github.com/luanti-org/luanti/issues/17761 -- Extract common texture definition logic by tygyh 17:43 Krock I don't see how this improves anything 17:43 Krock ah. commenting on GitHub instead. 19:01 sfan5 do you think it's worth it working on such tiny code changes? 19:13 Krock I suppose it's worth having a look at it for each case. In this particular one I believe that passing the constructed object down would tidy the code a bit 19:14 Krock though I also made this PR as a statement, which turned out to be controversial. #17594 19:14 ShadowBot Krock: Error: That URL raised 19:14 Krock thanks ShadowBot 19:45 sfan5 merging #17760, #17754, #17752, #17450 in 10m 19:45 ShadowBot https://github.com/luanti-org/luanti/issues/17760 -- [no squash] Animation timer + httpfetch improvements by sfan5 19:45 ShadowBot https://github.com/luanti-org/luanti/issues/17754 -- Translate Swedish builtin command help by yeager 19:45 ShadowBot https://github.com/luanti-org/luanti/issues/17752 -- [no squash] Make item image animation work for dropped item entities and refactoring by cx384 19:45 ShadowBot https://github.com/luanti-org/luanti/issues/17450 -- Update builtin help formspec with search by ZenonSeth 20:03 sfan5 done 21:20 sfan5 Krock: now the PR has a completely different approach again and the CI is once again red 21:20 sfan5 I get the impression the submitter is just trying random stuff and then waiting for the CI and our reviews to tell them what's wrong 21:20 sfan5 this is in no way productive 21:21 sfan5 (this isn't some subtle edge case. if they compile-tested the code one they would have noticed that it doesn't work) 21:21 sfan5 once* 21:26 sfan5 merging #17465 in 10m (forgot that earlier) 21:26 ShadowBot https://github.com/luanti-org/luanti/issues/17465 -- [no squash] Formspec: Refactor HyperTip handling by SmallJoker 21:37 sfan5 uh I didn't see those two extra commits