Time  Nick      Message
00:09 MTDiscord <wsor4035> merging https://github.com/luanti-org/docs.luanti.org/pull/204 in 10
00:10 MTDiscord <greenxenith> It was in fact automatic
00:10 MTDiscord <wsor4035> we could, but also who cares (easier to just leave it tracking)
00:10 MTDiscord <wsor4035> https://cdn.discordapp.com/attachments/926231483155378176/1344823913657401384/image.png?ex=67c2505e&is=67c0fede&hm=2fd73c8a0d87d1cbe41c35fb66a9d8131fe107102ddfc574b8b3e29c6e390d0f&
00:10 MTDiscord <wsor4035> ....or 🤷
00:10 MTDiscord <greenxenith> (I changed it)
00:10 MTDiscord <wsor4035> idrc either way
00:12 MTDiscord <greenxenith> I cant reproduce https://github.com/luanti-org/docs.luanti.org/issues/206
00:12 MTDiscord <wsor4035> ....your eyes arent working?
00:12 MTDiscord <wsor4035> https://cdn.discordapp.com/attachments/926231483155378176/1344824607978426398/image.png?ex=67c25104&is=67c0ff84&hm=eb8f654a0a5384c8df543179b932d87870d8aac6fbefe31f3208578f0e2eefcb&
00:13 MTDiscord <wsor4035> https://cdn.discordapp.com/attachments/926231483155378176/1344824669790011482/image.png?ex=67c25112&is=67c0ff92&hm=586f4c4196646e8a565906ca3b4eaf5699db6ed8f0edf55aec230eb07c95785f&
00:13 MTDiscord <greenxenith> luatics comment is misleading > I think we should just not show the ToC button on sites where it's useless to begin with.
00:13 MTDiscord <greenxenith> Made it sound like there is a ToC shown
00:14 MTDiscord <wsor4035> i mean, the whole title to luatic comment took me longer than a second to figure out
00:15 MTDiscord <greenxenith> Wait no I was right
00:15 MTDiscord <greenxenith> OP > The Table of Contents (ToC) button at the top-right of the page does nothing on pages with only one heading.
00:15 MTDiscord <greenxenith> What button?
00:16 MTDiscord <greenxenith> This 100% reads as "there is a button, and it does nothing when there is only one heading"
00:16 MTDiscord <wsor4035> . s/button/section (assuming)
00:16 MTDiscord <greenxenith> I hope so
00:17 MTDiscord <wsor4035> @fyl2xp1 poke on https://github.com/luanti-org/docs.luanti.org/pull/194
00:20 MTDiscord <greenxenith> #202 note: I was against paginated changelog for searchability, but I remembered there is a search feature now so I would be fine with version per page
00:21 MTDiscord <wsor4035> for those who want a link https://github.com/luanti-org/docs.luanti.org/issues/202
00:22 MTDiscord <wsor4035> its been (however long, im to lazy to check) a while now, and no one is really using this, so thinking im just going to turn it back off
00:22 MTDiscord <wsor4035> https://cdn.discordapp.com/attachments/926231483155378176/1344827011675197523/image.png?ex=67c25341&is=67c101c1&hm=0090f0e7cfb648eb35274fc62cea312d5afa1f11f9fde4314e6a3c5c16359138&
00:25 MTDiscord <wsor4035> wait, who changed the merge policies? 🤔
00:25 MTDiscord <greenxenith> I havent touched them since we set things up
00:25 MTDiscord <wsor4035> not github stuff, the docs
00:26 MTDiscord <wsor4035> glances at mark via git blame
00:29 MTDiscord <wsor4035> fixed https://github.com/luanti-org/docs.luanti.org/commit/337c5442619ab74a5b7b72222ef3e87cdc08046b
00:30 MTDiscord <greenxenith> Uh, what?
00:30 MTDiscord <greenxenith> Isnt everything subject to luanti-docs approval?
00:31 MTDiscord <greenxenith> The rule you made was >     - Anything in /docs should be approved by one minetest-docs member that isn't yourself
00:31 MTDiscord <wsor4035> thats for the old minetest docs project content
00:31 MTDiscord <wsor4035> look at https://github.com/luanti-org/docs.luanti.org/commit/64af83ba078c18ac49015a3a5262f38f23477729#diff-2d4a4a9e88d954199480fdf2f9967187f6f1e77c149949c2640c4da4b778e7d2
00:31 MTDiscord <wsor4035> rules
00:31 MTDiscord <greenxenith> It says the same thing
00:32 MTDiscord <wsor4035> no /content != /focs
00:33 MTDiscord <wsor4035> mark made it say that everything has to be approved by a docs person that isnt yourself when that only applies to old minetest docs content
00:34 MTDiscord <greenxenith> Aha
00:34 MTDiscord <wsor4035> third point > - For all else: if you're a luanti-docs member, use your best judgement covers everything the first two dont
00:34 MTDiscord <fyl2xp1> Sorry, I'm super busy at work atm. Will try to have a look this weekend.
00:35 MTDiscord <wsor4035> no rush
00:36 MTDiscord <wsor4035> i mean, even the first two are only for substantial changes, if your just moving, breaking up, etc - whatever
00:39 MTDiscord <wsor4035> breaking up maybe should be refactoring? migrating pages? whatever, hopefully the point gets accross
00:39 MTDiscord <greenxenith> Ive split the Content label into General, Creators, Engine, Servers, and Players. Its not super important right now but later when we have other people with certain expertise it will be
00:40 MTDiscord <wsor4035> sounds good
00:41 MTDiscord <wsor4035> re https://github.com/luanti-org/docs.luanti.org/issues/178 wouldnt be opposed to a more general approach of baking information into content, rather than linking out to it unless there is a good reason
00:42 MTDiscord <wsor4035> avoids link rot, allows it to stay in focus for maintaining it and keeping it up to date, etc
00:43 MTDiscord <wsor4035> say tommorrow night im just going to disable this again
00:44 MTDiscord <wsor4035> unless someone can justify it, even after it not being used
01:12 MTDiscord <mark.wiemer> There is a button on mobile, sorry for the confusion
01:13 MTDiscord <greenxenith> Ahh
01:13 MTDiscord <greenxenith> Understood
01:13 MTDiscord <mark.wiemer> Sorry, it was a good faith misreading, thanks for fixing it
01:15 MTDiscord <mark.wiemer> Yeah, in general, the info should be on the site itself, not forum posts. Forums are for discussions and maybe user-created guides. "Official" docs should be hosted on our site for best user experience
12:44 MTDiscord <luatic> that is correct. perhaps worth adding that this only happens on smaller screen where you get the hamburgers (menu and toc) left and right.