Time Nick Message 01:01 MTDiscord your a core dev, so one approval, partial approve from sfence, approval from smalljoker, thats 2.5 reviews - if no one screams in irc, seems you could merge it now, so thus do i need to really put it on the agenda? 01:04 MTDiscord @celeron55 would you like the docs team/me to also take care of the website repo notice there are some prs over there in our area at least 03:03 [MatrxMT] I don't mind if #14964 is merged, it would be approved enough. I just hope that someone reviewed the logic properly, because it seems complicated and I unfortunately only had time for a superficial look. 03:05 [MatrxMT] oh, also, have the changes to the touchscreen controls been tested? 03:09 MTDiscord psa: not sure this is the right channel 03:11 [MatrxMT] modding help in -dev, engine dev in -docs... 😰 03:13 MTDiscord average day in the neighborhood 03:13 MTDiscord anyways, the idea of that pr is to get in early 5.12 so people can complain, poke holes, etc 03:21 [MatrxMT] gave it a very short test on Android with touch, worked 06:50 [MatrxMT] grorp: The thing to check in particular is whether thte back button / AC_BACK works (That's the thing I'm slightly concerned about due to sdl2-compat). I think I'll merge it at the beginning of the meeting in case anyone wants to review it during the weekend 08:09 MTDiscord Ideally I'd like to set up the Community/PR team which would handle the website and other things, but a good question is, what to do meanwhile 08:51 MTDiscord Are there folks interested in being on a PR team? 09:27 MTDiscord Working on https://github.com/luanti-org/docs.luanti.org/issues/66 now, let me know if there are changes you'd like to prioritize 09:47 MTDiscord Well that's why two things are bundled together. Most of Luanti PR is about community events and stuff like that anyway so it comes naturally 09:48 MTDiscord Sorry I'm new and confused. Is there an existing Community team? 09:48 MTDiscord No 09:48 MTDiscord None of this exists in any official form 09:48 MTDiscord Unofficially certain people have been doing this type of stuff though 09:49 MTDiscord Gotcha yeah, if we were to setup a team it makes sense that community and PR would be the same team 09:50 MTDiscord I get that docs and PR are different for sure, but we're happy to help. I think the concern is waiting for this team to be set up--are there active discussions on that front? 09:52 MTDiscord I'm still in the, let's say, seed phase. Which means I'm occasionally bringing it up so that those interested can discuss about it 09:53 MTDiscord I don't like setting up empty rooms and forcing something to happen. I'll rather slowly spin up awareness and interest over time 09:56 MTDiscord yeah absolutely. The question is, what do we do with those PRs in the meantime? Ideally we set up a team, but that'll take a while, I vote we as the docs team review what we can for now 🙂 09:56 MTDiscord (I see you said the same question earlier, lol, apologies for bad reading comprehension) 09:56 MTDiscord If you feel like it's not a burden, I have nothing against it 10:00 MTDiscord Reviewed the 3 PRs in https://github.com/luanti-org/luanti-org.github.io/pulls?q=sort%3Aupdated-desc+is%3Apr+is%3Aopen, PR build is failing, might look into it later. 2 of 3 reviews were approvals 🙂 10:13 MTDiscord Merging https://github.com/luanti-org/docs.luanti.org/pull/212 in ~30 hours unless I get an earlier approval 🙂 11:35 [MatrxMT] y5nw: the AC_BACK thing is for Android. the Android build uses actual SDL 2, not sdl2-compat: https://github.com/luanti-org/luanti_android_deps 11:53 [MatrxMT] grorp: Ok, good. I just want to make sure since AC_BACK does not work with sdl2-compat (from testing with a bluetooth keyboard with an AC_BACK key) 16:31 MTDiscord idk, just add the docs team for now and those of us who are comfortable can handle them? more so caring about the existing docs pr. i suppose being super triager i have rights to actually do so, just not officially "licensed" or whatever to do so 16:31 MTDiscord maybe the docs team already has rights to that repo? cant tell 17:32 MTDiscord I did add the docs team to the website repo 18:35 MTDiscord going to merge https://github.com/luanti-org/luanti-org.github.io/pull/327 in 10 minutes 18:40 MTDiscord also if anyone wants ot make a docs engine pr: https://github.com/luanti-org/luanti/issues/15907 18:52 MTDiscord merging https://github.com/luanti-org/luanti-org.github.io/pull/325 in 5 18:58 MTDiscord well, there we go, all the website prs are taken care of 18:58 MTDiscord now onto the onslaught of don packages on cdb 🔫 19:08 Krock mypackages 19:12 MTDiscord 26 to be exact, most approved 19:13 MTDiscord at least they got rid of there stupid crayon license