Time  Nick       Message
19:32 Sheriff_U3 Codeberg's web UI got updated it looks like :)
20:01 crazylad   any thoughts/opinions on this? -> https://github.com/luanti-org/luanti/issues/17329
20:04 Sheriff_U3 I think it makes sense to throw it into #16846
20:04 ShadowBot  https://github.com/luanti-org/luanti/issues/16846 -- Formspec: Make inventory slots stay hovered on formspec update by CrazyladMT
20:53 Sokomine   seems  ItemStack("- no item set -"):is_known() is true? bug or intetion i don't get?
21:10 Sokomine   i've added an issue
21:19 cheapie    It looks like doing that (calling ItemStack() with a completely invalid/unparseable string argument) is equivalent to calling ItemStack() with no arguments at all
21:21 cheapie    I'm not sure what the correct behavior really should be, I would be inclined to say error but there might be mods feeding arbitrary user input to ItemStack() that would start crashing
21:24 Sheriff_U3 cheapie: then the mods should have validated the string before using it.
21:24 cheapie    They should have, but if you let people not do so then some of them won't
21:26 Sokomine   in this case i wanted to use ItemStack to do exactly that - validate the input without having to parse it myself
21:26 cheapie    That doesn't sound like something ItemStack() is meant to do
21:28 cheapie    FWIW I suspect the reason :is_known() returns true is because the empty string is a registered item (the hand)
21:30 Sokomine   oh. that is very surprising. didn't know that. the connection is far from obvious. at least it ought to be mentionned that if ItemString fails to create one it creates an empty one, and that/why an empty one is known?
21:44 Sokomine   cheapie: perhaps you can add your thoughts/observations to the issue
21:47 cheapie    done
21:51 Sokomine   thanks!