Time Nick Message 00:15 MTDiscord pgimeno: yep, the compiler can. it goes even further and computes sin and cos both at once! https://godbolt.org/z/zoozPh6Mb 07:34 pgimeno luatic: great, thanks for the info 16:23 [MatrxMT] since Desour has approved #15614 now, asking sfan5: do you want me to wait for your review? 16:23 ShadowBot https://github.com/minetest/minetest/issues/15614 -- In-game settings menu using separate Lua env by grorp 16:24 [MatrxMT] Zughy has put a meeting note for feature freeze tomorrow 👀 16:26 [MatrxMT] one thing to consider with that PR is that it'll need follow-up PRs to be completed, users might ask "why doesn't changing this setting do anything?" otherwise 16:27 [MatrxMT] on the other hand, if you wait for everything to be ready before even doing the first step, nothing is ever going to happen 16:29 [MatrxMT] a good compromise could be: merge now so the first step is done, disable the feature for release if necessary (easy to do by replacing the button in the pause menu) 16:41 MTDiscord Or add a small note in the pause menu that its still WIP - I'd like to see this in the next release, really great work grorp :D 18:19 MTDiscord it turns out luanti shot me in the foot approximately 3 years ago but i only realized now. 19:10 [MatrxMT] siliconsniffer's suggestion sounds like a great compromise 19:11 [MatrxMT] Having to return back to the main menu every time was one of the biggest issues people found out when playing Luanti games at conventions 19:11 celeron55 i agree as long as some settings update right away, it's better than not having it 19:12 celeron55 there are always obscure things especially to new users, that's not something to be afraid of 19:13 celeron55 (as long as it's, let's say, relatively temporary) 19:13 MTDiscord i agree that if we make the "not everything will work" obvious, it's okay for now 19:13 MTDiscord in fact it may help us discover some such issues more quickly 19:14 celeron55 there will always be settings that don't update without quitting to the menu. even if the engine does it perfect, some mods won't 19:15 MTDiscord Re settings that don't update right away: game-added custom settings 19:15 MTDiscord in fact there will be some settings that can't be updated without restarting the game 19:22 celeron55 for sure, some game settings might require rolling back so much game state that it doesn't even make sense to do it in any other way than restarting the server 19:24 MTDiscord the most useful settings for being accessible from the pause menu would be the ones in the categories of primarily client-side settings fwiw 19:24 celeron55 it might be beneficial to be able to flag settings in settingtypes.txt as whether updating them requires restarting the game/server or restarting the client 19:25 celeron55 then a suitable notice can be shown to the user 19:25 MTDiscord Zughy: Yep, totally agree. Finally one can set the mouse sensitivity just right without quitting the game a hundred times :D 19:25 [MatrxMT] read https://github.com/minetest/minetest/issues/6722#issuecomment-2567014733 already 19:30 [MatrxMT] (I was annoyed because this felt like a dejavu of nrz's comment on the PR, could have said that more polite) 19:31 [MatrxMT] *politely 19:36 [MatrxMT] I agree that siliconsniffer's suggestion sounds good. could reuse some code from #15272 for a warning. 19:36 ShadowBot https://github.com/minetest/minetest/issues/15272 -- Show warning in the settings menu when shaders are disabled by grorp 19:36 [MatrxMT] and thanks 19:41 [ you can already change settings without restarting with a CSM, but some settings won't update (I have a patch that makes fov update when set at runtime that I should probably submit) and others will crash (enabling/disabling shaders) 19:42 MTDiscord grorp: that's what I thought too, sounds fine to me =) 23:42 sfan5 grorp: feel free to merge 23:42 MTDiscord 5.11 is gonna be lit 23:43 MTDiscord goes back to poking in irrlicht's skeletal animation innards 23:55 Desour I didn't know ghosts have innards, or bones