Time Nick Message 01:21 MTDiscord oh, would this PR be good to just put into dev.luanti.org? https://github.com/luanti-org/luanti/pull/15510 ? If not, curious if you guys know who might be a good reviewer--sfan5 says they're busy :/ 01:22 MTDiscord Maybe we can do both. But I do think the dev site is the right host for advanced documentation, and the engine itself should have simple guides with links to the dev site for further info 01:23 MTDiscord gonna go ahead and open a PR now 🙂 01:26 MTDiscord nah, thats engine build stuff, i mean, kinda outside of there wheelhouse, but maybe lars or grorp could be worth a try? wild cards im not sure would be sfence or cx384 01:27 MTDiscord https://github.com/luanti-org/luanti/pull/15718 01:27 MTDiscord iirc its feature freeze soon or already, so not sure if its worth pushing this pr 01:27 MTDiscord good to know, no rush, just don't want the PR to get too too rusty 01:27 MTDiscord probably best to update the urls so they dont need the redirects 01:29 MTDiscord http://dev.minetest.net/Category:Rules_and_Guidelines is dead, should be https://dev.luanti.org/engine-dev-process/ probably? also worth http -> https 01:29 MTDiscord The challenge is that we haven't finalized the URLs really, right? 01:29 MTDiscord I can defs do https though 01:30 MTDiscord 🤷 could ignore that - please remove /Main_Page that one is for sure stupid (root of site now, as it always should have been) 01:30 MTDiscord that's fair 01:31 MTDiscord done 01:32 MTDiscord thoughts on the first half of this? 01:37 MTDiscord ah missed that, sry 01:37 MTDiscord np 01:39 MTDiscord Thinking I'll link to one of the subpages, probably "all rules" 01:39 MTDiscord https://cdn.discordapp.com/attachments/926231483155378176/1332887498254188618/image.png?ex=6796e3b7&is=67959237&hm=f5ede8ce0419ebaf389996d65a826f99d3b13dda29a4818c44fc75470afc0654& 01:39 MTDiscord https://cdn.discordapp.com/attachments/926231483155378176/1332887498736799754/image.png?ex=6796e3b7&is=67959237&hm=d04641446ed03a8b5091dc3402743701923926cee1ee68f7e641f3e34268e7c4& 01:39 MTDiscord tbh, we really should just make all rules _index.md and add an alias for all rules 01:40 MTDiscord agreed, but for now I have made my decision 😄 02:18 MTDiscord made a pr for that https://github.com/luanti-org/dev.luanti.org/pull/151 04:12 MTDiscord im proposing adding mark to the luanti-docs team thoughts? objections? (feel free to dm me if you feel the need) 04:26 MTDiscord Happy to answer questions tmrw morn, but I'm based in UTC-8, gonna sign off for the night 🙂 09:16 MTDiscord the PR is probably being ignored as a silent protest because nobody really cares about MSVC, it's not used for official builds and keeping it around is just a burden to keep people who want to use visual studio happy. everyone else uses LLVM-based mingw or some form of it including the official windows builds, either cross-compiling from linux or building it natively in MSYS2 09:33 MTDiscord but yeah putting that into dev.luanti.org would be ok, better than having it be lost 10:38 rubenwardy Less of a protest and more that not many reviewers use windows and msvc 10:38 rubenwardy sfan5 uses windows but prefers mingw 10:38 rubenwardy Actually he might just use windows via a VM idk 10:39 rubenwardy I don't have Windows installed anywhere 13:11 MTDiscord protest might have been too strong of a word, but I do still feel like it is only begrudgingly supported to make sure it still compiles in CI :) 13:12 MTDiscord I do would wish that approval of the PR can be made on the grounds that Mark has at least some amount of knowledge about it, can show that the instructions can be successfully followed to compile, and that other contributors (such as Josiah) also has had success with the new instructions, even if the coredev(s) approving it may not use MSVC or have tested it, but have given it enough of a skim throug to make sure it doesn't contain 13:12 MTDiscord a command to format your C: drive 13:12 MTDiscord (I have no idea about the current official windows compilation instructions that are in the engine repo but from people's experiences with it, talking on discord, I don't know if they even work anymore. so it could only become better, realistically speaking) 13:45 MTDiscord I don't have Windows installed anywhere either 13:47 MTDiscord I didn't try the GUI installation yet. 13:47 MTDiscord Has anyone tried it? 13:50 MTDiscord The good thing is, it's hard for Mark to make the situation on Windows worse than it already is, right? We have no instructions for using VSCode (there are other good guides out there like Exe's for MSYS2), so I think Roller is urging us in the right direction. 15:22 MTDiscord If there is a preferred way to compile via Windows, I'm all ears. The instructions I posted work and I feel they're relatively simple in terms of tools, but I could be way off 15:25 MTDiscord I'll see if I have time to look at mingw and how the official tools work 15:26 MTDiscord Official current instructions are bad, hence the PR 🙂 15:38 MTDiscord compiling with visual studio would be the preferred way for people who want to compile it "the windows way", and with a preconfigured IDE to go along with it for development. the mingw-based methods, e.g. MSYS2 or cross-compiled llvm-mingw are a bit more do-it-yourself past the compilation part and more linux-y in nature (using gdb for debugging and such) 15:39 MTDiscord there is the MSYS2 compilation instructions which I wrote, that is in dev.luanti.org now, and there are the instructions for manually using the cross-compiler buildbot from linux that I dumped in discord a while back but haven't written about yet 15:42 MTDiscord ...which takes me to this message re: moving some dev/IDE-related documentation to dev.luanti.org. I think the engine repo should still probably keep some simple compile instructions for linux/windows/mac maybe, but the rest we could have here and be linked from the engine repo docs 15:44 MTDiscord like currently here we have an article for compiling the headless linux server, alternative to compiling for windows with MSYS2, and compiling for android both with android studio and with the command-line tools 16:02 MTDiscord im just going to bump this 16:03 MTDiscord yeaj just add him already 16:04 MTDiscord just going to cc @greenxenith as the last "active" person 16:04 MTDiscord after that will do 23:46 MTDiscord No objections 23:50 MTDiscord @celeron55 if you could add mark-wiemer to the docs team? (i only have permissions for people already in the org)