| Time |
Nick |
Message |
| 03:00 |
|
SFENCE_arch joined #luanti-dev |
| 05:00 |
|
MTDiscord joined #luanti-dev |
| 06:22 |
|
SFENCE_arch joined #luanti-dev |
| 07:41 |
|
GreenXenith joined #luanti-dev |
| 07:42 |
|
MTDiscord joined #luanti-dev |
| 09:46 |
|
loggingbot_ joined #luanti-dev |
| 09:46 |
|
Topic for #luanti-dev is now FEATURE FREEZE IN EFFECT. Luanti (fka Minetest) core development and maintenance. Chit chat goes to #luanti. https://dev.luanti.org/ https://irc.luanti.org/ https://github.com/luanti-org |
| 09:47 |
|
SFENCE_arch joined #luanti-dev |
| 10:10 |
|
SFENCE joined #luanti-dev |
| 10:50 |
|
hwpplayer1 joined #luanti-dev |
| 11:04 |
|
wsor40355 joined #luanti-dev |
| 11:10 |
|
SFENCE joined #luanti-dev |
| 11:12 |
|
SFENCE joined #luanti-dev |
| 11:36 |
|
wsor4035 joined #luanti-dev |
| 11:38 |
|
SFENCE joined #luanti-dev |
| 11:45 |
SFENCE_arch |
What about Candidate Release for 5.11? |
| 12:01 |
sfan5 |
we could do one this evening |
| 12:01 |
sfan5 |
after my two PRs |
| 12:08 |
MTDiscord |
<siliconsniffer> Could #15736 be considered too? |
| 12:08 |
pgimeno |
https://github.com/luanti-org/luanti/pull/15736 -- Fix buggy behavior in parts of the main menu by siliconsniffer |
| 12:24 |
SFENCE_arch |
sfan5: Nice, I will try to fix #15745 on it. |
| 12:24 |
pgimeno |
https://github.com/luanti-org/luanti/issues/15745 -- Codesigning on MacOS |
| 12:43 |
MTDiscord |
<grorp> If I got a PR for the "Deal with client-side vs server-side vs both sides settings correctly" item of #15701 ready, would other core devs still want that for 5.11? |
| 12:43 |
pgimeno |
https://github.com/luanti-org/luanti/issues/15701 -- "Settings in the pause menu" to-do list |
| 12:44 |
MTDiscord |
<grorp> arguably at this point we might just want to add the warning box and continue after 5.11 |
| 12:45 |
MTDiscord |
<luatic> depends on how large and tricky the PR is. it would count as a bugfix imo, but not all bugfixes are suitable for a late merge. |
| 12:46 |
MTDiscord |
<luatic> just open it if it's ready, we can see about it then |
| 13:27 |
|
SFENCE joined #luanti-dev |
| 13:30 |
|
ivanbu joined #luanti-dev |
| 13:46 |
SFENCE |
There is no longer avaliable builds from github workflows to donwload? |
| 13:46 |
sfan5 |
should be |
| 13:46 |
MTDiscord |
<astra008.> There are |
| 13:46 |
MTDiscord |
<rollerozxa> there is, you need to be logged into github to download them |
| 13:47 |
SFENCE |
I am logged in, and do not see them. |
| 13:48 |
MTDiscord |
<astra008.> Sending a screenshot might help |
| 13:48 |
MTDiscord |
<luatic> might be a GH problem, there've been quite a few recently |
| 13:53 |
SFENCE |
https://ibb.co/dsxwJD6c |
| 13:53 |
MTDiscord |
<wsor4035> summary tab? |
| 13:53 |
MTDiscord |
<siliconsniffer> Ah, click on "Summary" in the top left |
| 13:54 |
SFENCE |
ok. Here. Thanks. |
| 15:00 |
|
SFENCE joined #luanti-dev |
| 15:37 |
|
SFENCE_arch joined #luanti-dev |
| 16:05 |
|
SFENCE joined #luanti-dev |
| 16:54 |
|
SFENCE joined #luanti-dev |
| 16:59 |
|
Desour joined #luanti-dev |
| 17:23 |
|
SFENCE joined #luanti-dev |
| 17:57 |
|
LandarVargan joined #luanti-dev |
| 17:57 |
|
LandarVargan left #luanti-dev |
| 17:58 |
|
[MatrxMT] joined #luanti-dev |
| 18:00 |
MTDiscord |
<mistere_123> test |
| 18:02 |
|
MisterE123 joined #luanti-dev |
| 18:02 |
MisterE123 |
test |
| 18:04 |
[MatrxMT] |
<MisterE> Well matrix (minetest-dev) is now bridged to irc #luanti-dev |
| 18:04 |
[MatrxMT] |
<MisterE> Please note that discord is not yet bridged here (I don't control the discord bridge) |
| 18:10 |
|
SFENCE joined #luanti-dev |
| 18:10 |
MTDiscord |
<wsor4035> the above is false |
| 18:15 |
MTDiscord |
<mistere_123> lol yup. The transfer to discord took its sweet time |
| 18:16 |
[MatrxMT] |
<MisterE> But now seems to be happening in real time |
| 18:34 |
MTDiscord |
<luatic> ah thanks |
| 18:35 |
MTDiscord |
<luatic> A general question I'm asking myself: I'm not aware of a good way to ensure that PRs that touch headers don't introduce unwanted reliance on transitive includes; checking the entire files manually is infeasible. Is this something we just have to accept as a C++ shortcoming? (When will we be able to use C++ 20 modules?) |
| 18:37 |
Desour |
@luatic: there's IWYU, which can help you include everything that you use (as it name suggests) |
| 18:41 |
Desour |
but starting to use IWYU would introduce a lot of more includes, or last time I tried applying it to luanti it did, iirc. and I'm not sure about false positives or so, and C includes (e.g. lua.h) not being handled correctly |
| 18:41 |
MTDiscord |
<luatic> I'll look into that, thanks. I think I may have falsely interpreted the name in the past as "include only what you use", so "don't include what you don't use". |
| 18:42 |
MTDiscord |
<luatic> I think for the purposes of reviewing PRs that touch includes it might be fine? I'd just check whether in the set of new includes it wants to add, some have been removed in the diff of the PR. |
| 18:43 |
MTDiscord |
<luatic> Could even attempt to automate it if someone else hasn't already, though that would put me right in https://xkcd.com/1319/ territory :p |
| 18:43 |
Desour |
as for being able to use C++20 modules: it requires not only compiler support, but also build system (i.e. cmake, ninja) support. I don't see a bright near future |
| 18:47 |
SFENCE_arch |
And System support on macOS. https://developer.apple.com/xcode/cpp/#c++20 |
| 19:34 |
[MatrxMT] |
<Zughy> Oh hey, hello again from Matrix |
| 19:35 |
[MatrxMT] |
<Zughy> It was very nice meeting many of you in real life c: |
| 23:34 |
|
panwolfram joined #luanti-dev |
| 23:50 |
[MatrxMT] |
<Zughy> we probably have a movement regression (can't do it with 5.10). Super tired due to FOSDEM, I hope to have a minimal test ready for these days, hopefully tomorrow |
