| Time |
Nick |
Message |
| 00:19 |
|
SFENCE joined #luanti-dev |
| 00:47 |
|
fluxionary_ joined #luanti-dev |
| 00:53 |
|
SFENCE joined #luanti-dev |
| 01:27 |
|
SFENCE joined #luanti-dev |
| 02:00 |
|
SFENCE joined #luanti-dev |
| 02:37 |
|
SFENCE joined #luanti-dev |
| 02:47 |
|
fluxionary_ joined #luanti-dev |
| 03:54 |
|
hwpplayer1 joined #luanti-dev |
| 04:00 |
|
MTDiscord joined #luanti-dev |
| 04:08 |
|
SFENCE joined #luanti-dev |
| 04:41 |
|
SFENCE joined #luanti-dev |
| 04:47 |
|
fluxionary_ joined #luanti-dev |
| 05:05 |
|
hwpplayer1 joined #luanti-dev |
| 05:12 |
|
SFENCE joined #luanti-dev |
| 06:47 |
|
fluxionary_ joined #luanti-dev |
| 06:54 |
|
SFENCE joined #luanti-dev |
| 08:01 |
|
SFENCE joined #luanti-dev |
| 08:08 |
|
SFENCE joined #luanti-dev |
| 08:10 |
|
SFENCE joined #luanti-dev |
| 08:18 |
|
SFENCE joined #luanti-dev |
| 08:22 |
|
Warr1024 joined #luanti-dev |
| 08:47 |
|
Warr1024 joined #luanti-dev |
| 09:17 |
|
SFENCE joined #luanti-dev |
| 09:35 |
|
AntumDeluge joined #luanti-dev |
| 09:47 |
|
fluxionary_ joined #luanti-dev |
| 09:59 |
|
SFENCE joined #luanti-dev |
| 10:08 |
|
SFENCE joined #luanti-dev |
| 10:36 |
|
SFENCE joined #luanti-dev |
| 11:47 |
|
fluxionary_ joined #luanti-dev |
| 12:23 |
|
SFENCE joined #luanti-dev |
| 12:42 |
|
SFENCE joined #luanti-dev |
| 12:54 |
|
SFENCE joined #luanti-dev |
| 12:58 |
|
SFENCE joined #luanti-dev |
| 13:04 |
|
SFENCE joined #luanti-dev |
| 16:12 |
|
SFENCE joined #luanti-dev |
| 16:21 |
sfan5 |
merging #15900, #15867, #15836, #15773 once I get back from a walk |
| 16:21 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/15900 -- Reload font manager in main thread to avoid a crash by deveee |
| 16:21 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/15867 -- Mostly deal with problems caused by polygon offset by sfan5 |
| 16:21 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/15836 -- [nosq] simplify position encoding, remove "black magic" by kno10 |
| 16:21 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/15773 -- Bump OARS content rating to 1.1 by AFCMS |
| 16:24 |
[MatrxMT] |
<Zughy> - Forrest Gump |
| 17:28 |
Krock |
sfan5: #15821 did replace #15674 and was now closed automatically. Is that intentional? Shall I open a separate bug report for https://github.com/luanti-org/luanti/issues/15821#issuecomment-2727307221 ? |
| 17:28 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/15821 -- Polygon offset of node overlays causes Z-issues with outline and other nodes |
| 17:28 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/15674 -- Very small nodeboxes z-fighting with overlay tile of neighboring node |
| 17:59 |
sfan5 |
that's intentional yes |
| 17:59 |
sfan5 |
didn't someome report the water thing as a separate bug previously? |
| 18:03 |
Krock |
#9324 seems related but aside from that I don't really know |
| 18:03 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/9324 -- Flowing liquid z-fights with allfaces node if you're inside the liquid |
| 18:17 |
|
cx384 joined #luanti-dev |
| 18:19 |
sfan5 |
should core.override_item be allowed at runtime? |
| 18:21 |
Krock |
what use-cases could there possibly be? The last chance should be in on_mods_loaded and not a blink after that |
| 18:22 |
MTDiscord |
<wsor4035> iirc you can do up to minetest.after 0 with decent results |
| 18:23 |
sfan5 |
you can do it at any time currently |
| 18:23 |
sfan5 |
of course it will only work correctly until a client joins |
| 18:24 |
sfan5 |
I have a feeling that if a strict check is added cases will crop up where override_item it used to set whatever custom variables at runtime |
| 18:27 |
Krock |
non-terminating error log |
| 18:27 |
sfan5 |
so you'd still apply the changes or not? |
| 18:28 |
Krock |
yes but with a message at maximum annoyance levels |
| 18:28 |
Krock |
actually if it's not documented then we could just add a strict check .. hmm. |
| 18:30 |
sfan5 |
in fact you can also register a node at runtime as long as you use the `:name` syntax |
| 18:30 |
Krock |
maybe sanity always prevented me from trying that |
| 18:32 |
MTDiscord |
<wsor4035> at least in singleplayer, that will work in most instances up to minetest.after 0, however some mapgen things will start to silently fail/not work, after that your node wont have textures, etc |
| 18:32 |
sfan5 |
also aliases probably |
| 18:32 |
sfan5 |
nodes registered late will be missing from core.get_content_id() or core.get_name_from_content_id() however since that cache is initialized only once |
| 18:32 |
sfan5 |
and probably countless other things |
| 18:33 |
sfan5 |
so in conclusion: override_item should be allowed with a very annoying warning. new registrations must not be allowed. |
| 18:34 |
Krock |
just my two cents. I wouldn't oppose an outright (terminating) error either. |
| 18:39 |
|
SFENCE joined #luanti-dev |
| 18:42 |
|
SFENCE joined #luanti-dev |
| 18:46 |
cx384 |
merging #15743 and #15911 in 15 min |
| 18:46 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/15743 -- Fix overrideable hand ToolCapabilities and range by cx384 |
| 18:46 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/15911 -- Add documentation for core.MAP_BLOCKSIZE constant by XueSongTap |
| 19:03 |
cx384 |
merged |
| 19:08 |
[MatrxMT] |
<y5nw> sfan5: do you still want to review #14964? I plan to merge it soon otherwise |
| 19:08 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/14964 -- SDL: Use scancodes for keybindings by y5nw |
| 19:09 |
sfan5 |
no, feel free to |
| 19:09 |
[MatrxMT] |
<y5nw> Ok, merging it in 15m |
| 19:09 |
Krock |
goodbye my beloved Shift + 7, you'll be missed. Sacrifices must be made until sdl3 becomes widely adopted ... |
| 19:11 |
[MatrxMT] |
<y5nw> Krock: #14874 |
| 19:11 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/14874 -- Allow keybindings with modifiers by y5nw |
| 19:11 |
Krock |
oh right! \o/ |
| 19:12 |
[MatrxMT] |
<y5nw> (Ok, it's on a chain of PRs, but I can rebase those soon) |
| 19:30 |
sfan5 |
VL has a bunch of "Item definition has a metatable, this is unsupported and it will be overwritten" warnings |
| 19:31 |
sfan5 |
and it falls over because it tries to use register_alias_force at runtime |
| 19:31 |
sfan5 |
so I guess strictness is already proving useful |
| 19:35 |
[MatrxMT] |
<y5nw> Merged |
| 19:47 |
sfan5 |
#15912 revised |
| 19:47 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/15912 -- [no sq] Increase strictness for item registration / overrides by sfan5 |
| 19:49 |
[MatrxMT] |
<Zughy> It's really been merged :o congratulations everyone 🎉 |
| 19:52 |
cx384 |
ci failed? |
| 19:55 |
sfan5 |
i'll try a re-run |
| 19:56 |
cx384 |
Is test_node_callbacks flaky? |
| 19:56 |
sfan5 |
I don't think so |
| 20:07 |
|
SFENCE joined #luanti-dev |
| 20:17 |
|
SFENCE joined #luanti-dev |
| 20:38 |
|
SFENCE joined #luanti-dev |
| 20:48 |
|
SFENCE joined #luanti-dev |
| 20:54 |
|
SFENCE joined #luanti-dev |
| 20:59 |
|
SFENCE joined #luanti-dev |
| 21:34 |
|
YuGiOhJCJ joined #luanti-dev |
| 23:33 |
|
panwolfram joined #luanti-dev |
