| Time |
Nick |
Message |
| 00:06 |
MTDiscord |
<herowl> Just thaw it |
| 00:19 |
MTDiscord |
<luatic> personally i wouldn't freeze yet and the current planned release date (May 11) doesn't necessitate it. maybe in a week or two? |
| 00:33 |
|
izzyb joined #luanti-dev |
| 01:56 |
|
SFENCE_arch joined #luanti-dev |
| 04:00 |
|
MTDiscord joined #luanti-dev |
| 06:28 |
sfan5 |
sure |
| 06:34 |
sfan5 |
#14631 for 5.12 then? |
| 06:34 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/14631 -- Add spatial index for objects by appgurueu |
| 06:55 |
|
SFENCE joined #luanti-dev |
| 07:06 |
|
SFENCE joined #luanti-dev |
| 11:50 |
MTDiscord |
<luatic> i think we can do that. let me convert the k-d-tree tests to catch2 though.. |
| 13:20 |
MTDiscord |
<luatic> can we maybe have automatic formatting at some point? i feel like it could save everyone some time. |
| 13:21 |
MTDiscord |
<luatic> (also, do we have a style guide for TEST_CASE and SECTION macros? do we put the curlies on the same line or not? do we indent a single TEST_CASE in a file or not? (i would prefer not, since it doesn't add much)) |
| 13:38 |
sfan5 |
we had clang-format and you know how that went |
| 13:39 |
sfan5 |
we could keep the file around as a guideline or e.g. if you copy in some code and want it to match the rest of Luanti |
| 14:28 |
MTDiscord |
<josiah_wi> Lars, in the tests I wrote so far, I did curlies after the macros on the next line. That's how I've seen it done in other projects so I just copied them. |
| 14:29 |
MTDiscord |
<josiah_wi> I don't see any point in indenting a TEST_CASE. Indentation should show scope, so a TEST_CASE declared at global scope should not be indented. |
| 15:02 |
|
SFENCE joined #luanti-dev |
| 15:27 |
sfan5 |
planning to merge #14631 later |
| 15:27 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/14631 -- Add spatial index for objects by appgurueu |
| 15:51 |
|
SFENCE joined #luanti-dev |
| 16:01 |
|
hwpplayer1 joined #luanti-dev |
| 16:50 |
|
SFENCE joined #luanti-dev |
| 17:02 |
|
SFENCE joined #luanti-dev |
| 17:15 |
|
SFENCE joined #luanti-dev |
| 17:55 |
|
SFENCE joined #luanti-dev |
| 18:50 |
|
SpaceManiac joined #luanti-dev |
| 19:10 |
|
SFENCE joined #luanti-dev |
| 20:50 |
|
turtleman joined #luanti-dev |
| 21:47 |
|
Sharpman joined #luanti-dev |
| 22:17 |
|
v-rob joined #luanti-dev |
| 22:23 |
v-rob |
Anyone have any thoughts on #15971? The code's been approved, but I want to leave a chance for feedback on the pause menu/escape situation. |
| 22:23 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/15971 -- Add allow_close[] element to formspecs by v-rob |
| 22:25 |
[MatrxMT] |
<grorp> left a comment on something else just before seeing this :) |
| 22:33 |
|
panwolfram joined #luanti-dev |
| 22:50 |
|
MTDiscord joined #luanti-dev |
