| Time |
Nick |
Message |
| 00:37 |
|
fgaz_ joined #luanti-dev |
| 00:37 |
|
HamAdams_ joined #luanti-dev |
| 00:37 |
|
ShadowBot` joined #luanti-dev |
| 00:39 |
|
[0] joined #luanti-dev |
| 00:40 |
|
dzho_ joined #luanti-dev |
| 04:00 |
|
MTDiscord joined #luanti-dev |
| 05:14 |
|
Sheriff_U3 joined #luanti-dev |
| 05:20 |
|
pgimeno joined #luanti-dev |
| 06:18 |
|
BuckarooBanzai joined #luanti-dev |
| 07:45 |
|
ivanbu joined #luanti-dev |
| 07:51 |
|
ivanbu joined #luanti-dev |
| 10:13 |
sfan5 |
any reviews for #17095? |
| 10:13 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/17095 -- Implement `core.get_active_blocks`, `core.get_loaded_blocks` and `core.get_loadable_blocks` APIs by kromka-chleba |
| 11:01 |
|
SpaceMan1ac joined #luanti-dev |
| 13:38 |
|
SFENCE joined #luanti-dev |
| 13:39 |
SFENCE |
Code looks fine, I can try to compile and test later. |
| 14:15 |
|
SFENCE joined #luanti-dev |
| 14:25 |
|
SFENCE joined #luanti-dev |
| 14:32 |
|
SFENCE joined #luanti-dev |
| 15:30 |
Krock |
I'm hesitant to give any feedback on this PR because the underlying mapblock state code is IMO imperfect, and thus this PR might cause modders to further rely on that. |
| 15:37 |
|
MTDiscord1 joined #luanti-dev |
| 16:17 |
pgimeno |
isn't that feedback in itself? |
| 16:18 |
Krock |
It's feedback as in "maybe good, maybe bad. It's probably too early and it's not your fault." |
| 16:25 |
pgimeno |
I mean, your concern seems sensible, but if it's not indicated, it might get merged with people unaware of that problem |
| 16:33 |
|
SFENCE joined #luanti-dev |
| 16:41 |
|
SFENCE joined #luanti-dev |
| 19:01 |
|
SFENCE joined #luanti-dev |
| 19:57 |
|
HamAdams joined #luanti-dev |
| 20:35 |
|
SFENCE joined #luanti-dev |
| 21:59 |
|
SFENCE joined #luanti-dev |
| 22:19 |
|
SFENCE joined #luanti-dev |
| 22:35 |
|
panwolfram joined #luanti-dev |
| 22:53 |
|
SFENCE joined #luanti-dev |
| 23:35 |
|
SFENCE joined #luanti-dev |