| Time |
Nick |
Message |
| 00:49 |
|
YuGiOhJCJ joined #luanti-dev |
| 03:00 |
|
MTDiscord1 joined #luanti-dev |
| 03:04 |
|
pinkuin_basxto joined #luanti-dev |
| 04:00 |
|
MTDiscord joined #luanti-dev |
| 05:26 |
|
MTDiscord joined #luanti-dev |
| 08:33 |
|
SpaceManiac joined #luanti-dev |
| 11:45 |
fgaz |
Hi all. Can I get some feedback on https://github.com/luanti-org/luanti/pull/17162? I'd like to know if I can continue with the plan I laid out or if I should abandon it |
| 11:53 |
fgaz |
I'm not asking for a full review (the PR is still WIP), just a concept approval/rejection |
| 14:34 |
|
crazylad joined #luanti-dev |
| 14:34 |
|
crazylad joined #luanti-dev |
| 17:35 |
Krock |
as long it's opt-out, it seems fine by me. I also thought of storing keys or possibly hashes to anonymize passwords ... it's difficult to get right and the so far best place to keep them is probably in the depths of ~/.config, %APPDATA% respectively. |
| 17:36 |
Krock |
as for UI design -> global checkbox "[ ] Remember login" under username/password in the main menu |
| 17:37 |
Krock |
removing the server favourite should then erase the login data. Just thinking out loud. It's more important to get the basic concept approved, improved or rejected |
| 18:20 |
MTDiscord |
<luatic> peeked at the library, opened an issue: https://github.com/hrantzsch/keychain/issues/51 (it uses std::string for passwords) |
