| Time |
Nick |
Message |
| 04:00 |
|
MTDiscord joined #luanti-dev |
| 07:33 |
|
Eragon joined #luanti-dev |
| 08:22 |
|
Warr1024 joined #luanti-dev |
| 08:47 |
|
Warr1024 joined #luanti-dev |
| 10:51 |
|
book`_ joined #luanti-dev |
| 11:00 |
[MatrxMT] |
<cx384> Merging #17404 in 15 min |
| 11:00 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/17404 -- [no squash] Fix pushing non existing palette to Lua and rename fields by cx384 |
| 12:28 |
|
MTDiscord joined #luanti-dev |
| 13:21 |
|
siliconsniffer joined #luanti-dev |
| 13:37 |
|
YuGiOhJCJ joined #luanti-dev |
| 13:58 |
|
erbium joined #luanti-dev |
| 14:23 |
|
YuGiOhJCJ joined #luanti-dev |
| 14:28 |
|
YuGiOhJCJ joined #luanti-dev |
| 14:47 |
MTDiscord |
<.zenonseth> I'm curious, did the meeting take place? is it held here or another channel? just want to sit in to see |
| 14:49 |
Krock |
18:00 UTC, which is in about 3 hours |
| 14:49 |
|
ZenonSeth joined #luanti-dev |
| 14:50 |
ZenonSeth |
ok so i have time to run some errants before - thx |
| 15:20 |
|
YuGiOhJCJ joined #luanti-dev |
| 17:45 |
Krock |
Meeting in 15 minutes --> meeting points: https://docs.luanti.org/for-engine-devs/meetings/#2026-08-02 |
| 17:45 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/2026 -- Fix endian.h include for FreeBSD by AMDmi3 |
| 17:45 |
Krock |
<3 ShadowBot |
| 17:45 |
ShadowBot |
04♥ Krock. |
| 17:57 |
sfan5 |
asdf |
| 17:57 |
MTDiscord |
<luatic> hi |
| 17:57 |
[MatrxMT] |
<cx384> hi |
| 17:58 |
[MatrxMT] |
<Zughy> hi |
| 17:59 |
Krock |
asdf y5nw |
| 18:00 |
Krock |
Okay so. Before going to the RC topic, the feature PRs should perhaps be discussed first |
| 18:00 |
Krock |
> Decide which feature PRs to still include in 5.17.0, including |
| 18:00 |
Krock |
#15417 |
| 18:01 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/15417 -- Visual Effects Vol. 2 by GefullteTaubenbrust2 |
| 18:01 |
Krock |
(also welcome to the meeting. I'll just play the role as a moderator for now, unless someone else would like to jump in) |
| 18:01 |
sfan5 |
I am under the impression that this PR was essentially ready (though haven't looked at it to confirm) and we need to stop leaving it lying around |
| 18:01 |
sfan5 |
so: in favor for 5.17 |
| 18:02 |
Krock |
indeed. I've neglected reviewing it... the effects do look good |
| 18:03 |
MTDiscord |
<luatic> seems ok to me, as long as the docs stay in their current state of "experimental" for now. i can try to give it a look. |
| 18:05 |
Krock |
rebase error in Client::handleCommand_SetLighting |
| 18:06 |
sfan5 |
aside from functioning the important points are server-control and no unexpected visual regressions |
| 18:07 |
MTDiscord |
<luatic> and ideally everything we aren't sure we want to commit to should be marked experimental. vignette for example would also be a candidate for that. |
| 18:07 |
sfan5 |
sure |
| 18:08 |
|
erbium joined #luanti-dev |
| 18:09 |
Krock |
I'll review it soon. Cannot promise for today. |
| 18:09 |
sfan5 |
alright, next: #17115 |
| 18:09 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/17115 -- Android: Provides read-only access to Luanti's external app data directory using DocumentsProvider by oong819 |
| 18:09 |
Krock |
but I'm also in favour of including that in 5.17.0 |
| 18:10 |
Krock |
17115 seems useful but not mergeable in the current state |
| 18:10 |
sfan5 |
some context: there's the ongoing problem that android users can't export their worlds at all. a possible solution is the ZIP export (future) *or* this, which we could possibly get in for 5.17 |
| 18:10 |
sfan5 |
I can offer to bring it to a mergeable state |
| 18:10 |
Krock |
or have both in the long-run |
| 18:11 |
MTDiscord |
<luatic> relatively simple change for what it brings, i'm in favor |
| 18:11 |
sfan5 |
(ZIP export is blocked on libzip, to be clear) |
| 18:11 |
Krock |
I'll give it a shot on Android 6 and ... 10 (I think?) if you'd like to adopt it |
| 18:12 |
sfan5 |
sure |
| 18:12 |
Krock |
so let's target that too for 5.1.70 |
| 18:12 |
Krock |
any other opinions? |
| 18:13 |
Krock |
then, next: 17326 (already merged, thus obsolete) #15451 |
| 18:13 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/15451 -- [no sq] Make Luanti buildable with ANGLE for macOS, iOS and iPhoneSimulator and runnable on iPhoneSimulator by sfence |
| 18:13 |
sfan5 |
this also seems ready except for one minor comment |
| 18:13 |
sfan5 |
however does it matter when it's merged? |
| 18:14 |
Krock |
sorry? |
| 18:14 |
sfan5 |
I mean does it make a difference whether we merge it now or after release |
| 18:15 |
Krock |
I do not think we must have this for 5.17.0 - although it would be nice to finally have better iOS compat |
| 18:15 |
Krock |
as it stands right now I'd like to see some changes before it gets merged |
| 18:16 |
Krock |
(which I already submitted. though only one (I think) might have an impact on functionality) |
| 18:17 |
sfan5 |
any other opinions? |
| 18:17 |
MTDiscord |
<luatic> it would be nice to have, but i suppose it is not strictly necessary for 5.17.0 |
| 18:18 |
Krock |
alright, thanks. Moving on to the issues --> #16896 |
| 18:18 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/16896 -- Severe rendering regression when array textures are used |
| 18:19 |
Krock |
good to see that the black box came up with an idea. needs checking whether this actually fixes anything |
| 18:20 |
MTDiscord |
<luatic> it's not really a fix yet, it's primarily a branch for diagnosis. it has a slim chance of fixing it if the issue really is as simple as "16 MB batch size is too much for some drivers". |
| 18:20 |
Krock |
so for testing it would be handy if there was an APK linked in the comment for users to test. Though they would have to sign it themselves |
| 18:22 |
Krock |
I find it strange how the vertex data is somehow corrupted.... |
| 18:22 |
Krock |
but for the time being, applying the hotfix for 5.17.0 seems to be the only solution (again). |
| 18:23 |
Krock |
any other opinions or proposals? |
| 18:23 |
MTDiscord |
<luatic> that should be the default solution if no tester for the debug branch comes up during the FF, yes |
| 18:24 |
[MatrxMT] |
<Zughy> regarding iOS compat: that's something many teachers have been requesting, so if it's possible to have it for iOS it'd be great |
| 18:24 |
Krock |
so .. build an RC without the hotfix? |
| 18:24 |
|
crazylad joined #luanti-dev |
| 18:25 |
MTDiscord |
<luatic> might be a good idea, yes |
| 18:26 |
Krock |
Zughy: indeed. I've seen such requests... years ago. Though I would like to keep the code easier to maintain by reducing code paths. |
| 18:26 |
Krock |
.. which is the general goal of my review comments there |
| 18:27 |
MTDiscord |
<luatic> adding another supported platform is great bang for the buck if it doesn't mean too much work, which hopefully is the case here |
| 18:28 |
MTDiscord |
<luatic> ANGLE builds for macOS are also a good thing, it means macOS users aren't stuck in the stone age rendering-wise anymore |
| 18:28 |
sfan5 |
I guess we'll have to pull in the hotfix for the release again if nothing comes up |
| 18:28 |
sfan5 |
[re rendering regression] |
| 18:30 |
Krock |
about iOS: I am honestly surprised that it is apparently required to deal with EGL, even though SDL should already support that. Well, it is what it is. |
| 18:32 |
Krock |
about rendering: yes. so let's do it like last time. Release Candidate without hotfix. Hopefully collect some useful information, then release with the hotfix |
| 18:33 |
Krock |
> Feature freeze and plan release date |
| 18:35 |
MTDiscord |
<luatic> August 15 & 16 will be FrOSCon where I have registered a Luanti stand, so I'd like us to avoid that. Otherwise I'm mostly indifferent. |
| 18:36 |
sfan5 |
we could target August 12 or 19 if we need to delay |
| 18:36 |
Krock |
waiting for the adopted Android PR and visual effects. Let's give it a few days. With a testing period of 1 week we'd get somewhat close to that date |
| 18:36 |
MTDiscord |
<luatic> Aug. 12/19 sounds fine to me |
| 18:37 |
Krock |
I suspect not all media will be available by Aug 15 if we were to release 3 days before. Hopefully that's not a showstopper for your stand ;) |
| 18:38 |
[MatrxMT] |
<Zughy> I'd suggest 12, so luatic can show off the new release :D |
| 18:38 |
MTDiscord |
<luatic> well for the stand i'll find a way to compile myself a recent build, that shouldn't be the problem |
| 18:39 |
MTDiscord |
<luatic> being able to show off 5.17.0 would be nice, yeah. especially if we get the new visual effects in, those never fail to get players excited 😁 |
| 18:39 |
Krock |
RC on Wednesday my dudes, release [planned] on 12, with the possibility to move it by a week depending on what sorts of delays we run into |
| 18:39 |
[MatrxMT] |
<Zughy> sure but if the public can enjoy it at home as well without having to wait 4 days it's better |
| 18:40 |
Krock |
so far so good? Any other points? |
| 18:41 |
MTDiscord |
<luatic> nothing immediately relevant to 5.17.0 |
| 18:42 |
Krock |
sure. Any idea, PR or concept to discuss? |
| 18:44 |
MTDiscord |
<luatic> for what i have in mind, it's better to wait for 5.18-dev for the discussions, certainly this meeting right now is not the place for it |
| 18:45 |
Krock |
OK. So no new topic within 3 minutes. Thank you (all) for participating. |
| 18:47 |
sfan5 |
small note: we will have to wait with updating weblate until the visual effects PR can go in |
| 18:47 |
sfan5 |
(or do it twice) |
| 18:47 |
Krock |
right before building the RC I'd say |
| 19:01 |
sfan5 |
ah we should have discussed the issues in the milestone |
| 19:01 |
sfan5 |
e.g. #17100 should probably be removed? |
| 19:02 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/17100 -- Crack overlay not visible on transparent pixels (some drawtypes) |
| 19:02 |
sfan5 |
also uh #16870 |
| 19:02 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/16870 -- Add matrix & rotation Lua APIs (2nd try) by appgurueu |
| 19:02 |
MTDiscord |
<luatic> i just figured everything that didn't get in defaults to the 5.18.0 milestone. |
| 19:09 |
Krock |
I'd prefer to have the matrix PR in 5.18.0-dev and test it there well. Also to perhaps get developer feedback on the API design |
| 19:10 |
Krock |
no feedback would be good feedback in that case |
| 19:11 |
|
Desour joined #luanti-dev |
| 19:12 |
sfan5 |
well if there are no complaints I will move the feature PRs to the next milestone |
| 19:23 |
Krock |
sure |
| 19:49 |
sfan5 |
trying to open our android project in android studio is currently a pain because our gradle is too old for android studio's java |
| 19:59 |
sfan5 |
okay great it's possible that new gradle is incompatible with our build stuff?! |
| 20:02 |
Krock |
is it just me or does the Android development environment introduce additional work at the pace where usually new JavaScript framewrorks drop? |
| 20:02 |
Krock |
as in - bumping the minimal SDK version every half year or so |
| 20:05 |
sfan5 |
yes, Google reguarly shoves busywork on its developers |
| 20:11 |
sfan5 |
thankfully chatgpt knows how to fix it without me having to read any documentation |
| 20:13 |
|
siliconsniffer joined #luanti-dev |
| 20:13 |
siliconsniffer |
You should use Gemini though, so everything stays at Google :P |
| 20:16 |
sfan5 |
>it suggests a solution |
| 20:17 |
sfan5 |
>the solution was deprecated and already removed in gradle 9 |
| 20:19 |
sfan5 |
the solution? more boilerplate |
| 20:19 |
sfan5 |
i can feel the java |
| 20:21 |
sfan5 |
why in gods name did we have to call msgfmt from gradle anyway |
| 20:44 |
sfan5 |
best part is I did not intend to work on a gradle upgrade at all. I planned to do something different |
| 22:32 |
|
panwolfram joined #luanti-dev |
| 23:50 |
|
crazylad joined #luanti-dev |
