Time |
Nick |
Message |
02:21 |
MTDiscord |
<mark.wiemer> Krock what idea? my link is to a pull request, it also has an implementation, do you disagree with the implementation? |
02:40 |
MTDiscord |
<wsor4035> i kinda hoped against reality that upstream would just merge it, but given how slow upstream seems, 🤷 |
02:46 |
MTDiscord |
<wsor4035> i see the point but also think its kinda dumb, just announce and merge it tbh |
03:11 |
MTDiscord |
<mark.wiemer> sry what's dumb? The idea or the implementation? I'm happy to change it if you see issues. We will be fighting upstream for sure, but honestly I don't see much of a need to stay tethered there too much. I'm happy to handle the merge conflicts or whatever as they come up, but I don't expect many changes from Hugo Book, there has only been one batch of commits since early October |
03:12 |
MTDiscord |
<mark.wiemer> Merging #212 in half an hour |
03:13 |
MTDiscord |
<wsor4035> theres not going to be any merge conflicts, just css cascading weird |
04:00 |
|
MTDiscord joined #luanti-docs |
04:49 |
MTDiscord |
<greenxenith> Id go as far as moving the theme in-house because I expect a lot more modifications |
17:26 |
Krock |
@mark.wiemer I like the idea of making the clickable area better. Which means that I support the PR. Eventually my answer won't bring you further, though. |