| Time |
Nick |
Message |
| 00:55 |
MTDiscord |
<wsor4035> no announcement and also missing alias |
| 00:57 |
MTDiscord |
<wsor4035> adds a pointless one as well, but thats 🤷 |
| 00:58 |
MTDiscord |
<wsor4035> going to push a change fixing the missed alias |
| 01:03 |
MTDiscord |
<wsor4035> . in other news, looking at the main site |
| 01:04 |
MTDiscord |
<wsor4035> the docs suggest using rbenv on linux, which (according to the docs) looks for a file .ruby-version which we dont have |
| 01:17 |
MTDiscord |
<wsor4035> > Ensure you have Ruby 2.4 or later installed. . > Error installing bundler: \n bundler requires Ruby version >= 3.1.0. well ok then |
| 01:22 |
MTDiscord |
<wsor4035> > Bundler 2.6.6 is running, but your lockfile was generated with 2.4.1. Installing Bundler 2.4.1 and restarting using that version. fun |
| 01:34 |
MTDiscord |
<wsor4035> so the github action has version 3.0.5, interesting |
| 01:40 |
MTDiscord |
<wsor4035> HTML-Proofer is not happy with the downloads page, interesting |
| 01:42 |
MTDiscord |
<wsor4035> not quite sure why |
| 01:49 |
MTDiscord |
<wsor4035> html     <div class="column is-one-third">      <h3 class="title is-4">Free & Open Source</h3>      <p>       <p>The Luanti Engine is <a href="/get-involved/">developed</a> by an independent community of <a href="/credits/">volunteer developers</a>. It is provided for everyone to use, modify, and redistribute freely.</p>       </p>     </div>  anyone have an idea why it might be complaining about the closing |
| 01:49 |
MTDiscord |
</p> tag? might be missing something dumb here |
| 01:53 |
MTDiscord |
<theidealist> wait you can put <p> inside of each other? I've never seen that before but I'm probably stupid |
| 01:53 |
MTDiscord |
<wsor4035> yes, you can, its stupid |
| 01:54 |
MTDiscord |
<wsor4035> this part at least is generated from markdown in yaml, called via shortcode 🙄 |
| 01:55 |
MTDiscord |
<wsor4035> given there is 18 errors about closing </p> tags, im thinking there is an bad close somewhere in the file, but not seeing it at all |
| 01:55 |
MTDiscord |
<wsor4035> the first one it complains about is the third one in the doc |
| 01:57 |
MTDiscord |
<wsor4035> whole generated file if you want a look |
| 01:57 |
MTDiscord |
<wsor4035> https://cdn.discordapp.com/attachments/926231483155378176/1355722511911747705/message.txt?ex=67e9f67a&is=67e8a4fa&hm=ba4d9708e38725d1d3c58db1069eb31f0294ea1e67788fb3d96fca3d8623278d& |
| 01:57 |
MTDiscord |
<wsor4035> see errors at https://github.com/luanti-org/luanti-org.github.io/actions/runs/14151348686/job/39644928442?pr=335 |
| 01:57 |
MTDiscord |
<wsor4035> education one was actually valid, fixed that locally |
| 01:59 |
MTDiscord |
<wsor4035> interesting, if i delete the p from inside of the p, it stop complaining about the outer one |
| 02:02 |
MTDiscord |
<theidealist> I guess maybe it doesn't like you putting <p> inside of each other? |
| 02:03 |
MTDiscord |
<wsor4035> interesting, seems ruben pinned the version of html-proofer in the gemfile, wonder what happens if i update that |
| 02:05 |
MTDiscord |
<wsor4035> `parse_cli_options': invalid option: --check-html glorius |
| 02:19 |
MTDiscord |
<wsor4035> whole new set of errors |
| 02:22 |
MTDiscord |
<wsor4035> > 'a' tag is missing a reference are we fine with me just adding data-proofer-ignore to all the links? |
| 02:25 |
MTDiscord |
<wsor4035> just one spot in nav |
| 02:28 |
MTDiscord |
<wsor4035> > External link https://matrix.to/#/%23minetest:tchncs.de failed: https://matrix.to/ exists, but the hash '/%23minetest:tchncs.de' does not (status code 200) a 200 is success, so wtf? |
| 02:31 |
MTDiscord |
<wsor4035> just ignoring that for now |
| 02:35 |
MTDiscord |
<wsor4035> ok, so when should this mess be merged 🤔 |
| 02:36 |
MTDiscord |
<wsor4035> i mean, if its a massive screw up, can always revert it |
| 02:38 |
MTDiscord |
<wsor4035> lets say merge it in ~1hr (on the half hour) |
| 03:16 |
MTDiscord |
<vejou> anchor tags need references? |
| 03:17 |
MTDiscord |
<wsor4035> an anchor semantically is supposed to be a link |
| 03:19 |
MTDiscord |
<vejou> can you not use anchors as the #section things in urls |
| 03:20 |
MTDiscord |
<vejou> is that a different tag |
| 03:20 |
MTDiscord |
<wsor4035> you can, the #thing is where #thing is an elment id on the page |
| 03:20 |
MTDiscord |
<vejou> oh so it doesnt need to be an anchor |
| 03:20 |
MTDiscord |
<vejou> why didnt they add a dedicated html hyperlink tag in like html 5 or whatever it is now |
| 03:21 |
MTDiscord |
<vejou> it doesnt need to do much different from anchor |
| 03:29 |
MTDiscord |
<fyl2xp1> Not sure if this was solved in the meantime, but <p> cannot be nested. Any opening <p> will implicitly close a previous <p>. In this case leaving too many closing </p> which I think is the error here. |
| 03:30 |
MTDiscord |
<wsor4035> it can, browsers dont care |
| 03:32 |
MTDiscord |
<wsor4035> well, to be accurate, they do there magic error handling to split it, but still works |
| 03:36 |
MTDiscord |
<fyl2xp1> Then maybe we disagree on interpretation?  html <!DOCTYPE html> <html lang="en"> <meta charset="utf-8"> <title>Title</title> <style>   div { border: 3px solid green; }   p { border: 3px solid red; } </style> <body>  <div>   outer   <div>    inner   </div>   outer  </div>   <p>   outer   <p>    inner   </p>   outer  </p>  </body> </html> |
| 03:36 |
MTDiscord |
<fyl2xp1> https://cdn.discordapp.com/attachments/926231483155378176/1355747475209719848/image.png?ex=67ea0dba&is=67e8bc3a&hm=39f1a6d6d3b69f615e2e01dd0e607421cf9a990d5db0875c334f1902a8a8b9d8& |
| 03:37 |
MTDiscord |
<fyl2xp1> DOM-view |
| 03:37 |
MTDiscord |
<fyl2xp1> https://cdn.discordapp.com/attachments/926231483155378176/1355747696232759426/image.png?ex=67ea0def&is=67e8bc6f&hm=76f81277f816618da2f38aba7f96dbe43651fea1ee8814f2a392c1b43a85d2c0& |
| 03:37 |
MTDiscord |
<wsor4035> <p><p>test</p></p> becomes <p></p><p>test</p></p> |
| 03:38 |
MTDiscord |
<fyl2xp1> Exactly. You cannot nest them. |
| 03:38 |
MTDiscord |
<wsor4035> 👆 |
| 03:39 |
MTDiscord |
<fyl2xp1> Validators don't |
| 03:40 |
MTDiscord |
<wsor4035> im not arguing this is a good thing, its the output from markdown in yml -> shortcode -> generated output, so i cant really do much about it easily |
| 03:40 |
MTDiscord |
<wsor4035> it didnt error before, and it doesnt now since i updated it, so 🤷 |
| 03:40 |
MTDiscord |
<fyl2xp1> All good. I just wanted to clarify why the validator was correct. This is invalid but Browser just deal with this sh… |
| 03:41 |
MTDiscord |
<wsor4035> tbh the sites code is kinda mess |
| 03:41 |
MTDiscord |
<fyl2xp1> blends well with the rest of the web 😉 |
| 03:42 |
MTDiscord |
<wsor4035> like its terribly formated html mostly, plus front matter at the top, with a side of shortcodes, yml, and markdown |
| 03:43 |
MTDiscord |
<fyl2xp1> Add some JavaScript, and Flash to the mix … |
| 03:43 |
MTDiscord |
<wsor4035> need ruffle for flash these days |
| 03:44 |
MTDiscord |
<wsor4035> im thinking of converting it all to hugo with nicely formatted markdown and custom template |
| 04:00 |
|
MTDiscord joined #luanti-docs |
| 06:03 |
MTDiscord |
<mark.wiemer> I actually missed two aliases in my last PR, thanks for calling that out. You fixed one, here's the other: https://github.com/luanti-org/docs.luanti.org/pull/219, "Add alias for /for-engine-devs/luajit" |
| 06:03 |
MTDiscord |
<mark.wiemer> I'm in favor of that for consistency with docs.luanti.org. What does api.luanti.org use? |
| 06:09 |
MTDiscord |
<mark.wiemer> Ah, I see the site is hosted at https://github.com/luanti-org/luanti/tree/master/doc, looks like MkDocs is its own thing, I'm learning something new every day 🙂 https://www.mkdocs.org/ |
| 08:22 |
|
Warr1024 joined #luanti-docs |
| 08:47 |
|
Warr1024 joined #luanti-docs |
| 15:15 |
MTDiscord |
<wsor4035> so trival wasnt really worth the pr, but merging |
| 15:44 |
MTDiscord |
<wsor4035> merging https://github.com/luanti-org/luanti-org.github.io/pull/337 in 10 assuming robots are happy |
| 15:47 |
MTDiscord |
<wsor4035> lets make that at hour:50 |
| 15:50 |
MTDiscord |
<wsor4035> it appears jekyll supports markdown, so probably a good first step(and good regardless) to convert the pages over to markdown |
| 15:50 |
MTDiscord |
<wsor4035> have to play with that tonight perhaps |
| 20:00 |
MTDiscord |
<mark.wiemer> I always do PRs, makes the robots happy and allows for consistent way to discuss 🙂 |
| 20:05 |
MTDiscord |
<wsor4035> sure, feel free to merge then next time |
| 20:18 |
|
Desour joined #luanti-docs |
| 21:32 |
wsor4035 |
Krock: happen to be around? |
| 21:38 |
MTDiscord |
<wsor4035> nevermind |
| 22:45 |
MTDiscord |
<mark.wiemer> Yeah, I was gonna wait a bit and announce and whatnot |
