| Time |
Nick |
Message |
| 00:04 |
|
GTRsdk joined #minetest-dev |
| 01:37 |
|
SpeedProg1 joined #minetest-dev |
| 01:49 |
|
Doc22 joined #minetest-dev |
| 09:01 |
|
PilzAdam joined #minetest-dev |
| 09:31 |
|
ssstrandberg joined #minetest-dev |
| 09:58 |
|
OdnetninI joined #minetest-dev |
| 10:19 |
|
Calinou joined #minetest-dev |
| 12:26 |
|
rubenwardy joined #minetest-dev |
| 14:02 |
|
SpeedProg joined #minetest-dev |
| 15:39 |
PilzAdam |
darkrose, can you look at this: https://github.com/celeron55/minetest/pull/276 |
| 15:44 |
VanessaE |
darkrose: ignore that. something went wrong. |
| 15:46 |
darkrose |
yeah, there's a chunk missing |
| 15:53 |
VanessaE |
darkrose: https://github.com/celeron55/minetest/pull/277 |
| 15:53 |
VanessaE |
that one works. |
| 15:53 |
VanessaE |
forgot to keep the variables I added/defined in minetest/src/guiMainMenu.h |
| 15:56 |
darkrose |
https://github.com/VanessaE/minetest/commit/61f40959749013ed5c2ced20d0f09e6466a86287#L3R1439 why is it storing things in menudata when there's no ui for it? |
| 15:56 |
* PilzAdam |
is asking himself the same question |
| 15:56 |
VanessaE |
because it *was* a full patch that adds menu checkboxes. |
| 15:57 |
VanessaE |
I stripped out the gui stuff. |
| 15:57 |
PilzAdam |
it works fine with only the things in clientmap.cpp |
| 15:57 |
|
rubenwardy left #minetest-dev |
| 15:57 |
|
ssstrandberg joined #minetest-dev |
| 15:58 |
VanessaE |
PilzAdam: no, it needs the other stuff or the game will either crash or not build. |
| 15:58 |
PilzAdam |
lemme test... |
| 15:59 |
darkrose |
clientmap.cpp and defaltsettings.cpp, shouldn't need any of the ui stuff as there's no ui |
| 15:59 |
VanessaE |
See, this is why I didn |
| 15:59 |
VanessaE |
didn't want to screw around with this. |
| 16:00 |
|
ssstrandberg joined #minetest-dev |
| 16:00 |
VanessaE |
and the stuff in clientmap.cpp is needed or the settings in the config file won't do anything at all. |
| 16:01 |
darkrose |
yeah, s'what I was saying |
| 16:01 |
PilzAdam |
only the stuff in clientmyp is enough |
| 16:01 |
PilzAdam |
*clientmap |
| 16:01 |
darkrose |
and defaultsettings.cpp I'd think |
| 16:01 |
PilzAdam |
agreed |
| 16:02 |
VanessaE |
without the stuff in defaultsettings.cpp, the game will eventually crash and quite badly at that. |
| 16:02 |
darkrose |
that's why I said to include it |
| 16:02 |
VanessaE |
ok |
| 16:03 |
PilzAdam |
also where to move the mipmap thing if we delete the stuff from main? |
| 16:03 |
* darkrose |
headdesks |
| 16:04 |
darkrose |
uh... just edit the existing mipmap line at 1296 |
| 16:05 |
VanessaE |
I give up. |
| 16:05 |
VanessaE |
http://digitalaudioconcepts.com/vanessa/hobbies/minetest/video-settings-with-gui-2.patch |
| 16:05 |
VanessaE |
there's the full patch that has everything where it seems to make sense. |
| 16:05 |
VanessaE |
have fun. |
| 16:06 |
darkrose |
doesn't that put video setting on the map setting menu? |
| 16:07 |
VanessaE |
it does. PilzAdam wants me to remove the GUI options entirely. |
| 16:07 |
VanessaE |
make the game take settings only from the config, and add the GUI stuff back in later. |
| 16:08 |
PilzAdam |
add it together with other GUI things |
| 16:09 |
VanessaE |
it is my opinion that the whole patch should go in at once, or it should wait until whenever. |
| 16:10 |
darkrose |
yeah, actually I agree with that |
| 16:11 |
PilzAdam |
imo do the core code first and add the GUI stuff later all together |
| 16:13 |
darkrose |
gui is part of the core, it is a graphical game after all: it could be done without the ui code, but all that would achieve would be splitting one commit into two |
| 16:15 |
|
ssstrandberg joined #minetest-dev |
| 16:18 |
VanessaE |
if I do a git push right now, it'll restore the patch to what I had previously; merging the current pull request will add the entire thing. |
| 16:18 |
* VanessaE |
pushes. |
| 16:18 |
VanessaE |
done. |
| 16:22 |
VanessaE |
it is still in two separate commits that each achieve what pilzadam wanted, at least. |
| 16:22 |
PilzAdam |
not realy |
| 16:22 |
|
rubenwardy joined #minetest-dev |
| 16:23 |
PilzAdam |
btw: VanessaE, here is it without GUI: https://github.com/PilzAdam/minetest/commit/d3df8629e62b8dab4064efb685c6d3cc9dc9776b |
| 16:36 |
|
hmmmm joined #minetest-dev |
| 16:55 |
|
Calinou joined #minetest-dev |
| 17:21 |
|
celeron55_ joined #minetest-dev |
| 17:31 |
|
celeron55 joined #minetest-dev |
| 17:36 |
|
celeron55 joined #minetest-dev |
| 18:03 |
|
celeron55 joined #minetest-dev |
| 18:33 |
|
sstrandberg joined #minetest-dev |
| 18:34 |
|
celeron55 joined #minetest-dev |
| 19:00 |
|
celeron55 joined #minetest-dev |
| 19:10 |
|
celeron55 joined #minetest-dev |
| 19:21 |
|
SpeedProg1 joined #minetest-dev |
| 19:21 |
|
SpeedProg joined #minetest-dev |
| 19:25 |
|
celeron55 joined #minetest-dev |
| 19:52 |
|
celeron55 joined #minetest-dev |
| 20:03 |
|
SpeedProg joined #minetest-dev |
| 21:53 |
|
SpeedProg joined #minetest-dev |
| 22:05 |
|
nyuszika7h joined #minetest-dev |
