| Time |
Nick |
Message |
| 00:00 |
hmmmmm |
I'll take a look |
| 00:03 |
hmmmmm |
est31, you there? |
| 00:03 |
est31 |
yes |
| 00:03 |
est31 |
moment |
| 00:03 |
hmmmmm |
oh okay |
| 00:04 |
est31 |
not ok |
| 00:04 |
est31 |
or |
| 00:04 |
est31 |
how can one return values on the lua api? |
| 00:04 |
ShadowNinja |
hmmmmm: About the doc in your commit: Each * is a new list entry, so there shouldn't be one for the examples (eg, `colorspec = ...`). |
| 00:04 |
est31 |
regarding this line: https://github.com/kwolekr/minetest/commit/2daf65fd71555fe31b5140a77acc64261db9260f#diff-9444313da8be4290e9304a4b1faed804R1289 |
| 00:06 |
est31 |
remembered right: the return value is the number of parameters |
| 00:07 |
est31 |
so when sb checks they will get nil as result I guess# |
| 00:07 |
est31 |
instead of true... |
| 00:07 |
est31 |
acceptable |
| 00:07 |
est31 |
+1 hmmmmm, except what SN said ofc |
| 00:10 |
hmmmmm |
est31: yes, a large number of APIs are true or nil |
| 00:11 |
hmmmmm |
it's syntactically shorter and allows you to do the same "if not core.thing() then" |
| 00:11 |
est31 |
yes |
| 00:11 |
hmmmmm |
erm, syntactically shorter in c++ |
| 00:11 |
est31 |
yes |
| 00:11 |
hmmmmm |
i don't know if that's necessarily *better* |
| 00:12 |
hmmmmm |
in any case, I didn't want to change the way that function fails |
| 00:12 |
hmmmmm |
notice how it has the previous line "if (playersao == NULL) return 0;" |
| 00:12 |
est31 |
its one day old |
| 00:12 |
hmmmmm |
well there is one person using it |
| 00:12 |
hmmmmm |
(the person who added it) |
| 00:15 |
hmmmmm |
alright done |
| 00:24 |
|
Player_2 joined #minetest-dev |
| 00:57 |
|
Wayward_Tab joined #minetest-dev |
| 01:30 |
|
Taoki joined #minetest-dev |
| 01:38 |
|
paramat joined #minetest-dev |
| 01:43 |
hmmmmm |
sorta wish we could use github more like jira |
| 01:44 |
paramat |
hi hmmmmm any thoughts on #2703 ? also in case you missed it http://irc.minetest.ru/minetest-dev/2015-05-15#i_4250688 at 23:52 |
| 01:44 |
ShadowBot |
https://github.com/minetest/minetest/issues/2703 -- Mapgen v5/v7: Detect sandstone, enable sandstone brick dungeons by paramat |
| 01:44 |
hmmmmm |
hrmmm |
| 01:44 |
hmmmmm |
what is this stone_type |
| 01:45 |
hmmmmm |
generateBiomes returns an int now |
| 01:45 |
hmmmmm |
ahh |
| 01:45 |
hmmmmm |
paramat, i don't approve and here's why: |
| 01:45 |
paramat |
yeah detection of desert stone or sandstone |
| 01:45 |
hmmmmm |
stone_type = 1, stone_type = 2, etc. |
| 01:45 |
hmmmmm |
this is the beginning of an enumeration |
| 01:45 |
hmmmmm |
an enumeration for biomes is tantamount to hardcoding them |
| 01:46 |
hmmmmm |
i suppose this is okay for right now, with the caveat that it needs to be replaced later on when we get to enhancing biomes |
| 01:46 |
hmmmmm |
for now please add an enum for this, MgStoneType or something |
| 01:46 |
paramat |
ah okay |
| 01:47 |
hmmmmm |
and add a // TODO(paramat/hmmmm): make stone type selection dynamic |
| 01:48 |
paramat |
is there a better way than enumeration i can (attempt to) code right now? |
| 01:49 |
paramat |
but then perhaps i'd better just stick to an enum.. |
| 01:50 |
hmmmmm |
i don't think we can do this right now without coming up with a way to specify dungeon params in lua |
| 01:50 |
hmmmmm |
obviously what I had there in mapgen v6 was a temporary workaround |
| 01:50 |
hmmmmm |
then you copied it to the other mapgens |
| 01:50 |
paramat |
yeah. okay |
| 01:50 |
hmmmmm |
I'm gonna give mapgen some love but not right now |
| 01:50 |
hmmmmm |
i need to work on other stuff |
| 01:51 |
paramat |
also there's #2706 but i'll add in the new mgv7 noise params soon |
| 01:51 |
ShadowBot |
https://github.com/minetest/minetest/issues/2706 -- Biome API: Increase heat / humidity spreads. Mgv7: Improve terrain noise parameters by paramat |
| 01:51 |
paramat |
do it all at once |
| 01:52 |
hmmmmm |
what are you changing the terrain noise parameters to? |
| 01:52 |
hmmmmm |
i do all my testing on mapgen v7 now and honestly i think it's awesome |
| 01:52 |
hmmmmm |
it's better than how i left it, that's for sure |
| 01:52 |
paramat |
i'll gist them soon |
| 01:53 |
hmmmmm |
increasing biome spread parameters sounds like a temporary hack |
| 01:53 |
hmmmmm |
the correct solution would be to add some sort of weighting system |
| 01:53 |
hmmmmm |
we'll need to chat about that though |
| 01:53 |
paramat |
yeah |
| 01:53 |
paramat |
https://gist.github.com/paramat/c70c4c4f8bf9f8573720 |
| 01:54 |
hmmmmm |
well how does it change it, in words? |
| 01:54 |
paramat |
creates mgv6 type cliffs, higher mountains |
| 01:55 |
paramat |
and i thought terrain base is best with a x2 spread and less detail (because octaves is unchanged) |
| 01:56 |
hmmmmm |
ahh great |
| 01:56 |
paramat |
i will be increasing the mountain height a little more, to offset = 144 scale = 48 |
| 01:56 |
hmmmmm |
you were able to create mgv6 cliffs just by changing the parameters? |
| 01:56 |
paramat |
yeah by increasing scale of height select |
| 01:57 |
paramat |
now 16 |
| 01:57 |
hmmmmm |
wow |
| 01:57 |
hmmmmm |
i thought my algorithm was broken |
| 01:57 |
hmmmmm |
i tried to emulate that |
| 01:57 |
paramat |
essentially i've tried to stay as close to your original 'vision' as possible with minimal changes |
| 01:58 |
hmmmmm |
well this is not good, i think i just lost all my work on the memory optimized noise functions |
| 01:58 |
paramat |
cliffs can be steeper by using scales up to 32 |
| 01:58 |
paramat |
:( |
| 01:59 |
paramat |
but 16 gives a nice variety of cliffs steep and not so steep |
| 02:00 |
hmmmmm |
oh dammn |
| 02:00 |
hmmmmm |
it's gone |
| 02:00 |
hmmmmm |
it's not even in my stash history |
| 02:00 |
hmmmmm |
this is why you operate on separate branches |
| 02:01 |
hmmmmm |
i know exactly what i need to rewrite, it's just that now i have to retest everything |
| 02:01 |
hmmmmm |
dammit |
| 02:03 |
paramat |
ah man :.( ... so, i assume you updated serialize lua table to mts to format v4? as you can see it segfaults for me |
| 02:03 |
hmmmmm |
i've gotta check that out |
| 02:03 |
hmmmmm |
too |
| 02:05 |
paramat |
okay thanks no rush i have plenty to do |
| 02:27 |
hmmmmm |
hey paramat could you send the crashing mts file? |
| 02:29 |
paramat |
my mod in the gist segfaults before creating the file, no file appears in the schematics folder |
| 02:30 |
hmmmmm |
okay |
| 02:33 |
paramat |
and running that mod always creates warnings of 'undeclared global variable mts' |
| 02:33 |
paramat |
..harmless |
| 02:33 |
hmmmmm |
erm, that's not my bug |
| 02:41 |
hmmmmm |
ermm there's something super wrong with mapgen v7 |
| 02:41 |
hmmmmm |
what the hell |
| 02:42 |
paramat |
? |
| 02:59 |
hmmmmm |
my unsigned noise fix messed up mapgen v6. |
| 02:59 |
hmmmmm |
v7 |
| 03:00 |
hmmmmm |
oddly enough the unit tests still pass |
| 03:02 |
paramat |
aha |
| 03:03 |
hmmmmm |
pfth |
| 03:03 |
hmmmmm |
dopey me |
| 03:07 |
hmmmmm |
how do i design my unit tests to make sure this doesn't happen again |
| 03:07 |
hmmmmm |
hmm |
| 03:17 |
paramat |
okay #2703 is updated to use an enum and tested, will push later, bbl |
| 03:17 |
ShadowBot |
https://github.com/minetest/minetest/issues/2703 -- Mapgen v5/v7: Detect sandstone, enable sandstone brick dungeons by paramat |
| 03:17 |
|
paramat left #minetest-dev |
| 03:18 |
|
chchjesus joined #minetest-dev |
| 03:19 |
|
chchjesus joined #minetest-dev |
| 03:32 |
|
OldCoder joined #minetest-dev |
| 03:37 |
|
Wayward_Tab joined #minetest-dev |
| 03:38 |
|
FR^4 joined #minetest-dev |
| 03:41 |
|
chchjesus joined #minetest-dev |
| 03:43 |
|
FR^4 joined #minetest-dev |
| 03:50 |
hmmmmm |
hey paramat, I can't reproduce that crash |
| 03:53 |
|
FR^4 joined #minetest-dev |
| 04:04 |
|
FR^4 joined #minetest-dev |
| 04:20 |
|
paramat joined #minetest-dev |
| 04:21 |
paramat |
i forgot the comment, will do that now |
| 04:22 |
paramat |
ah the crash, thanks for trying |
| 04:43 |
paramat |
ooh buffer stuff |
| 04:59 |
paramat |
#2703 passed checks, will push very soon |
| 04:59 |
ShadowBot |
https://github.com/minetest/minetest/issues/2703 -- Mapgen v5/v7: Detect sandstone, enable sandstone brick dungeons by paramat |
| 05:00 |
paramat |
^ hmmmmm |
| 05:00 |
hmmmmm |
looks good |
| 05:01 |
hmmmmm |
oh i like how you added the todo comment almost verbatim, except you swapped the order of names in the todo ownership bit |
| 05:01 |
hmmmmm |
lol |
| 05:01 |
hmmmmm |
"this is mostly hmmmm's job" |
| 05:02 |
paramat |
lol |
| 05:03 |
paramat |
i didn't want to put my name first (honest) |
| 05:03 |
paramat |
ok pushing now |
| 05:15 |
paramat |
done *flushes* |
| 05:20 |
|
Zeno` joined #minetest-dev |
| 05:24 |
hmmmmm |
ewww :( |
| 05:24 |
hmmmmm |
i have a situation where type traits would really help me out here if i made this a templated function |
| 05:25 |
hmmmmm |
http://fpaste.org/222663/40297143/ |
| 05:36 |
|
paramat left #minetest-dev |
| 05:39 |
|
nore joined #minetest-dev |
| 05:54 |
|
Etzos joined #minetest-dev |
| 06:12 |
|
est31 joined #minetest-dev |
| 06:17 |
|
Pilcrow joined #minetest-dev |
| 06:17 |
|
Pilcrow left #minetest-dev |
| 06:21 |
|
RealBadAngel joined #minetest-dev |
| 06:25 |
|
jin_xi joined #minetest-dev |
| 06:54 |
est31 |
Comments to #2708 ? |
| 06:54 |
ShadowBot |
https://github.com/minetest/minetest/issues/2708 -- Android: remove broken alignment from Makefile by est31 |
| 06:57 |
|
Hunterz joined #minetest-dev |
| 07:01 |
hmmmmm |
for what it's worth, it's only broken when tabs aren't set to 4 spaces |
| 07:02 |
hmmmmm |
and the alternative is having all the backslashes right against the end of the line which is seriously ugly |
| 07:04 |
est31 |
github displays this alignment broken for me: https://github.com/minetest/minetest/pull/2708/files#diff-f38370481954d389961343997a8eb9b5L216 |
| 07:06 |
hmmmmm |
https://github.com/minetest/minetest/pull/2708/files?ts=4#diff-f38370481954d389961343997a8eb9b5L216 |
| 07:06 |
hmmmmm |
looks pretty lined up to me |
| 07:09 |
|
Krock joined #minetest-dev |
| 07:09 |
est31 |
http://pasteboard.co/wvCeQip.png |
| 07:09 |
est31 |
thats what it does for me |
| 07:10 |
hmmmmm |
well if you click this link https://github.com/minetest/minetest/pull/2708/files?ts=4#diff-f38370481954d389961343997a8eb9b5L216 i think it'll be aligned to your satisfaction |
| 07:11 |
est31 |
lol magic trick |
| 07:11 |
est31 |
ts=4 |
| 07:38 |
|
kilbith joined #minetest-dev |
| 07:54 |
|
cib0 joined #minetest-dev |
| 07:55 |
|
Calinou joined #minetest-dev |
| 08:00 |
|
Yepoleb_ joined #minetest-dev |
| 08:04 |
hmmmmm |
phew |
| 08:04 |
hmmmmm |
https://github.com/minetest/minetest/commit/4c9a8a91c4988b3567a38af622a3eb0d0ec19f6b |
| 08:04 |
hmmmmm |
i'm going to make a forum post about this |
| 08:05 |
hmmmmm |
i realize the documentation isn't 100% descriptive |
| 08:18 |
|
est31 joined #minetest-dev |
| 08:19 |
est31 |
hmmmmm, if you have time, can you write up what you plan for client scripting? |
| 08:46 |
|
OldCoder joined #minetest-dev |
| 09:02 |
|
Calinou joined #minetest-dev |
| 09:27 |
|
Megaf_ joined #minetest-dev |
| 10:34 |
|
TeTpaAka joined #minetest-dev |
| 11:08 |
|
est31 joined #minetest-dev |
| 13:11 |
|
neoascetic joined #minetest-dev |
| 13:22 |
|
ElectronLibre joined #minetest-dev |
| 13:25 |
|
Zeno` joined #minetest-dev |
| 13:36 |
|
cib0 joined #minetest-dev |
| 13:47 |
|
Megaf joined #minetest-dev |
| 14:12 |
|
hmmmm joined #minetest-dev |
| 15:14 |
|
Tripwire joined #minetest-dev |
| 15:14 |
|
rubenwardy joined #minetest-dev |
| 15:18 |
|
selat joined #minetest-dev |
| 15:20 |
rubenwardy |
Wasn't there a PR for this: https://forum.minetest.net/viewtopic.php?f=5&t=12171 |
| 15:20 |
|
srifqi joined #minetest-dev |
| 15:24 |
est31 |
btw rubenwardy what happened of your texture PR? |
| 15:25 |
est31 |
would be nice to have it ;) |
| 15:25 |
rubenwardy |
Real life. I can work on it now |
| 15:33 |
rubenwardy |
Where would the best place to document texture overriding be. lua_api.txt or texture_overrides.txt? |
| 15:37 |
|
cib0 joined #minetest-dev |
| 15:37 |
est31 |
better having files split up |
| 15:40 |
|
srifqi joined #minetest-dev |
| 15:49 |
rubenwardy |
> Added code to allow server side texture overrides |
| 15:49 |
rubenwardy |
> Tested it |
| 15:49 |
rubenwardy |
> Nothing happened |
| 15:49 |
rubenwardy |
> After ten minutes, realise texture pack isn't enabled |
| 15:51 |
Calinou |
we already have server-side texture pack? |
| 15:51 |
rubenwardy |
server side texture overrides |
| 15:52 |
rubenwardy |
#2575 |
| 15:52 |
ShadowBot |
https://github.com/minetest/minetest/issues/2575 -- Add texture overriding by rubenwardy |
| 15:53 |
est31 |
its server side ?! |
| 15:53 |
est31 |
then why do it lol |
| 15:53 |
est31 |
I've thought it would be clientside |
| 15:53 |
est31 |
or is it both |
| 15:54 |
rubenwardy |
It is both |
| 15:54 |
est31 |
nice |
| 15:56 |
rubenwardy |
Would it be useful to add support for world/worldname/overrides.txt, or not worth it? |
| 16:03 |
rubenwardy |
Damn |
| 16:03 |
rubenwardy |
I've made merge conflicts :( |
| 16:05 |
rubenwardy |
I've removed the changes on files which have been updated in upstream, so now it says it can be automatically merged, how can I include the changes from upstream? |
| 16:05 |
rubenwardy |
So I can readd the changes |
| 16:08 |
rubenwardy |
git pull --rebase? |
| 16:10 |
rubenwardy |
done |
| 16:14 |
|
srifqi joined #minetest-dev |
| 16:14 |
|
ElectronLibre left #minetest-dev |
| 16:15 |
|
cib0 joined #minetest-dev |
| 16:16 |
hmmmm |
https://forum.minetest.net/viewtopic.php?f=47&t=12178 |
| 16:17 |
hmmmm |
@paramat |
| 16:19 |
|
gravgun joined #minetest-dev |
| 16:22 |
rubenwardy |
Done #2575 |
| 16:22 |
ShadowBot |
https://github.com/minetest/minetest/issues/2575 -- Add texture overriding by rubenwardy |
| 16:25 |
Zeno` |
noise:calc3dMap_flat should probably be noise:calc_3D_map_flat |
| 16:25 |
Zeno` |
heh |
| 16:26 |
Zeno` |
plus there are one too many 'm' characters in the signature to your post |
| 16:27 |
rubenwardy |
Can a core dev remove WIP from #2575? |
| 16:27 |
ShadowBot |
https://github.com/minetest/minetest/issues/2575 -- Add texture overriding by rubenwardy |
| 16:27 |
rubenwardy |
Please :P |
| 16:29 |
nore |
rubenwardy: done |
| 16:29 |
rubenwardy |
Thanks |
| 16:31 |
|
gravgun joined #minetest-dev |
| 16:37 |
|
Dartmouth joined #minetest-dev |
| 17:14 |
|
Lunatrius joined #minetest-dev |
| 17:17 |
|
est31 joined #minetest-dev |
| 17:20 |
|
blaze joined #minetest-dev |
| 17:42 |
|
Etzos joined #minetest-dev |
| 17:53 |
|
Wayward_Tab joined #minetest-dev |
| 18:06 |
|
ElectronLibre joined #minetest-dev |
| 18:14 |
|
Miner_48er joined #minetest-dev |
| 18:16 |
|
cib0 joined #minetest-dev |
| 18:28 |
|
Wayward_One joined #minetest-dev |
| 18:58 |
|
crazyR joined #minetest-dev |
| 18:58 |
|
crazyR joined #minetest-dev |
| 19:04 |
|
Wayward_One joined #minetest-dev |
| 19:32 |
|
Amaz joined #minetest-dev |
| 19:36 |
|
Tomas-47583 joined #minetest-dev |
| 19:44 |
|
Tomas-47583 left #minetest-dev |
| 19:57 |
|
leat joined #minetest-dev |
| 20:33 |
|
ElectronLibre left #minetest-dev |
| 21:13 |
|
kaeza_ joined #minetest-dev |
| 21:17 |
|
kaeza_ joined #minetest-dev |
| 21:30 |
|
OldCoder joined #minetest-dev |
| 21:40 |
|
Hunterz joined #minetest-dev |
| 22:40 |
|
Player_2 joined #minetest-dev |
| 22:46 |
RealBadAngel |
anybody alive? |
| 22:47 |
VanessaE |
no :) |
| 22:47 |
VanessaE |
we're all zombies here. |
| 22:49 |
RealBadAngel |
looks like |
| 22:49 |
RealBadAngel |
silent as in a graveyard |
| 23:16 |
OldCoder |
:-[ <- vampire |
| 23:25 |
|
guest__ joined #minetest-dev |
