| Time |
Nick |
Message |
| 00:08 |
|
paramat joined #minetest-dev |
| 00:09 |
paramat |
will merge games 1014 1019 1020 in a moment |
| 00:10 |
paramat |
now merging |
| 00:17 |
paramat |
done |
| 00:28 |
|
ssieb joined #minetest-dev |
| 00:56 |
paramat |
hmmmm #3959 is updated on your request. thanks for the review. i'd like to merge this later tonight |
| 00:56 |
ShadowBot |
https://github.com/minetest/minetest/issues/3959 -- Mapgen: Optimise cave noises and tunnel excavation by paramat |
| 00:59 |
hmmmm |
wait |
| 00:59 |
hmmmm |
https://github.com/minetest/minetest/pull/3959/files#diff-0614e0ef11aed63d542cf655af679289R792 |
| 01:00 |
hmmmm |
is this thing supposed to be after, or before you generate the 3d noise tunnels |
| 01:20 |
paramat |
after |
| 01:21 |
paramat |
it's to stop large psrand caves being generated above y = 47 |
| 01:22 |
paramat |
#3857 |
| 01:22 |
ShadowBot |
https://github.com/minetest/minetest/issues/3857 -- Mgv7 large pseudorandom caves bright at chunk borders when above water level |
| 01:45 |
hmmmm |
okay then |
| 01:45 |
hmmmm |
i approve of it |
| 01:49 |
paramat |
thanks |
| 01:50 |
|
SmugLeaf joined #minetest-dev |
| 01:50 |
|
SmugLeaf joined #minetest-dev |
| 02:12 |
paramat |
now merging 3959 |
| 02:16 |
|
yang2003 joined #minetest-dev |
| 02:18 |
paramat |
done |
| 02:25 |
|
jin_xi joined #minetest-dev |
| 02:49 |
paramat |
closed #3761 |
| 02:49 |
ShadowBot |
https://github.com/minetest/minetest/issues/3761 -- Particles not visible through blocks which uses use_texture_alpha flag |
| 03:19 |
|
DI3HARD139 joined #minetest-dev |
| 03:27 |
|
paramat left #minetest-dev |
| 03:27 |
hmmmm |
when you close that, you need to specify that it's being closed as a duplicate, and link to the original issue |
| 05:09 |
|
Hunterz joined #minetest-dev |
| 06:00 |
|
Zeno` joined #minetest-dev |
| 07:34 |
|
nrzkt joined #minetest-dev |
| 07:59 |
hmmmm |
paramat, if you see this, i just wanted to mention that you seem overly aggressive in closing issues |
| 08:12 |
|
davisonio joined #minetest-dev |
| 08:34 |
Zeno` |
Adding controversial label to #3971 |
| 08:34 |
ShadowBot |
https://github.com/minetest/minetest/issues/3971 -- Minimap: "North" indicator arrow for circle minimap by sofar |
| 08:34 |
Zeno` |
=) Just kidding |
| 08:38 |
Zeno` |
https://store7697404.ecwid.com/#!/SIMCUBE%E2%84%A2-PC-video-game/p/58053312/category=0 |
| 08:40 |
|
Amaz joined #minetest-dev |
| 08:51 |
Zeno` |
some decision should just be made about #3971 (and the related NESW one) |
| 08:51 |
ShadowBot |
https://github.com/minetest/minetest/issues/3971 -- Minimap: "North" indicator arrow for circle minimap by sofar |
| 08:51 |
Zeno` |
the arrow is probably less controversial because its ordination can fit into anybodies internal representation |
| 08:52 |
Zeno` |
nrzkt ^^ |
| 08:52 |
nrzkt |
Zeno`, ? |
| 08:52 |
Zeno` |
oh sofar is here too... didn't see him :) |
| 08:53 |
Zeno` |
nrzkt, I'm just saying that the compass rose PR has been open for far too long (IMO) |
| 08:53 |
Zeno` |
there will never be consensus so a decision needs to be made |
| 08:59 |
nrzkt |
i like the arrow |
| 09:00 |
nrzkt |
arrow is language neutral |
| 09:00 |
Zeno` |
yes |
| 09:45 |
|
Gael-de-Sailly joined #minetest-dev |
| 10:13 |
|
iangp joined #minetest-dev |
| 10:38 |
|
Calinou joined #minetest-dev |
| 11:38 |
|
turtleman joined #minetest-dev |
| 11:38 |
|
troller joined #minetest-dev |
| 11:50 |
|
technics joined #minetest-dev |
| 11:53 |
|
nrzkt joined #minetest-dev |
| 12:17 |
|
troller joined #minetest-dev |
| 12:21 |
|
STHGOM joined #minetest-dev |
| 12:37 |
|
Obani joined #minetest-dev |
| 12:42 |
|
Robby joined #minetest-dev |
| 12:51 |
|
rubenwardy joined #minetest-dev |
| 13:19 |
|
kaadmy joined #minetest-dev |
| 13:40 |
|
Zeno`` joined #minetest-dev |
| 14:28 |
|
Hunterz joined #minetest-dev |
| 14:37 |
|
Zeno` joined #minetest-dev |
| 15:10 |
|
STHGOM joined #minetest-dev |
| 15:27 |
|
davisonio joined #minetest-dev |
| 15:34 |
|
davisoni_ joined #minetest-dev |
| 15:38 |
|
Fixer joined #minetest-dev |
| 15:54 |
|
misprint joined #minetest-dev |
| 15:58 |
|
Dragonop joined #minetest-dev |
| 16:07 |
|
rubenwardy joined #minetest-dev |
| 16:10 |
|
foghrye4 joined #minetest-dev |
| 16:12 |
|
Calinou joined #minetest-dev |
| 16:26 |
|
hmmmm joined #minetest-dev |
| 16:38 |
|
nrzkt joined #minetest-dev |
| 16:45 |
|
damiel joined #minetest-dev |
| 16:54 |
|
troller joined #minetest-dev |
| 16:56 |
|
Krock joined #minetest-dev |
| 17:11 |
|
Fixer_ joined #minetest-dev |
| 17:31 |
|
davisonio joined #minetest-dev |
| 17:33 |
|
davisonio joined #minetest-dev |
| 17:36 |
|
ssieb joined #minetest-dev |
| 18:31 |
|
Amaz joined #minetest-dev |
| 18:48 |
Obani |
https://github.com/minetest/minetest/pull/3971 |
| 18:48 |
Obani |
Never saw so much :+1: |
| 19:27 |
sofar |
Fixer: haha |
| 19:28 |
kaadmy |
lol |
| 19:35 |
Krock |
Obani, one more from my side |
| 19:38 |
kaadmy |
i +1'd it just because ;) |
| 19:38 |
kaadmy |
i like the idea anyway |
| 19:39 |
sofar |
so all we need now is for celeron55 to come in and object to it |
| 19:39 |
sofar |
that'd be a good laugh |
| 19:40 |
kaadmy |
:] |
| 19:44 |
|
cat5e joined #minetest-dev |
| 19:49 |
nrzkt |
sofar, merging |
| 19:51 |
sofar |
party pooper |
| 19:51 |
sofar |
;) |
| 19:51 |
kaadmy |
:} |
| 19:51 |
nrzkt |
sofar, for #3961 i would see another improvement for it |
| 19:51 |
ShadowBot |
https://github.com/minetest/minetest/issues/3961 -- damage_per_second: Clean up and Increase damage box by sofar |
| 19:51 |
nrzkt |
i have modified a little bit my version as i said in comment on the PR to avoid some cheat. |
| 19:52 |
nrzkt |
i think because you are modifying this part you should do as i said to reduce cheat by moving this code to server |
| 19:52 |
sofar |
yeah that's probably better |
| 19:52 |
nrzkt |
not the whole damage code atm but this part could be better. There are no huge calculs the overhead could be ignored :) |
| 19:52 |
sofar |
separate commit though, but it can be the same PR |
| 19:53 |
nrzkt |
do it in the same PR please |
| 19:53 |
sofar |
yes, same PR but move the code in a second commit |
| 19:53 |
nrzkt |
i don't see interest for this to be in a separate pr (except increase your stats :p) but as you want |
| 19:53 |
sofar |
that way the two changes can be tested separately |
| 19:53 |
sofar |
lol no, commit != pr |
| 19:54 |
sofar |
you can have 100 commits in one PR |
| 19:54 |
nrzkt |
except we generally ask for a rebase + squash :p |
| 19:54 |
sofar |
that makes sense for a lot of changes, but in this case you have a nicely testable change that is "complete" and then another one that is also "complete" |
| 19:55 |
sofar |
and you can test it in 2 steps, instead of one |
| 19:55 |
|
kaeza joined #minetest-dev |
| 19:55 |
sofar |
so it's beneficial to make 2 commits to help bisects |
| 19:55 |
nrzkt |
yeah i know :) |
| 19:55 |
sofar |
bien |
| 19:56 |
nrzkt |
french ? :o |
| 19:56 |
sofar |
would you prefer dutch? |
| 19:56 |
nrzkt |
i'm french and i didn't like the dutch gramar :p |
| 19:56 |
nrzkt |
(sorry sfan5, est31 and others :p) |
| 19:57 |
sfan5 |
huh |
| 19:57 |
sofar |
dutch don't even like dutch grammar ;) |
| 19:57 |
sfan5 |
dutch is not german |
| 19:57 |
sofar |
selbstverstandlich |
| 19:57 |
* sfan5 |
gives sofar an ä |
| 19:57 |
sofar |
selbstverstaendlich |
| 19:58 |
sfan5 |
no |
| 19:58 |
|
diemartin joined #minetest-dev |
| 19:58 |
sofar |
hasst du ein problem damit? :) |
| 19:58 |
diemartin |
>bien <-- or spanish |
| 19:58 |
sofar |
bueno? |
| 19:58 |
diemartin |
that's "good" |
| 19:59 |
diemartin |
oh well, english sucks |
| 19:59 |
sofar |
diemartin: agreed |
| 20:00 |
sfan5 |
let's speak latin |
| 20:01 |
sofar |
De bello gallico |
| 20:02 |
sofar |
was the only book I've ever read entirely in Latin |
| 20:02 |
sofar |
needless to say, after reading it, I did not have the interest in reading more Latin |
| 20:09 |
|
davisonio joined #minetest-dev |
| 20:10 |
rubenwardy |
When using minetest.delete_area, dropped entities remain. Anyway to get around? |
| 20:11 |
|
diemartin joined #minetest-dev |
| 20:11 |
sofar |
nrzkt: what happens if old clients connect to new servers where the server does the lava dmg? |
| 20:13 |
nrzkt |
i think there is a double damage ? |
| 20:13 |
sofar |
ok, just wanted to be clear on that :) |
| 20:14 |
nrzkt |
maybe add a check, on the damage packet handler. There are two other damages causes: fall + drown |
| 20:15 |
nrzkt |
drown could be tested easily by packet handler |
| 20:15 |
nrzkt |
fall is difficult |
| 20:15 |
sofar |
can I be brutally honest and say that if you want this code to be moved, we should move all of the movable damage ? |
| 20:15 |
nrzkt |
i think it's a better idea yes |
| 20:15 |
sofar |
which means it's a separate PR |
| 20:15 |
nrzkt |
but maybe we should wait for next release to do it |
| 20:15 |
nrzkt |
yes ofc |
| 20:16 |
sofar |
ok |
| 20:16 |
nrzkt |
it's a little sensible code which could have side effects as i remember |
| 20:16 |
sofar |
moving it may solve issues, or not, and I'm not too familiar in ::step code |
| 20:16 |
sofar |
(this PR was fairly trivial anyway) |
| 20:16 |
nrzkt |
it's just the run loop |
| 20:17 |
nrzkt |
on client clientenv does localplayer things. On server each playersao could do itself the thing |
| 20:17 |
sofar |
sure, yes, but I've come to realize after some of my PR's that I really haven't mastered many of the design and implementation concepts just yet ;) |
| 20:23 |
sofar |
nrzkt: can you close #3730? |
| 20:23 |
ShadowBot |
https://github.com/minetest/minetest/issues/3730 -- Minimap: Add NESW to round overlay by RealBadAngel |
| 20:23 |
nrzkt |
done |
| 20:49 |
|
DFeniks joined #minetest-dev |
| 21:51 |
|
proller joined #minetest-dev |
| 21:56 |
|
rand_user joined #minetest-dev |
| 22:00 |
|
davisonio joined #minetest-dev |
| 22:05 |
hmmmm |
we're at 2,000 closed pull requests! |
| 22:38 |
|
proller joined #minetest-dev |
| 22:50 |
|
iangp joined #minetest-dev |
| 23:11 |
|
rand_user joined #minetest-dev |
| 23:40 |
|
Ritchie joined #minetest-dev |
