| Time |
Nick |
Message |
| 00:09 |
|
thePalindrome joined #minetest-dev |
| 00:35 |
|
Void7 joined #minetest-dev |
| 01:15 |
Wayward_One |
I know it's a long shot, but I currently have a server experiencing #4151, in case anyone has something for me to try, test, look at, etc. I have not applied the patch yet. |
| 01:15 |
ShadowBot |
https://github.com/minetest/minetest/issues/4151 -- Stall Glitch |
| 02:10 |
|
pozzoni joined #minetest-dev |
| 02:15 |
Wayward_One |
Disregard, had to kill it |
| 02:26 |
|
Void7 joined #minetest-dev |
| 04:01 |
|
ssieb joined #minetest-dev |
| 04:13 |
|
torgdor joined #minetest-dev |
| 04:48 |
|
Zeno` joined #minetest-dev |
| 05:11 |
|
Hunterz joined #minetest-dev |
| 05:26 |
|
ssieb joined #minetest-dev |
| 06:04 |
|
Puka joined #minetest-dev |
| 06:40 |
|
jin_xi joined #minetest-dev |
| 06:44 |
|
nrzkt joined #minetest-dev |
| 06:45 |
nore |
can someone review #4077 again please? |
| 06:45 |
ShadowBot |
https://github.com/minetest/minetest/issues/4077 -- Colored chat and other strings by Ekdohibs |
| 06:49 |
Zeno` |
lgtm. Memory leak fixed, tested with and without luajit (because I recall an issue without it a while ago?) +1 |
| 06:59 |
adfdfgsdf |
well |
| 06:59 |
adfdfgsdf |
i wish you'd remove the commented out code pieces and separate the move of guiChatConsole to client/ out |
| 07:00 |
adfdfgsdf |
also isn't irrlicht_modifications a little bit too long?? doesn't irrlicht_mods work? |
| 07:00 |
nore |
maybe |
| 07:01 |
nore |
is its length really a problem though? |
| 07:02 |
adfdfgsdf |
it won't cause any problems, but it certainly isn't pleasant to deal with or look at |
| 07:10 |
Zeno` |
commented out code? |
| 07:46 |
|
yang2003 joined #minetest-dev |
| 09:21 |
|
Megaf joined #minetest-dev |
| 09:24 |
|
Megaf joined #minetest-dev |
| 09:33 |
|
Player_2 joined #minetest-dev |
| 09:56 |
|
Fixer joined #minetest-dev |
| 10:54 |
|
est31 joined #minetest-dev |
| 11:38 |
|
proller joined #minetest-dev |
| 11:43 |
|
Megaf joined #minetest-dev |
| 12:05 |
|
proller joined #minetest-dev |
| 12:07 |
|
damiel joined #minetest-dev |
| 12:07 |
|
Samson1 joined #minetest-dev |
| 12:24 |
|
blaze joined #minetest-dev |
| 12:39 |
|
paramat joined #minetest-dev |
| 12:41 |
paramat |
4077: nore as long as you address hmmmm's comments i think we should merge it very soon as in later today, unit tests can be added later |
| 12:49 |
|
YuGiOhJCJ joined #minetest-dev |
| 12:49 |
|
YuGiOhJCJ joined #minetest-dev |
| 12:51 |
|
Thomas-S joined #minetest-dev |
| 13:10 |
paramat |
any comments on #4163 ? code is simple, more interested in comments on how it looks |
| 13:10 |
ShadowBot |
https://github.com/minetest/minetest/issues/4163 -- Sky: Darker, bluer sky and improved horizon haze at night by paramat |
| 13:32 |
|
DFeniks joined #minetest-dev |
| 13:35 |
nore |
paramat: except for the unit tests, hmmmm's comments are addressed I think |
| 13:40 |
Zeno` |
paramat, nore, +1 for merging if all but the unit tests are addressed. The unit tests would be for something pre-existing anyway (afaics) |
| 13:45 |
|
DFeniks joined #minetest-dev |
| 13:49 |
|
Hunterz joined #minetest-dev |
| 13:49 |
|
Void7 joined #minetest-dev |
| 13:52 |
paramat |
game#1115 is good |
| 13:52 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/1115 -- Farming: allow LBM's for other mods as well. by sofar |
| 13:53 |
paramat |
+1 |
| 13:58 |
paramat |
game#1120 is also good |
| 13:58 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/1120 -- Mossy cobble slab and stairs. by sofar |
| 14:03 |
paramat |
MTGame devs please could you review game#1076 ? |
| 14:03 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/1076 -- Fire: Ignite tnt, gunpowder, permanent flame above coalblock by paramat |
| 14:16 |
|
STHGOM joined #minetest-dev |
| 14:25 |
|
Zeno` joined #minetest-dev |
| 14:43 |
|
KaadmY joined #minetest-dev |
| 14:48 |
|
est31 joined #minetest-dev |
| 15:26 |
nore |
should I close #4178? |
| 15:26 |
ShadowBot |
https://github.com/minetest/minetest/issues/4178 -- Stable 0.4 by xieziyi |
| 15:32 |
est31 |
yes |
| 15:36 |
nore |
paramat: Zeno`: can I merge #4077 now? |
| 15:36 |
ShadowBot |
https://github.com/minetest/minetest/issues/4077 -- Colored chat and other strings by Ekdohibs |
| 15:37 |
|
Hunterz joined #minetest-dev |
| 15:38 |
paramat |
i can't officially +1 but i say go ahead if hmmmm's issues are addressed, unit tests can be added later. you have zeno's +1 |
| 15:39 |
Zeno` |
it's ok with me |
| 15:39 |
nore |
ok, merging then |
| 15:39 |
Zeno` |
I also think the unit tests can be added later for the pre-existing stuff that was merely templated |
| 15:44 |
|
hmmmm joined #minetest-dev |
| 15:47 |
Wayward_One |
...umm |
| 15:47 |
Wayward_One |
What the heck: #4178 |
| 15:47 |
ShadowBot |
https://github.com/minetest/minetest/issues/4178 -- Stable 0.4 by xieziyi |
| 15:47 |
nore |
Wayward_One: same question |
| 15:47 |
nore |
was going to close it |
| 15:47 |
Wayward_One |
Lol |
| 15:48 |
nore |
closed :) |
| 15:53 |
|
Warr1024 joined #minetest-dev |
| 15:57 |
|
Warr1024 joined #minetest-dev |
| 16:29 |
|
nrzkt joined #minetest-dev |
| 16:37 |
|
DI3HARD139 joined #minetest-dev |
| 16:41 |
|
RichardTheTurd joined #minetest-dev |
| 16:51 |
|
Taoki joined #minetest-dev |
| 16:55 |
|
lisac joined #minetest-dev |
| 17:06 |
|
Darcidride joined #minetest-dev |
| 17:30 |
|
Krock joined #minetest-dev |
| 17:43 |
|
DI3HARD139 joined #minetest-dev |
| 18:06 |
|
bugzapper joined #minetest-dev |
| 18:06 |
|
Void7 joined #minetest-dev |
| 18:20 |
|
Grandolf joined #minetest-dev |
| 18:20 |
|
halt_ joined #minetest-dev |
| 18:20 |
|
halt_ left #minetest-dev |
| 18:30 |
|
VargaD_ joined #minetest-dev |
| 18:41 |
|
est31 joined #minetest-dev |
| 18:58 |
|
lisac joined #minetest-dev |
| 19:20 |
|
Void7 joined #minetest-dev |
| 19:20 |
|
Void7_ joined #minetest-dev |
| 19:48 |
Fixer |
!seen gregorycu |
| 19:48 |
ShadowBot |
Fixer: I saw gregorycu in #minetest-dev 1 week, 2 days, 4 hours, 24 minutes, and 7 seconds ago saying "This is a job for tomorrow" |
| 19:48 |
Fixer |
okay |
| 19:59 |
|
electrodude512 joined #minetest-dev |
| 20:12 |
|
DI3HARD139 joined #minetest-dev |
| 20:23 |
|
paramat joined #minetest-dev |
| 21:00 |
|
electrodude512 joined #minetest-dev |
| 21:09 |
paramat |
nore sfan5 can anyone review game#1076 ? |
| 21:09 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/1076 -- Fire: Ignite tnt, gunpowder, permanent flame above coalblock by paramat |
| 21:10 |
|
Void7 joined #minetest-dev |
| 21:12 |
|
troller joined #minetest-dev |
| 21:19 |
|
johnnyjoy joined #minetest-dev |
| 21:26 |
|
rubenwardy joined #minetest-dev |
| 21:50 |
|
Taoki joined #minetest-dev |
| 22:11 |
|
DI3HARD139 joined #minetest-dev |