| Time |
Nick |
Message |
| 00:13 |
rubenwardy |
most code concepts sound strange when converted to real life analogies |
| 00:14 |
rubenwardy |
how do you expect nyancats to be enabled by default in MTG? |
| 00:14 |
rubenwardy |
`nyancat` depends on the default mod to 1. get node sounds 2. register a variable in the default global table |
| 00:14 |
rubenwardy |
therefore default cannot depend on nyancat to deactivate it |
| 00:17 |
rubenwardy |
actually, default could do if mt.get_modpath("nc") then mt.r_generated(func(...) nc.generate(...) end end |
| 00:17 |
rubenwardy |
but a mod would still need to disable nyancats |
| 00:17 |
rubenwardy |
say a custom lua mapgen doesn't want cats, they'd have to disable them |
| 00:18 |
rubenwardy |
if a subgame doesn't want cats, then they won't include the mod |
| 00:19 |
rubenwardy |
I'd argue that the nyancat mod's purpose is to provide random cats around the map as a rare treasure. It's separate to mapgen, I don't see why a mapgen mod would want to disable them, expect for replacing the algorithm that generates them |
| 00:21 |
paramat |
mostly nyancats are wanted, in either core mapgens or custom ones |
| 00:21 |
rubenwardy |
note that the PR is the same as the existing code |
| 00:22 |
rubenwardy |
you still have to override default.generate_nyancats to disable them |
| 00:22 |
rubenwardy |
as singlenode may be set after the default mod |
| 00:24 |
paramat |
it may seem a little messy but i still +1 the PR. i'd like this to be done if you're happy with it https://github.com/minetest/minetest_game/pull/1190#discussion_r70999779 |
| 00:28 |
paramat |
the PR is simple, and no-one has yet come up with a better solution :] |
| 01:06 |
|
ssieb joined #minetest-dev |
| 01:19 |
|
Miner_48er joined #minetest-dev |
| 01:26 |
|
Tmanyo joined #minetest-dev |
| 02:13 |
|
est31 joined #minetest-dev |
| 02:59 |
|
Void7 joined #minetest-dev |
| 03:16 |
|
BrandonReese joined #minetest-dev |
| 04:00 |
|
paramat joined #minetest-dev |
| 04:36 |
|
Erebus_ joined #minetest-dev |
| 04:36 |
|
SloanOnLinux joined #minetest-dev |
| 04:58 |
|
paramat left #minetest-dev |
| 05:46 |
|
Grand joined #minetest-dev |
| 05:51 |
|
burli joined #minetest-dev |
| 05:51 |
|
Grandolf joined #minetest-dev |
| 06:46 |
|
Erebus_ joined #minetest-dev |
| 07:05 |
|
Hunterz joined #minetest-dev |
| 07:50 |
|
T4im joined #minetest-dev |
| 08:51 |
|
Fritigern joined #minetest-dev |
| 08:53 |
|
Krock joined #minetest-dev |
| 08:54 |
|
Fritigern joined #minetest-dev |
| 09:14 |
|
Megaf joined #minetest-dev |
| 10:04 |
|
est31 joined #minetest-dev |
| 10:07 |
|
SloanOnLinux joined #minetest-dev |
| 10:08 |
|
davisonio joined #minetest-dev |
| 10:18 |
|
mmmm joined #minetest-dev |
| 10:38 |
|
Zeno` joined #minetest-dev |
| 11:03 |
|
Grandolf joined #minetest-dev |
| 11:10 |
|
SloanOnLinux joined #minetest-dev |
| 11:28 |
|
damiel_ joined #minetest-dev |
| 11:37 |
|
froike__ joined #minetest-dev |
| 11:57 |
|
damiel_ joined #minetest-dev |
| 12:01 |
|
edgrey joined #minetest-dev |
| 12:01 |
|
davisonio joined #minetest-dev |
| 12:02 |
|
Fixer joined #minetest-dev |
| 12:25 |
|
davisonio joined #minetest-dev |
| 12:38 |
|
nrzkt joined #minetest-dev |
| 12:47 |
Megaf |
So Minetest client still has the insane memory leak |
| 12:47 |
Megaf |
the longer it is running the more memory it will take, until the system runs out of memory and kernel kills it because OOM |
| 12:47 |
Megaf |
Here it is taking about 1 GB per hour |
| 12:47 |
Megaf |
maybe more |
| 12:48 |
Calinou |
client only? I don't care, I have 32 GB of RAM |
| 12:48 |
Calinou |
thus, I can run Minetest for 32 hours continuously |
| 12:48 |
* Calinou |
runs |
| 12:50 |
Megaf |
Oo |
| 12:50 |
Fixer |
Calinou: 24 GB of RAM is enough for everybody, this way it will be killed by OOM roughly once a day |
| 12:50 |
Megaf |
I have 4 GB of Ram, chrome takes 2 GB and Minetest takes the other two |
| 12:50 |
Megaf |
the Linux kernel resides on swap, lol |
| 12:51 |
Fixer |
I have no idea why your chrome eats so much memory, my firefox goes rarely above 1gig |
| 12:51 |
Megaf |
Firefox is much more efficient now a days ;) |
| 12:51 |
Megaf |
anyway, problem here is Minetest |
| 12:52 |
Fixer |
Megaf: file a bug report? |
| 12:52 |
|
rubenwardy joined #minetest-dev |
| 12:53 |
Megaf |
maybe, but this is know already... It's been discussed for years |
| 12:54 |
Fixer |
Megaf: devs need more details, what mods, versions, configs, OS, blabla |
| 12:56 |
Fixer |
Megaf: or try running some analytical tools that measure such leaks |
| 12:56 |
|
STHGOM joined #minetest-dev |
| 13:03 |
|
Thomas-S joined #minetest-dev |
| 13:53 |
|
ElectronLibre joined #minetest-dev |
| 13:58 |
|
Taoki[mobile] joined #minetest-dev |
| 14:03 |
|
Megaf joined #minetest-dev |
| 14:10 |
|
Megaf_ joined #minetest-dev |
| 14:11 |
|
davisonio joined #minetest-dev |
| 14:12 |
|
ElectronLibre joined #minetest-dev |
| 14:23 |
|
davisonio joined #minetest-dev |
| 14:43 |
|
sloanonhexchat joined #minetest-dev |
| 15:10 |
|
SloanOnLinux joined #minetest-dev |
| 15:13 |
|
Void7 joined #minetest-dev |
| 15:16 |
|
whitephoenix joined #minetest-dev |
| 15:57 |
|
rocky1138 joined #minetest-dev |
| 15:58 |
|
rocky1138 joined #minetest-dev |
| 16:07 |
|
mmmm joined #minetest-dev |
| 16:13 |
|
KaadmY joined #minetest-dev |
| 16:13 |
|
Fixer_ joined #minetest-dev |
| 16:17 |
|
paramat joined #minetest-dev |
| 16:22 |
paramat |
~tell Megaf it's not a memory leak, the client uses up to 2GB for meshes, the limit can be controlled with 'client_mapblock_limit = 5000'. a mod with heavy use of noise can also use a lot of memory |
| 16:22 |
ShadowBot |
paramat: O.K. |
| 16:22 |
paramat |
hopefully if you reduce that limit your memory use should level off at a lower amount |
| 16:23 |
|
Fixer joined #minetest-dev |
| 16:24 |
paramat |
(this is my guess anyway) |
| 16:32 |
paramat |
nore sofar sfan5 Tesseract any comments on game#1190 ? |
| 16:32 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/1190 -- Move Nyancats into a separate mod by rubenwardy |
| 16:32 |
whitephoenix |
What does full_punch_interval do? I set it on a tool to 10.0 and noticed no difference. It's used in examples 3 times in lua_api.txt but never actually explained |
| 16:33 |
Calinou |
whitephoenix: attack an entity and see :) it's what determines the time to get full damage again after attacking an entity |
| 16:33 |
Calinou |
(player or mob, or anything else) |
| 16:34 |
|
AnotherBrick joined #minetest-dev |
| 16:34 |
whitephoenix |
Oh, that's cool |
| 16:35 |
whitephoenix |
should I pr a short description to lua_api? |
| 16:35 |
paramat |
yes if description is unclear |
| 16:37 |
|
edgrey joined #minetest-dev |
| 16:39 |
|
edgrey joined #minetest-dev |
| 16:41 |
|
edgrey joined #minetest-dev |
| 16:41 |
|
davisonio joined #minetest-dev |
| 16:45 |
|
Krock joined #minetest-dev |
| 16:45 |
|
Taoki[mobile] joined #minetest-dev |
| 16:47 |
|
hmmmm joined #minetest-dev |
| 16:47 |
|
edgrey joined #minetest-dev |
| 16:51 |
whitephoenix |
Oh, it is defined I just searched wrong derp |
| 17:01 |
|
Taoki[mobile] joined #minetest-dev |
| 17:02 |
|
Megaf joined #minetest-dev |
| 17:14 |
|
Krock joined #minetest-dev |
| 17:23 |
paramat |
seems we need more mtgame devs, i hope ruben-wardy can join sometime |
| 17:24 |
KaadmY |
btw has anything changed form schematics between 0.4.13 and 0.4.14? |
| 17:24 |
KaadmY |
0.4.14's schematics don't work properly with replacement nodes |
| 17:28 |
paramat |
they may have changed yes, what's the problem? |
| 17:29 |
paramat |
we added per-node force-place, and support for rotating all 24 node rotations |
| 17:31 |
paramat |
afaik we didn't directly alter node replacements stuff |
| 17:33 |
|
segfault22 joined #minetest-dev |
| 17:34 |
|
segfault22 left #minetest-dev |
| 17:41 |
|
Taoki[mobile] joined #minetest-dev |
| 17:47 |
|
ptv joined #minetest-dev |
| 17:47 |
|
ElectronLibre joined #minetest-dev |
| 17:48 |
|
Fixer joined #minetest-dev |
| 17:54 |
|
nrzkt joined #minetest-dev |
| 18:00 |
everamzah |
i added a video to #4321 https://www.youtube.com/watch?v=muEHE9Voe_M |
| 18:00 |
ShadowBot |
https://github.com/minetest/minetest/issues/4321 -- Possible to drag & drop items onto forbidden lists |
| 18:16 |
|
davisonio joined #minetest-dev |
| 18:42 |
|
Void7 joined #minetest-dev |
| 19:07 |
|
Void7 joined #minetest-dev |
| 19:15 |
|
Fixer_ joined #minetest-dev |
| 19:25 |
|
Taoki joined #minetest-dev |
| 19:34 |
|
Void7 joined #minetest-dev |
| 19:48 |
|
tenplus1 joined #minetest-dev |
| 19:48 |
tenplus1 |
hi folks |
| 19:48 |
tenplus1 |
could any dev please look at pull game#965 as it is ready for inclusion |
| 19:48 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/965 -- Ability to Disable bones, drop items or keep inventory. by tenplus1 |
| 19:49 |
Krock |
tenplus1, the files look well in the diff view, look at this: https://github.com/tenplus1/minetest_game/blob/9975e22d78335145c0756830386b231934ddbf69/game_api.txt#L67 |
| 19:51 |
Krock |
also, why is it bones.enable for a string value? |
| 19:51 |
Krock |
just wonder |
| 19:52 |
tenplus1 |
bones.enable was used as a global variable before but now on_die can be read from minetest.conf settings, I can easily change bones.enable to a lcoal var but it's working fine |
| 19:53 |
Krock |
the chosen variable name doesn't fit well IMO |
| 19:54 |
Krock |
and yes, could be made local (otherwise it would need a value other than nil when nobody has died after start) |
| 19:55 |
tenplus1 |
will change it to local bones_enable |
| 19:55 |
tenplus1 |
or just on_die |
| 19:55 |
Krock |
or bones_mode ? |
| 20:03 |
tenplus1 |
better: https://github.com/minetest/minetest_game/pull/965/ |
| 20:12 |
tenplus1 |
Krock: added bones_mode and split api text |
| 20:20 |
|
edgrey joined #minetest-dev |
| 20:22 |
|
Miner_48er joined #minetest-dev |
| 20:28 |
|
tenplus1 left #minetest-dev |
| 20:32 |
|
Void7 joined #minetest-dev |
| 20:41 |
|
paramat joined #minetest-dev |
| 20:43 |
|
davisonio joined #minetest-dev |
| 21:09 |
|
mmmm joined #minetest-dev |
| 22:42 |
|
ElectronLibre_ joined #minetest-dev |
| 22:45 |
|
Warr1024 joined #minetest-dev |
| 22:54 |
|
Fixer_ joined #minetest-dev |
| 23:14 |
|
Fixer joined #minetest-dev |
