| Time |
Nick |
Message |
| 00:29 |
|
dzho joined #minetest-dev |
| 00:54 |
ShadowNinja |
Zeno`: Re: Shader update patterns; I don't like the factory pattern any more than you, but it (or a variation of it) is necessary in that situation (unless you make a major API redesign or something I guess). I removed the SkyBackgroundColorProvider, but I had to replace it with a pointer to a pointer to the Sky, which isn't mush (if any) better. It seems like those things were actually done pretty well, despite the "superfluous |
| 00:54 |
ShadowNinja |
enterprise Javainess" that it look like at first. |
| 01:00 |
|
Tmanyo joined #minetest-dev |
| 01:48 |
Zeno` |
ShadowNinja, I agree |
| 01:50 |
Zeno` |
ShadowNinja, I think (hope) I said when I mentioned that I hated that, that I also thought it was probably the best way |
| 01:50 |
Zeno` |
so I have no objection to the PR at all. It's just how it has to be |
| 01:50 |
Zeno` |
as much as I hate it :) |
| 01:51 |
Zeno` |
it's a good PR btw |
| 01:51 |
Zeno` |
I've tested it a few times now |
| 02:26 |
|
STHGOM joined #minetest-dev |
| 02:30 |
|
STHGOM joined #minetest-dev |
| 03:22 |
|
Void7 joined #minetest-dev |
| 04:39 |
|
ssieb joined #minetest-dev |
| 05:06 |
|
Hunterz joined #minetest-dev |
| 05:45 |
|
nrzkt joined #minetest-dev |
| 05:46 |
Hijiri |
we should be introducing monads instead |
| 05:47 |
est |
Hijiri: when you rewrite minetest in haskell, we can do that |
| 05:48 |
est |
xD |
| 06:15 |
|
red-001 joined #minetest-dev |
| 06:36 |
|
paramat joined #minetest-dev |
| 06:56 |
|
ensonic joined #minetest-dev |
| 07:10 |
paramat |
forum spambot please ban https://forum.minetest.net/viewtopic.php?p=234186#p234186 |
| 08:02 |
|
nrzkt joined #minetest-dev |
| 09:03 |
|
Darcidride joined #minetest-dev |
| 09:17 |
|
troller joined #minetest-dev |
| 10:02 |
|
troller joined #minetest-dev |
| 10:27 |
|
fling joined #minetest-dev |
| 10:37 |
|
Darcidride joined #minetest-dev |
| 10:52 |
|
Darcidride joined #minetest-dev |
| 10:57 |
|
SloanOnLinux joined #minetest-dev |
| 10:57 |
|
SloanOnLinux joined #minetest-dev |
| 11:09 |
|
paramat joined #minetest-dev |
| 11:32 |
|
proller joined #minetest-dev |
| 11:40 |
|
Fixer joined #minetest-dev |
| 12:07 |
|
fling joined #minetest-dev |
| 12:13 |
|
Darcidride joined #minetest-dev |
| 12:35 |
|
proller joined #minetest-dev |
| 12:35 |
|
gregorycu joined #minetest-dev |
| 12:35 |
gregorycu |
Thank you ShadowNinja |
| 13:15 |
|
Ritchie joined #minetest-dev |
| 13:27 |
|
xunto joined #minetest-dev |
| 13:33 |
|
HonoredGlory joined #minetest-dev |
| 13:45 |
|
Hunterz joined #minetest-dev |
| 13:48 |
|
Darcidride joined #minetest-dev |
| 14:16 |
|
Fixer_ joined #minetest-dev |
| 14:25 |
gregorycu |
Fuck I'm good |
| 14:27 |
gregorycu |
So, I sped up mapblock_mesh_generate_special, from 1.1ms on average time, to 0.65ms |
| 14:40 |
gregorycu |
I know what you're thinking, "How did he do that. Save 0.4ms!" |
| 14:44 |
|
paramat joined #minetest-dev |
| 15:01 |
|
proller joined #minetest-dev |
| 15:03 |
|
hmmmm joined #minetest-dev |
| 15:06 |
paramat |
i'll probably start on a PR for this soon https://github.com/minetest/minetest/issues/4390#issuecomment-247217212 |
| 15:09 |
paramat |
part of #4390 |
| 15:09 |
ShadowBot |
https://github.com/minetest/minetest/issues/4390 -- Settings / .conf: Mgv5 ground noise unsettable / missing. 2 problems with .conf auto-generation |
| 15:14 |
|
STHGOM joined #minetest-dev |
| 15:31 |
|
STHGOM joined #minetest-dev |
| 15:33 |
|
KaadmY joined #minetest-dev |
| 15:46 |
gregorycu |
#4544 |
| 15:46 |
ShadowBot |
https://github.com/minetest/minetest/issues/4544 -- mapblock_mesh_generate_special improvements by gregorycu |
| 15:47 |
gregorycu |
Shouldn't be too controversial |
| 15:52 |
|
AcidNinjaFWHR joined #minetest-dev |
| 16:00 |
paramat |
thanks for that |
| 16:10 |
|
Fixer joined #minetest-dev |
| 16:14 |
paramat |
#4545 might merge this later (in a few hours) |
| 16:14 |
ShadowBot |
https://github.com/minetest/minetest/issues/4545 -- Conf.example: Re-add deleted noise parameter documentation by paramat |
| 16:22 |
|
proller joined #minetest-dev |
| 16:24 |
paramat |
as far as i know rubenwardy is currently busy starting university |
| 16:25 |
gregorycu |
University? Why is he doing that? |
| 16:33 |
Calinou |
gregorycu: I'm at university too :P |
| 16:33 |
|
Fixer joined #minetest-dev |
| 16:33 |
gregorycu |
Go get a job ya bludger |
| 16:34 |
gregorycu |
http://www.urbandictionary.com/define.php?term=bludger |
| 16:39 |
|
Krock joined #minetest-dev |
| 16:39 |
|
Krock joined #minetest-dev |
| 16:43 |
gregorycu |
#4346 |
| 16:43 |
ShadowBot |
https://github.com/minetest/minetest/issues/4346 -- Improved getPointedThing() by juhdanad |
| 16:43 |
gregorycu |
Looks good, we need to make sure we don't let this get stale |
| 16:46 |
|
johnnyjoy left #minetest-dev |
| 16:52 |
|
nrzkt joined #minetest-dev |
| 16:55 |
|
proller joined #minetest-dev |
| 17:03 |
|
STHGOM joined #minetest-dev |
| 17:05 |
|
Darcidride joined #minetest-dev |
| 17:05 |
|
Fixer_ joined #minetest-dev |
| 17:05 |
paramat |
game#1293 which means game#709 can now be closed |
| 17:05 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/1293 -- Add settingtypes.txt for Minetest Game by paramat |
| 17:05 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/709 -- Add settingtypes.txt by PilzAdam |
| 17:10 |
|
torgdor joined #minetest-dev |
| 17:11 |
|
Fixer joined #minetest-dev |
| 17:12 |
paramat |
game 1293 has the required approval so i might merge it later with game#1292 |
| 17:12 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/1292 -- Doors: Trim open fencegate collison box again by paramat |
| 17:20 |
paramat |
will merge games 1292 1293 in a moment |
| 17:25 |
paramat |
now merging |
| 17:27 |
|
ensonic joined #minetest-dev |
| 17:27 |
|
Darcidride joined #minetest-dev |
| 17:28 |
|
Darcidride joined #minetest-dev |
| 17:28 |
paramat |
complete |
| 17:29 |
paramat |
whoo 17 PRs |
| 17:32 |
celeron55 |
the PR open/closed ratio of _game is kind of impressive |
| 17:45 |
Fixer |
gregorycu is on coding spree |
| 17:46 |
Fixer |
celeron55: in good way, or bad? |
| 17:52 |
Krock |
PR open/merge ratio must be huge, not the one of open/close |
| 17:53 |
celeron55 |
i disagree |
| 17:53 |
celeron55 |
if PRs are shit, they shouldn't be merged, and the shittyness of PRs is not dependent on the project itself |
| 17:53 |
|
ssieb joined #minetest-dev |
| 17:57 |
paramat |
will merge #4545 in a moment |
| 17:57 |
ShadowBot |
https://github.com/minetest/minetest/issues/4545 -- Conf.example: Re-add deleted noise parameter documentation by paramat |
| 18:03 |
paramat |
now merging |
| 18:04 |
celeron55 |
that will need a better solution in the long term |
| 18:05 |
paramat |
yeah |
| 18:09 |
paramat |
merged |
| 18:11 |
|
proller joined #minetest-dev |
| 18:25 |
|
torgdor joined #minetest-dev |
| 18:26 |
|
paramat left #minetest-dev |
| 18:45 |
est31 |
rejecting a change is much harder than ignoring it |
| 18:45 |
est31 |
because you dont have to come up with an argument |
| 18:45 |
est31 |
when you ignore a change |
| 18:46 |
est31 |
tbh, most changes look good concept wise though, but reviewing them is just hard |
| 18:46 |
est31 |
like that PR for getting the selected node that does the raycasting |
| 18:47 |
est31 |
its nice concept wise, but the algorithm needs to be reviewed. |
| 18:49 |
Krock |
requires someone with the knowledge who takes the time to analyze it |
| 19:04 |
|
damiel_ joined #minetest-dev |
| 19:18 |
|
torgdor joined #minetest-dev |
| 19:58 |
|
Gael-de-Sailly joined #minetest-dev |
| 20:34 |
|
proller joined #minetest-dev |
| 20:34 |
|
AcidNinjaFWHR joined #minetest-dev |
| 21:15 |
SloanOnLinux |
hi |
| 21:17 |
|
STHGOM joined #minetest-dev |
| 21:17 |
|
STHGOM joined #minetest-dev |
| 21:22 |
|
johnnyjoy joined #minetest-dev |
| 21:30 |
|
Void7 joined #minetest-dev |
| 21:41 |
|
torgdor joined #minetest-dev |
| 22:23 |
|
troller joined #minetest-dev |
| 22:46 |
|
STHGOM joined #minetest-dev |
| 23:00 |
|
SloanOnLinux joined #minetest-dev |
| 23:00 |
|
SloanOnLinux joined #minetest-dev |
| 23:07 |
|
turtleman joined #minetest-dev |
| 23:33 |
|
Fritigern joined #minetest-dev |
| 23:44 |
|
torgdor joined #minetest-dev |
