| Time |
Nick |
Message |
| 00:04 |
Zeno` |
did you drink too much at Christmas paramat? :/ |
| 00:04 |
Zeno` |
"The default should continue to be what MTGame has done for 4 years, option 1" |
| 00:04 |
Zeno` |
wtf |
| 00:05 |
garywhite |
heh, maybe paramat did have a bit too much to drink...Oh wait, just a ping timeout, nvm |
| 00:08 |
Zeno` |
He's saying now that light level 14 has been needed to grow saplings for the last 4 years |
| 00:08 |
Zeno` |
but his commit 9 or 10 months ago was what changed it light level 14 |
| 00:08 |
Zeno` |
I'm getting very confused |
| 00:11 |
Zeno` |
oh, I see |
| 00:12 |
Zeno` |
he's commented that he is avoiding IRC because of me O.o |
| 00:15 |
VanessaE |
no |
| 00:24 |
|
Fritigern joined #minetest-dev |
| 00:36 |
|
YuGiOhJCJ joined #minetest-dev |
| 00:40 |
|
MikeHolder joined #minetest-dev |
| 00:52 |
Fixer |
thats not how you do development |
| 00:52 |
VanessaE |
apparently, it is. |
| 14:56 |
|
loggingbot_ joined #minetest-dev |
| 14:56 |
|
Topic for #minetest-dev is now Minetest core development and maintenance. Chit-chat goes to #minetest. Consider this instead of /msg celeron55. http://irc.minetest.net/minetest-dev/ http://dev.minetest.net/ |
| 14:56 |
sfan5 |
^ juhdanad fixed the logging |
| 14:57 |
juhdanad |
Thanks! |
| 15:09 |
red-001 |
#5000 |
| 15:09 |
ShadowBot |
https://github.com/minetest/minetest/issues/5000 -- Simpler serverlist serach by red-001 |
| 15:10 |
juhdanad |
Pretty number. |
| 15:16 |
|
Marko10_000 joined #minetest-dev |
| 15:39 |
|
blaze joined #minetest-dev |
| 15:41 |
|
octacian joined #minetest-dev |
| 15:41 |
|
octacian joined #minetest-dev |
| 16:01 |
|
nrzkt_ joined #minetest-dev |
| 16:11 |
|
red-001 joined #minetest-dev |
| 16:11 |
|
red-001 joined #minetest-dev |
| 16:14 |
|
hmmmm joined #minetest-dev |
| 16:39 |
|
nrzkt joined #minetest-dev |
| 16:41 |
|
rubenwardy joined #minetest-dev |
| 16:58 |
|
lumidify joined #minetest-dev |
| 17:09 |
|
AcidNinjaFWHR joined #minetest-dev |
| 17:10 |
|
emptty joined #minetest-dev |
| 17:14 |
|
Darcidride joined #minetest-dev |
| 17:19 |
|
juhdanad joined #minetest-dev |
| 17:36 |
juhdanad |
hmmmm: could you review #4682, please? It's a medium-sized pull request and I will be there to answer your questions to make your review faster. |
| 17:36 |
ShadowBot |
https://github.com/minetest/minetest/issues/4682 -- Fix water flooding onto lava by juhdanad |
| 17:40 |
|
red-001 joined #minetest-dev |
| 17:40 |
|
red-001 joined #minetest-dev |
| 17:41 |
red-001 |
!seen sofar |
| 17:41 |
ShadowBot |
red-001: I saw sofar in #minetest-dev 1 day, 15 hours, 30 minutes, and 22 seconds ago saying "yeah, just merge that." |
| 17:41 |
An0n3m0us |
cool |
| 17:45 |
sofar |
!seen red-001 |
| 17:45 |
ShadowBot |
sofar: I saw red-001 in #minetest-dev 3 minutes and 39 seconds ago saying "!seen sofar" |
| 17:46 |
|
paramat joined #minetest-dev |
| 17:48 |
nrzkt |
sofar, !seen inception |
| 17:48 |
Krock |
pls |
| 17:48 |
sofar |
inception last seen: about 8 months ago, blueray |
| 17:48 |
paramat |
please can anyone review #4965 ? fairly simple, fixes a crash plus other bugfixes :] |
| 17:48 |
ShadowBot |
https://github.com/minetest/minetest/issues/4965 -- Map generation limit: Fix checks for block/sector over-limit by paramat |
| 17:50 |
Krock |
LGTM |
| 17:52 |
juhdanad |
paramat: LGTM too, but wouldn't it be simpler if map_generation_limit were in block coordinates? |
| 17:53 |
paramat |
hm, calculate limit in block co-ords once .. |
| 17:54 |
|
YuGiOhJCJ joined #minetest-dev |
| 17:56 |
paramat |
well we could precalculate (mapgenlimit + 1) / blocksize |
| 17:56 |
paramat |
and mapgenlimit / blocksize |
| 17:57 |
juhdanad |
After all, the real map generation limit is always a multiplier of the block size (maybe the chunk size, too?) |
| 17:58 |
paramat |
it's not much simpler |
| 17:58 |
paramat |
no mapgenlimit is in nodes |
| 17:58 |
paramat |
i quite like how this works in all-integers |
| 17:59 |
paramat |
will wait for more input |
| 17:59 |
inception |
should I split the two commits in #5000 into two PR's? |
| 18:00 |
ShadowBot |
https://github.com/minetest/minetest/issues/5000 -- Simpler serverlist search by red-001 |
| 18:01 |
paramat |
any comments on game#1504 ? |
| 18:01 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/1504 -- Default: Alter sand to sandstone recipe by paramat |
| 18:02 |
nrzkt |
paramat: lgtm for me, there is no sense to turn the whole group into same block |
| 18:03 |
juhdanad |
Yes, true. |
| 18:03 |
paramat |
thanks for looking |
| 18:05 |
nrzkt |
paramat: i addressed a comment on map gen limit |
| 18:05 |
paramat |
replied |
| 18:12 |
|
Darcidride joined #minetest-dev |
| 18:18 |
nrzkt |
const static u16 map_gen_limit = MYMIN(MAX_MAP_GENERATION_LIMIT, g_settings->getU16("map_generation_limit")); |
| 18:18 |
nrzkt |
this should not be static |
| 18:19 |
nrzkt |
hmmmm: am i right if i say this function always return the same value whereas we change map_generation_limit configuration (due to static qualifier) |
| 18:19 |
nrzkt |
function always return => variable always has |
| 18:22 |
paramat |
hm, the limit should be changeable in advanced settings between game sessions |
| 18:23 |
paramat |
i suspect you're right |
| 18:25 |
paramat |
as in #4890 |
| 18:25 |
ShadowBot |
https://github.com/minetest/minetest/issues/4890 -- Don't cache active_block_range setting in a static by lhofhansl |
| 18:26 |
paramat |
i'll change that too |
| 18:27 |
paramat |
er, in a separate commit |
| 18:27 |
paramat |
that probaby needs fixing elsewhere too |
| 18:30 |
Krock |
btw, paramat, what's this? https://forum.minetest.net/viewtopic.php?f=3&t=16341 |
| 18:31 |
paramat |
unreasonable ranting about the light level poll |
| 18:32 |
Krock |
ah okay |
| 19:21 |
|
turtleman joined #minetest-dev |
| 20:00 |
|
Zeno` joined #minetest-dev |
| 20:12 |
|
KaadmY joined #minetest-dev |
| 20:16 |
|
red-001 joined #minetest-dev |
| 20:16 |
red-001 |
could someone review #5002? |
| 20:16 |
ShadowBot |
https://github.com/minetest/minetest/issues/5002 -- Extend minetest.is_yes() by red-001 |
| 20:16 |
sfan5 |
my review: why? |
| 20:19 |
Krock |
red-001, currently we don't need this change |
| 20:19 |
Krock |
quite trivial, too |
| 20:20 |
red-001 |
well doesn't that mean that if you set something in minetest.conf to on it will be off? |
| 20:20 |
sfan5 |
yes |
| 20:20 |
sfan5 |
but why does that need to be changed? |
| 20:21 |
red-001 |
isn't that a really confusing way for it to work? |
| 20:21 |
Krock |
it works fine with the current options |
| 20:21 |
sfan5 |
why confusing |
| 20:21 |
sfan5 |
it doesn't accept "yes please" either |
| 20:21 |
Krock |
or "plsno" |
| 20:22 |
Krock |
err. "plsno" is accepted |
| 20:22 |
red-001 |
well it accepts yes |
| 20:22 |
red-001 |
that makes less sense for settings |
| 20:22 |
red-001 |
then on |
| 20:22 |
Krock |
ehem. we use true/false for auto-generated settings |
| 20:23 |
celeron55 |
soon you'll be adding languages from outer space if you start extending that list |
| 20:23 |
celeron55 |
and at some point the same string has to mean true and false at the same time |
| 20:24 |
Zeno` |
well, to be fair, klingon has been missing for quite a while now |
| 20:25 |
red-001 |
so like nil? |
| 20:25 |
Zeno` |
nil and "maybe" |
| 20:25 |
sfan5 |
maybe sounds like a good config option |
| 20:26 |
sfan5 |
the C++ code will just return true in 50% of cases and false in the other 50% |
| 20:30 |
red-001 |
ok removed the minetest.is_yes modifications from #5000 |
| 20:30 |
ShadowBot |
https://github.com/minetest/minetest/issues/5000 -- Simpler serverlist search by red-001 |
| 20:33 |
Krock |
celeron55, Schroedinger's cat.. |
| 20:33 |
Krock |
it's 1/2 time yes |
| 20:33 |
sfan5 |
nah |
| 20:33 |
sfan5 |
it's unknown until you observe it |
| 20:33 |
sfan5 |
or rather both |
| 20:34 |
Krock |
statistiaclly it would be 50% but you don't know it exactly |
| 20:34 |
Krock |
Zeno`, I agree. When does weblate start supporting it? |
| 20:36 |
Zeno` |
Krock, soon? |
| 20:38 |
Krock |
not soon enough. I must get fonts to display the characters properly :< |
| 20:40 |
red-001 |
supporting what? |
| 20:40 |
Krock |
klingon characters (not speaking of Worf) |
| 20:47 |
celeron55 |
"maybe" would actually be kind of interesting |
| 20:47 |
celeron55 |
and then a "something" option which would be something between 0% and 200% of the default value |
| 20:48 |
red-001 |
well some settings could use an "auto" option |
| 20:48 |
red-001 |
like graphics |
| 20:48 |
celeron55 |
that would be hard |
| 20:48 |
celeron55 |
these are easy |
| 20:48 |
celeron55 |
we don't make hard things around here |
| 20:59 |
Krock |
haha :) |
| 21:00 |
|
emptty joined #minetest-dev |
| 21:20 |
|
AntumDeluge joined #minetest-dev |
| 21:28 |
|
juhdanad joined #minetest-dev |
| 21:40 |
|
AnotherBrick joined #minetest-dev |
| 22:15 |
|
paramat joined #minetest-dev |
| 22:37 |
|
turtleman joined #minetest-dev |
| 22:53 |
|
yellow_power_ joined #minetest-dev |
| 22:53 |
|
yellow_power_ joined #minetest-dev |
| 22:54 |
garywhite |
OK, I'm not exactly a geek, but I know a TNG reference when I see one, and what Krock said is a TNG reference |
| 23:08 |
|
DFeniks joined #minetest-dev |
| 23:25 |
|
Fritigern joined #minetest-dev |
| 23:25 |
|
fling joined #minetest-dev |
| 23:40 |
|
yellow_power_ joined #minetest-dev |
| 23:40 |
|
yellow_power_ joined #minetest-dev |
| 23:56 |
|
STHGOM_ joined #minetest-dev |
| 23:59 |
|
Tmanyo joined #minetest-dev |
