| Time |
Nick |
Message |
| 00:05 |
|
Guest46202 joined #minetest-dev |
| 00:07 |
|
red-001 joined #minetest-dev |
| 00:22 |
|
red-001 joined #minetest-dev |
| 00:22 |
|
red-001 joined #minetest-dev |
| 00:24 |
|
octacian_ joined #minetest-dev |
| 00:50 |
|
rubenwardy joined #minetest-dev |
| 01:08 |
rubenwardy |
#4806 |
| 01:08 |
ShadowBot |
https://github.com/minetest/minetest/issues/4806 -- Add search to advanced settings by rubenwardy |
| 01:10 |
|
Zeno` joined #minetest-dev |
| 02:13 |
|
YuGiOhJCJ joined #minetest-dev |
| 03:32 |
|
Miner_48er joined #minetest-dev |
| 04:13 |
|
Thomas-S joined #minetest-dev |
| 04:14 |
|
Hunterz joined #minetest-dev |
| 04:55 |
|
lumidify joined #minetest-dev |
| 05:22 |
|
lhofhansl joined #minetest-dev |
| 06:05 |
|
Hunterz joined #minetest-dev |
| 06:29 |
|
nrzkt joined #minetest-dev |
| 07:00 |
|
red-001 joined #minetest-dev |
| 07:00 |
|
red-001 joined #minetest-dev |
| 07:00 |
|
lumidify joined #minetest-dev |
| 07:28 |
|
lhofhansl left #minetest-dev |
| 08:26 |
|
nrzkt joined #minetest-dev |
| 09:18 |
|
Taoki joined #minetest-dev |
| 09:20 |
|
proller joined #minetest-dev |
| 09:40 |
|
^v joined #minetest-dev |
| 10:04 |
|
juhdanad joined #minetest-dev |
| 10:56 |
|
Fixer joined #minetest-dev |
| 11:05 |
|
juhdanad joined #minetest-dev |
| 11:06 |
|
YuGiOhJCJ joined #minetest-dev |
| 11:54 |
|
lumidify joined #minetest-dev |
| 12:32 |
|
juhdanad joined #minetest-dev |
| 12:38 |
|
proller joined #minetest-dev |
| 12:47 |
|
rubenwardy joined #minetest-dev |
| 12:47 |
rubenwardy |
updated #4806 |
| 12:47 |
ShadowBot |
https://github.com/minetest/minetest/issues/4806 -- Add search to advanced settings by rubenwardy |
| 13:03 |
|
Thomas-S joined #minetest-dev |
| 13:09 |
rubenwardy |
#5052 |
| 13:09 |
ShadowBot |
https://github.com/minetest/minetest/issues/5052 -- Rename ObjectRef methods to be consistent and predictable by rubenwardy |
| 13:49 |
|
rubenwardy joined #minetest-dev |
| 13:58 |
|
blaze joined #minetest-dev |
| 14:04 |
|
^v joined #minetest-dev |
| 14:51 |
|
rubenwardy joined #minetest-dev |
| 15:05 |
|
juhdanad joined #minetest-dev |
| 15:05 |
|
YuGiOhJCJ joined #minetest-dev |
| 15:12 |
|
Hunterz joined #minetest-dev |
| 15:17 |
rubenwardy |
#5053 |
| 15:17 |
ShadowBot |
https://github.com/minetest/minetest/issues/5053 -- Adjust formspec spacing on the Client tab of the mainmenu by rubenwardy |
| 15:24 |
sfan5 |
#5039 is still in need of an approval |
| 15:24 |
ShadowBot |
https://github.com/minetest/minetest/issues/5039 -- Add particle animation, glow by sfan5 |
| 15:25 |
|
Warr1024 joined #minetest-dev |
| 15:29 |
rubenwardy |
Imo, the biggest issue with particles atm isn't the features but its speed |
| 15:29 |
rubenwardy |
but that PR does seem useful |
| 15:30 |
rubenwardy |
updated (and squashed) #5052 |
| 15:30 |
ShadowBot |
https://github.com/minetest/minetest/issues/5052 -- Rename ObjectRef methods to be consistent and predictable by rubenwardy |
| 15:31 |
nrzkt |
rubenwardy: src/script/lua_api/l_internal.h.gch |
| 15:31 |
nrzkt |
please remove that, what is that ? |
| 15:32 |
rubenwardy |
ffs |
| 15:32 |
rubenwardy |
stupid linter |
| 15:33 |
rubenwardy |
why doesn't it write to a hidden file |
| 15:35 |
rubenwardy |
done |
| 15:39 |
rubenwardy |
anyone fancy taking a look at #4806 |
| 15:39 |
ShadowBot |
https://github.com/minetest/minetest/issues/4806 -- Add search to advanced settings by rubenwardy |
| 15:39 |
rubenwardy |
:D |
| 15:41 |
juhdanad |
There are 15 1-s. It is definitely useful. |
| 15:41 |
juhdanad |
*+1-s. |
| 15:44 |
|
lisac joined #minetest-dev |
| 15:52 |
nrzkt |
in fact rubenwardy problem is git add . or git commit -A :) if you use git properly it should not add non staged files :) |
| 15:52 |
nrzkt |
else, okay for 5052 |
| 15:52 |
nrzkt |
you can merge when you want |
| 15:53 |
rubenwardy |
alsome |
| 15:53 |
rubenwardy |
Will merge in 1 |
| 15:53 |
rubenwardy |
oops |
| 15:53 |
rubenwardy |
15 |
| 15:54 |
rubenwardy |
I don't like using -a as it means you can accidentally make commits when pressing up on the terminal and selecting the wrong command |
| 15:54 |
rubenwardy |
I guess that's a silly reason though |
| 15:54 |
rubenwardy |
there's always --amend |
| 15:55 |
nrzkt |
git commit -am don't add non added files, it only adds all files in git tree, not fs tree, -A is different |
| 15:55 |
|
octacian joined #minetest-dev |
| 15:55 |
|
octacian joined #minetest-dev |
| 15:56 |
rubenwardy |
Can you use a with --amend? |
| 15:57 |
rubenwardy |
I'd assume so |
| 15:57 |
nrzkt |
--amend permit to edit the commit |
| 15:57 |
nrzkt |
it edits the last commit done |
| 15:59 |
rubenwardy |
updated #5053 |
| 15:59 |
ShadowBot |
https://github.com/minetest/minetest/issues/5053 -- Adjust formspec spacing on the Client tab of the mainmenu by rubenwardy |
| 15:59 |
rubenwardy |
it's in two commits to permit easy reviewing - first is actual change, second is style fixes |
| 16:00 |
|
^v joined #minetest-dev |
| 16:07 |
rubenwardy |
merging... |
| 16:07 |
rubenwardy |
done |
| 16:12 |
|
red-001 joined #minetest-dev |
| 16:12 |
|
red-001 joined #minetest-dev |
| 16:18 |
|
^v joined #minetest-dev |
| 16:21 |
|
^v joined #minetest-dev |
| 16:33 |
rubenwardy |
Can we create an android branch on minetest/minetest? This should be lastest stable + plus backports |
| 16:34 |
rubenwardy |
And then every so often it should be released to the play store |
| 16:34 |
rubenwardy |
(Android should have a much shorter release cycle than Minetest) |
| 16:34 |
rubenwardy |
s/Minetest/PC/g |
| 16:35 |
rubenwardy |
I'm unsure of what commit the play store is at |
| 16:35 |
rubenwardy |
nrzkt ^ |
| 16:35 |
rubenwardy |
Also, it would be a lot more professional if we had a Minetest developer profile |
| 16:36 |
rubenwardy |
but, low priority |
| 16:40 |
nrzkt |
rubenwardy: i did it before but nobody cares about this android branch |
| 16:40 |
nrzkt |
playstore is on release tag, everytime, except this release because i needed a little compilation fix |
| 16:41 |
nrzkt |
rubenwardy: if you have 100$ we can have a developper profile, but nobody cares |
| 16:41 |
nrzkt |
minetest app is not very well ranked |
| 16:42 |
rubenwardy |
let's change that :) |
| 16:44 |
|
red-001 joined #minetest-dev |
| 16:44 |
|
red-001 joined #minetest-dev |
| 16:45 |
|
turtleman joined #minetest-dev |
| 16:47 |
rubenwardy |
made it https://github.com/minetest/minetest/tree/android |
| 16:48 |
rubenwardy |
what commit is the compile fix? I can't see any relevant ones |
| 16:50 |
|
STHGOM joined #minetest-dev |
| 16:50 |
|
STHGOM joined #minetest-dev |
| 16:52 |
nrzkt |
what is android branch ? |
| 16:52 |
nrzkt |
https://github.com/minetest/minetest/commit/b95f543da9d56974c4db8e34ce93e6f3bf7e776c |
| 16:53 |
nrzkt |
this commit was required to stabilize build accross different machines, it breaks on mine |
| 16:53 |
|
crazyR joined #minetest-dev |
| 16:53 |
nrzkt |
in 0.4.14 i had gradle 2.X in 0.4.15 it was upgraded to 3.X and not compatible |
| 16:54 |
rubenwardy |
updated branch |
| 16:55 |
rubenwardy |
the point of android is to be the play store version + WIP commits which will be added to the play store soon |
| 16:55 |
rubenwardy |
so basically MT stable with Android specific improvements on top |
| 16:55 |
rubenwardy |
we should also consider using public beta to give access to 0.4.15-dev |
| 16:55 |
rubenwardy |
not sure if that's already done |
| 16:58 |
nrzkt |
rubenwardy: before creating a branch in the official repository maybe discuss with every dev. |
| 16:59 |
nrzkt |
and personnaly i will not maintain this branch |
| 16:59 |
|
Hunterz joined #minetest-dev |
| 16:59 |
nrzkt |
having shorter cycles on master could be better |
| 16:59 |
nrzkt |
4 months cycles for example |
| 16:59 |
nrzkt |
instead of rand(6,inf) months |
| 17:00 |
rubenwardy |
you've pushed fixes to android before |
| 17:00 |
rubenwardy |
the point of this is to make the fixes transparent |
| 17:00 |
rubenwardy |
rather than being in your local branch |
| 17:00 |
nrzkt |
yes but that fixes are mandatory to make game work, now it works :) |
| 17:00 |
rubenwardy |
it's pretty trivial to cherry-pick |
| 17:00 |
nrzkt |
not sure, depend on which part |
| 17:04 |
|
Krock joined #minetest-dev |
| 17:04 |
|
Krock joined #minetest-dev |
| 17:05 |
rubenwardy |
the reason it's not popular is because it's buggy |
| 17:05 |
rubenwardy |
and user complaints aren't listened to |
| 17:05 |
rubenwardy |
it should be possible to release bug fixes without waiting months for the next android version |
| 17:05 |
rubenwardy |
*Minetest |
| 17:10 |
rubenwardy |
bbl, will read logs |
| 17:11 |
rubenwardy |
Also, I'd like to add - I literally made a branch to track the version of Minetest on the app store, it's not like I pushed a commit adding pokemon to master :P |
| 17:21 |
|
juhdanad joined #minetest-dev |
| 17:26 |
|
proller joined #minetest-dev |
| 17:32 |
|
octacian_ joined #minetest-dev |
| 17:33 |
|
^v joined #minetest-dev |
| 17:36 |
|
rubenwardy joined #minetest-dev |
| 17:36 |
|
STHGOM_ joined #minetest-dev |
| 18:12 |
|
nrzkt joined #minetest-dev |
| 18:12 |
|
fwhcat joined #minetest-dev |
| 18:15 |
|
red-001 joined #minetest-dev |
| 18:15 |
|
red-001 joined #minetest-dev |
| 18:15 |
red-001 |
#5055 |
| 18:15 |
ShadowBot |
https://github.com/minetest/minetest/issues/5055 -- Remove client-side chat prediction. by red-001 |
| 18:19 |
red-001 |
couldn't think of a way to do it without a protocol bump |
| 18:21 |
rubenwardy |
also add "no_chat_message_prediction" to builtin/game/features.lua |
| 18:22 |
red-001 |
ok |
| 18:23 |
red-001 |
done |
| 18:25 |
nrzkt |
red-001, don't bump protocol there is already proto v29 in this devel cycle |
| 18:26 |
red-001 |
so should I just leave the protocol version at 29? |
| 18:26 |
nrzkt |
yes, and your server side method is wrong |
| 18:26 |
|
betterthanyou710 joined #minetest-dev |
| 18:26 |
red-001 |
so breaking support with clients in the current dev cycle is ok? |
| 18:27 |
nrzkt |
this PR will only break old clients on newer server because they will receive raw chat message from themselves |
| 18:27 |
red-001 |
huh what's wrong with it? |
| 18:27 |
nrzkt |
but... no in fact, they will negociate an old protocol and we won't send packet |
| 18:28 |
nrzkt |
then server-side only replace filtering test on packet sending with filtering only if proto < current_dev_proto |
| 18:28 |
nrzkt |
you don't need the return, i don't know what is does but it's the wrong way i nthis function, only filtering should be modified |
| 18:30 |
red-001 |
the return makes the server send the chat to the client |
| 18:31 |
red-001 |
serverpackethandler line 1099 |
| 18:31 |
|
troller joined #minetest-dev |
| 18:42 |
|
Sokomine joined #minetest-dev |
| 18:44 |
red-001 |
whats the max length of single line comments? |
| 18:45 |
red-001 |
the same as for code? |
| 18:45 |
rubenwardy |
yeah |
| 18:46 |
rubenwardy |
merging #5053 in 15 minutes (with self-approval) |
| 18:46 |
ShadowBot |
https://github.com/minetest/minetest/issues/5053 -- Adjust formspec spacing on the Client tab of the mainmenu by rubenwardy |
| 18:53 |
red-001 |
fixed the issues with 5055 |
| 18:54 |
|
xerox123 joined #minetest-dev |
| 19:25 |
|
STHGOM_ joined #minetest-dev |
| 19:25 |
rubenwardy |
merging... |
| 19:25 |
rubenwardy |
done |
| 19:59 |
crazyR |
is anyone using the development branch of the streets mod: streets 2.0?? |
| 19:59 |
crazyR |
Sorry wrong channel |
| 20:36 |
|
Player_2 joined #minetest-dev |
| 20:40 |
|
^v joined #minetest-dev |
| 20:57 |
|
Tmanyo joined #minetest-dev |
| 21:18 |
|
Tmanyo joined #minetest-dev |
| 22:21 |
|
Tmanyo joined #minetest-dev |
| 22:43 |
|
red-001 joined #minetest-dev |
| 22:54 |
|
red-001 joined #minetest-dev |
| 22:54 |
|
red-001 joined #minetest-dev |
| 22:58 |
nrzkt |
merging #5055 |
| 22:58 |
ShadowBot |
https://github.com/minetest/minetest/issues/5055 -- Remove client-side chat prediction. by red-001 |
| 22:58 |
nrzkt |
in fact no |
| 22:58 |
nrzkt |
there is an error |
| 22:59 |
red-001 |
what is it? |
| 22:59 |
nrzkt |
Don't send the message back to the inital sender if they are using protocol version < 29 |
| 22:59 |
nrzkt |
condition is inverted |
| 22:59 |
red-001 |
oh missed that |
| 22:59 |
red-001 |
sorry about that |
| 23:00 |
nrzkt |
i don't really understand what is builting/game/features.lua for ? |
| 23:00 |
red-001 |
rubenwardy requested it |
| 23:01 |
red-001 |
I think its so that mods can change their behaviour based on whatever this change has been made or not |
| 23:01 |
nrzkt |
please fix the typo i will merge :) |
| 23:02 |
nrzkt |
also this commit is needed if we have client side chat customization (but i think we need better chat protocol than this raw protocol) |
| 23:03 |
red-001 |
so "if (player->protocol_version >= 29)" to "if (player->protocol_version < 29)"? |
| 23:04 |
nrzkt |
no, the problem is the comment, not the code |
| 23:04 |
|
AntumDeluge joined #minetest-dev |
| 23:04 |
nrzkt |
broadcasting to proto v29 is good, but it's not what comment said, |
| 23:05 |
nrzkt |
red-001, >= not > |
| 23:05 |
nrzkt |
it's same as your code condition |
| 23:07 |
|
AntumDeluge joined #minetest-dev |
| 23:08 |
red-001 |
better? |
| 23:09 |
nrzkt |
yes, merging then |
| 23:11 |
red-001 |
can you close #4976 than? |
| 23:11 |
ShadowBot |
https://github.com/minetest/minetest/issues/4976 -- client-side chat prediction cannot be disabled |
| 23:17 |
|
troller joined #minetest-dev |
| 23:28 |
nrzkt |
ofc |
| 23:45 |
|
STHGOM joined #minetest-dev |
| 23:45 |
|
STHGOM joined #minetest-dev |
| 23:47 |
|
troller joined #minetest-dev |
| 23:54 |
|
troller joined #minetest-dev |
