| Time |
Nick |
Message |
| 00:02 |
|
SloanOnLinux joined #minetest-dev |
| 00:24 |
rubenwardy |
game#1604 |
| 00:24 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/1604 -- sfinv: Fix wrong tab being highlighted by rubenwardy |
| 00:24 |
rubenwardy |
#5302 |
| 00:24 |
ShadowBot |
https://github.com/minetest/minetest/issues/5302 -- Store legacy metadata separate from new item meta data by rubenwardy |
| 00:25 |
rubenwardy |
#5348 |
| 00:25 |
ShadowBot |
https://github.com/minetest/minetest/issues/5348 -- Better input: Abstracting type of binding from the rest of the game |
| 00:25 |
rubenwardy |
First two fix bugs |
| 00:25 |
rubenwardy |
the third is to request feedback for a design |
| 00:28 |
|
Warr1024 joined #minetest-dev |
| 00:39 |
|
paramat joined #minetest-dev |
| 01:16 |
|
kaeza joined #minetest-dev |
| 01:53 |
|
ircSparky_ joined #minetest-dev |
| 04:21 |
|
Hunterz joined #minetest-dev |
| 04:45 |
|
YuGiOhJCJ joined #minetest-dev |
| 05:03 |
|
DI3HARD139 joined #minetest-dev |
| 05:25 |
|
SloanOnLinux joined #minetest-dev |
| 06:02 |
|
Hunterz joined #minetest-dev |
| 06:17 |
|
xunto joined #minetest-dev |
| 06:39 |
|
paramat joined #minetest-dev |
| 06:40 |
|
nerzhul joined #minetest-dev |
| 07:44 |
paramat |
game#1605 |
| 07:44 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/1605 -- Ladder recipe: Make wooden ladder recipe more generous by paramat |
| 07:45 |
nerzhul |
engine PR count is incredibely high, i think we should close all non useful and old PR |
| 08:00 |
paramat |
hehe, it's worth going through them (and i will again), but when i do i find i can't close as many as i had hoped. anyway there is the 'close if 1 month with no response' rule |
| 08:01 |
paramat |
the 'possible close' label is good for flagging for other devs to consider a close |
| 08:03 |
|
lumidify joined #minetest-dev |
| 08:03 |
paramat |
celeron55 we're seriously understaffed, perhaps soon we can consider lhofhansl as a new core dev? see contributions https://github.com/minetest/minetest/pulls?q=is%3Apr+author%3Alhofhansl |
| 08:04 |
paramat |
also i feel we can consider Krock too |
| 08:05 |
|
chatter29 joined #minetest-dev |
| 08:05 |
chatter29 |
hey guys |
| 08:05 |
chatter29 |
allah is doing |
| 08:05 |
chatter29 |
sun is not doing allah is doing |
| 08:05 |
chatter29 |
to accept islam say that i bear witness that there is no deity worthy of worship except allah and muhammad peace be upon him is his slave and messenger |
| 08:05 |
paramat |
oh no |
| 08:05 |
kaeza |
your ideas are intriguing to me and I wish to subscribe to your newsletter |
| 08:05 |
paramat |
^ celeron55 |
| 08:06 |
kaeza |
the above, not me :P |
| 08:07 |
|
chatter29 was kicked by celeron55: chatter29 |
| 08:07 |
paramat |
thanks |
| 08:07 |
celeron55 |
it's a different ip than last time though |
| 08:07 |
celeron55 |
so that won't really help |
| 08:11 |
|
Fritigern joined #minetest-dev |
| 08:20 |
est31 |
I've also seen chatter29 connect through IP 45.63.65.13 |
| 08:20 |
est31 |
4:22 today on #flatpak |
| 08:20 |
est31 |
(now is 9:20 in my Timezone) |
| 08:21 |
est31 |
both am |
| 08:22 |
|
Darcidride joined #minetest-dev |
| 08:42 |
|
nrzkt joined #minetest-dev |
| 08:43 |
paramat |
#5349 |
| 08:43 |
ShadowBot |
https://github.com/minetest/minetest/issues/5349 -- Climb speed: Increase default setting from 2 to 3 by paramat |
| 09:10 |
|
troller joined #minetest-dev |
| 09:14 |
|
juhdanad joined #minetest-dev |
| 09:31 |
|
xerox123 joined #minetest-dev |
| 09:57 |
|
Darcidride joined #minetest-dev |
| 10:27 |
|
lumidify joined #minetest-dev |
| 10:36 |
|
Darcidride joined #minetest-dev |
| 10:56 |
|
troller joined #minetest-dev |
| 11:19 |
|
proller joined #minetest-dev |
| 11:25 |
|
Fixer joined #minetest-dev |
| 11:37 |
|
proller joined #minetest-dev |
| 12:16 |
|
YuGiOhJCJ joined #minetest-dev |
| 12:18 |
|
SloanOnLinux joined #minetest-dev |
| 12:35 |
|
proller joined #minetest-dev |
| 12:37 |
|
DI3HARD139 joined #minetest-dev |
| 13:24 |
|
lisac joined #minetest-dev |
| 14:03 |
nrzkt |
sfan5, Zeno`: are you there ? |
| 14:03 |
nrzkt |
maybe sofar too |
| 14:04 |
nrzkt |
i added a new travis step, see #5350 |
| 14:04 |
ShadowBot |
https://github.com/minetest/minetest/issues/5350 -- CI: Add memleak checking using valgrind by nerzhul |
| 14:05 |
nrzkt |
it permits to use our unittests to find memleaks and it seems this is the case on some conversions, i have some valgrind errors, i only need to find how to return bad RC when valgrind give us bad results |
| 14:07 |
nrzkt |
look at there: https://travis-ci.org/minetest/minetest/jobs/208202742 |
| 14:25 |
|
tenplus1 joined #minetest-dev |
| 14:25 |
tenplus1 |
hi folks |
| 14:26 |
nrzkt |
hi tenplus1 |
| 14:26 |
tenplus1 |
has anyone (dev) looked at these pulls for addition now that they have been tested: #5293 #5162 game#1543 |
| 14:26 |
tenplus1 |
hi nrz |
| 14:27 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/1543 -- Add 'creative' privilege for survival servers by tenplus1 |
| 14:27 |
ShadowBot |
https://github.com/minetest/minetest/issues/5293 -- Add damage from falling nodes by tenplus1 |
| 14:27 |
ShadowBot |
https://github.com/minetest/minetest/issues/5162 -- Optimize item.lua by tenplus1 |
| 14:27 |
nrzkt |
i reviewed the damage on falling node and i think it's a wrong approach |
| 14:27 |
nrzkt |
we should do the breathing on node check on SAO not on nodes |
| 14:28 |
tenplus1 |
explain pls :) |
| 14:28 |
nrzkt |
instead node check who is near and damage it, we look at all SAO position to see if they are inside a node which hurt |
| 14:29 |
nrzkt |
it's a far better approach and less CPU consuming |
| 14:29 |
tenplus1 |
this isnt for suffocation, it's the physical act of the node hitting the player/mob from above that causes damage (like anvils90 |
| 14:29 |
nrzkt |
okay i see this is not the same problem, then the falling node is a SAO |
| 14:30 |
nrzkt |
okay it's more clear |
| 14:30 |
nrzkt |
also you should check SAO under falling SAO, not upper |
| 14:30 |
tenplus1 |
we use it on Xanadu if you want a look see, it works quite well |
| 14:31 |
tenplus1 |
we check under... |
| 14:31 |
nrzkt |
where ? |
| 14:31 |
nrzkt |
i don't see any position comparision between falling SAO & in-radius SAO |
| 14:31 |
tenplus1 |
line 54 sets bcp at -0.7 below node |
| 14:31 |
tenplus1 |
that's what is checked... below node |
| 14:32 |
nrzkt |
0.7 is negative ? |
| 14:32 |
tenplus1 |
-0.7 |
| 14:32 |
nrzkt |
it seems you missed the minor no ? |
| 14:32 |
nrzkt |
local all_objects = minetest.get_objects_inside_radius(bcp, 0.7) |
| 14:32 |
tenplus1 |
0.7 is the radus in that line |
| 14:32 |
nrzkt |
okay then it's nice |
| 14:32 |
tenplus1 |
local bcp = {x = pos.x, y = pos.y - 0.7, z = pos.z} |
| 14:32 |
tenplus1 |
local all_objects = minetest.get_objects_inside_radius(bcp, 0.7) |
| 14:33 |
tenplus1 |
and only if falling node has falling_node_damage set then it will check below so not ALL falling nodes look for entities :D so not causing lag |
| 14:33 |
nrzkt |
maybe add a game option to make it optional for whoever needs it |
| 14:33 |
nrzkt |
in minetest.conf |
| 14:33 |
nrzkt |
default to true seems lgtm, and if someone wants to disable there is the builting switch |
| 14:33 |
tenplus1 |
comes under 'enable_damage' :) |
| 14:33 |
nrzkt |
if i want to disable this damage not all damages ? |
| 14:34 |
tenplus1 |
soo many settings :) |
| 14:34 |
nrzkt |
i think it's a good optoin |
| 14:35 |
tenplus1 |
enabled by default ? |
| 14:35 |
nrzkt |
y |
| 14:35 |
nrzkt |
i think at a point we should consider falling node into core instead of builting to improve performance, especially on large sand falling areas |
| 14:36 |
tenplus1 |
the routine I've added doesnt lag, even with many nodes falling... has been tested for this already |
| 14:37 |
tenplus1 |
did you see the other 2 pulls for item.lua and 'creative' priv addition |
| 14:37 |
nrzkt |
did you try to fall 1k ndoes ? |
| 14:37 |
nrzkt |
for creative i'm not very aware i let other devs do it |
| 14:38 |
tenplus1 |
it adds the priv if a server owner wishes to give it to someone in survival game :) helps with building only |
| 14:38 |
tenplus1 |
and the item.lua pull speeds up the game |
| 14:40 |
VanessaE |
unified inventory does that. |
| 14:41 |
tenplus1 |
exactly... this is for default game or servers that do not use unified inventory... again, running perfectly well on Xanadu if you wanna test |
| 14:42 |
tenplus1 |
also... hi Vanessa :P |
| 14:47 |
|
ircSparky joined #minetest-dev |
| 14:47 |
|
ircSparky joined #minetest-dev |
| 14:54 |
tenplus1 |
nrzkt: https://github.com/minetest/minetest/pull/5293 added setting |
| 15:01 |
|
octacian joined #minetest-dev |
| 15:01 |
tenplus1 |
hi oc |
| 15:30 |
|
XtremeHacker joined #minetest-dev |
| 15:48 |
nrzkt |
sfan5: are you around ? |
| 15:48 |
sfan5 |
busy |
| 15:48 |
nrzkt |
i don't found which std::string is reponsible for this memlea: http://pastebin.com/KDty6x37 |
| 15:48 |
nrzkt |
okay, thanks for the review, we only need to fix this memleak to make valgrind happy and CI happy to make it mergeable |
| 15:52 |
|
proller joined #minetest-dev |
| 15:56 |
|
tenplus1 left #minetest-dev |
| 16:08 |
|
proller joined #minetest-dev |
| 16:22 |
|
ircSparky_ joined #minetest-dev |
| 16:38 |
|
twoelk joined #minetest-dev |
| 16:58 |
|
Hunterz joined #minetest-dev |
| 17:10 |
Preuk |
sry wrong chan/join #dwarffortress |
| 17:18 |
|
Krock joined #minetest-dev |
| 17:18 |
|
Krock joined #minetest-dev |
| 17:26 |
|
nerzhul joined #minetest-dev |
| 17:31 |
Krock |
nerzhul, are there any burther changes to do for #5340 ? |
| 17:31 |
ShadowBot |
https://github.com/minetest/minetest/issues/5340 -- Add fading sounds by SmallJoker |
| 17:31 |
Krock |
*further |
| 17:32 |
nerzhul |
you fixed the floating points on cpp and lua ? |
| 17:32 |
Krock |
yep |
| 17:32 |
Krock |
travis is currently running through it |
| 17:32 |
nerzhul |
i don't know if it's very important in Lua but in CPP this can make some wrong things after compilation sometimes |
| 17:33 |
Krock |
really? that would be really strange because.. well 0 is 0 |
| 17:33 |
nerzhul |
not for ASM and memory |
| 17:34 |
nerzhul |
one time i spent 2 hours debugging some code because i set an int into a float somewhere in the code using some STL wrappers ... because i just forgot .0f |
| 17:35 |
nerzhul |
i'm at home and i can do some more reviews, then i'm doing more |
| 17:36 |
Krock |
okay, seems like not all compilers can handle these type conversions curretly |
| 17:37 |
nerzhul |
sfan5, seems the valgrind PR is okay, it compiled mac osx (which is not affected by the change |
| 17:38 |
nerzhul |
and i added valgrind flag for heuristics permitting to solve the std::string non problem due to valgrind |
| 17:55 |
|
proller joined #minetest-dev |
| 18:31 |
Krock |
nerzhul, would you please be so nice and point me out where exactly this "0.f" code style rule is defined? |
| 18:35 |
nerzhul |
i think nowhere, but we never use the floating point without the 0 before f |
| 18:35 |
nerzhul |
then please be compliant with other code :) |
| 18:36 |
Krock |
found 124 files in the src/ directory with the text ".f" |
| 18:37 |
Krock |
even with ".f " there are still 11 files. (excluding ".find" and such this time) |
| 18:39 |
Krock |
however, will correct the float numbers but this zero after the decimal point seems redundant |
| 18:40 |
nerzhul |
then okay ignore my comment |
| 18:40 |
Krock |
to clean up my argument: the regular expression "[0-9][.][f]" returned more accurate results: 25 files ;) |
| 18:51 |
|
rubenwardy joined #minetest-dev |
| 18:51 |
|
xerox123 joined #minetest-dev |
| 19:02 |
Krock |
!tell paramat [Pull 5255: find_node_near center param] - since invalid index and nil/false return 0, the start radius would be set to `1`, which is the current default |
| 19:02 |
ShadowBot |
Krock: O.K. |
| 19:03 |
Krock |
thanks, ShadowBot <3 |
| 19:17 |
|
ircSparky__ joined #minetest-dev |
| 19:22 |
|
xerox123 joined #minetest-dev |
| 19:28 |
|
proller joined #minetest-dev |
| 19:33 |
nerzhul |
merging #5350 i hope we will ahve more unittests in the future permitting to detect memleaks on CI |
| 19:34 |
ShadowBot |
https://github.com/minetest/minetest/issues/5350 -- CI: Add memleak checking using valgrind by nerzhul |
| 19:46 |
|
xerox123 joined #minetest-dev |
| 20:04 |
|
xerox123 joined #minetest-dev |
| 20:17 |
Thomas-S |
Could minetest_game devs please review game#1580 ? There is also a bugfix for chests included. Thanks in advance! |
| 20:17 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/1580 -- Change doors to default.can_interact_with_node() by Thomas--S |
| 20:18 |
|
ircSparky_ joined #minetest-dev |
| 20:22 |
|
lisac joined #minetest-dev |
| 20:43 |
|
twoelk left #minetest-dev |
| 20:53 |
|
lisac joined #minetest-dev |
| 20:58 |
|
proller joined #minetest-dev |
| 21:16 |
|
twoelk joined #minetest-dev |
| 21:28 |
|
proller joined #minetest-dev |
| 22:10 |
* sofar |
is back home |
| 22:12 |
VanessaE |
welcome home. |
| 23:03 |
|
ircSparky joined #minetest-dev |
| 23:08 |
|
ircSparky joined #minetest-dev |
| 23:08 |
|
ircSparky joined #minetest-dev |
| 23:17 |
|
ircSparky joined #minetest-dev |
| 23:17 |
|
ircSparky joined #minetest-dev |
| 23:37 |
|
ircSparky joined #minetest-dev |
| 23:38 |
|
rubenwardy joined #minetest-dev |
