| Time |
Nick |
Message |
| 00:22 |
octacian |
Rebase needed label can please be removed from #5627 |
| 00:23 |
ShadowBot |
https://github.com/minetest/minetest/issues/5627 -- Menu: Merge singleplayer and server tabs by octacian |
| 00:41 |
|
Tmanyo joined #minetest-dev |
| 00:47 |
|
Fritigern joined #minetest-dev |
| 02:06 |
|
torgdor joined #minetest-dev |
| 02:18 |
|
makmm joined #minetest-dev |
| 02:18 |
makmm |
Hello, I know this will sound weird but I want to learn how to make an minetest hack/cheat. Will you help me or no? :3 |
| 02:23 |
makmm |
Well i have to go on discord you can ping me, im @duckifier#2655 |
| 02:23 |
KaadmY |
Why does ItemStack("default:stick 2"):to_string() == "default:stick" |
| 02:24 |
KaadmY |
The count is always 1 |
| 02:24 |
KaadmY |
Itemtable and itemstring input both act the same |
| 02:25 |
KaadmY |
Huh |
| 02:26 |
KaadmY |
Oh I was dumb |
| 02:26 |
KaadmY |
I was using a tool, the count is always 1 |
| 03:04 |
|
troller joined #minetest-dev |
| 03:56 |
|
octacian_ joined #minetest-dev |
| 05:00 |
|
kaeza joined #minetest-dev |
| 06:03 |
|
Hunterz joined #minetest-dev |
| 06:09 |
|
nerzhul joined #minetest-dev |
| 06:23 |
|
DS-minetest joined #minetest-dev |
| 06:49 |
nerzhul |
hi :) merging #5751 trivial fix |
| 06:49 |
ShadowBot |
https://github.com/minetest/minetest/issues/5751 -- Minor pause/escape menu improvements by red-001 |
| 06:50 |
nerzhul |
ty red-002 |
| 06:51 |
VanessaE |
is there any known chatcommand exploit in either engine, mt_game, or CSM? |
| 06:52 |
nerzhul |
precision s? |
| 06:52 |
Hijiri |
not any that are known to me |
| 06:53 |
VanessaE |
a user, twice now, managed to gain full admin privs on two of my servers, without there being any log of the event. I have a theory (which I've acted on already), but there's a possibility that someone has found an exploit via normal chat commands somewhere |
| 06:53 |
nerzhul |
if it is, it's due to one of your installed mod(packs) |
| 06:53 |
VanessaE |
I won't know if my theory is correct until the guy managed to evade my ban and sign on to try again |
| 06:53 |
nerzhul |
coreside, privileges can only be added using Lua API |
| 06:54 |
VanessaE |
nerzhul: that's what I'm afraid of. I've removed the one mod that I think is the attack vector but I just can't be sure |
| 06:54 |
nerzhul |
look at all privileges additions in your mods |
| 06:55 |
VanessaE |
what am I looking for exactly? |
| 06:57 |
VanessaE |
I mean, this guy got full admin privs, as if someone did /grant <user> all |
| 06:58 |
nerzhul |
you should search for all privileges lua addition calls |
| 06:58 |
nerzhul |
from lua to engine i mean |
| 06:58 |
nerzhul |
(grep powa) |
| 06:58 |
VanessaE |
there was no entry in the debug log showing someone doing so, but his temporarily-successful attempts to strip ME of my privs were logged. |
| 06:58 |
nerzhul |
don't trust the log here |
| 06:58 |
nerzhul |
look at your code using grep |
| 07:02 |
VanessaE |
there's lots of registered privs, way too many to check every one of them |
| 07:08 |
Hijiri |
maybe override core.set_player_privs to write to the log? |
| 07:08 |
Hijiri |
then if your theory is wrong, you'll be able to tell whether the lua API was involved |
| 07:08 |
nerzhul |
i'm pushing an android build fix since recent red-002 work on main menu |
| 07:08 |
VanessaE |
seems to me that absolutely any chat commands being executed ought to be written to the log |
| 07:09 |
VanessaE |
except for setpassword |
| 07:14 |
Hijiri |
it might be something other than a chat command |
| 07:14 |
Hijiri |
/grant should be logged |
| 07:14 |
Hijiri |
if it's really bad it could be arbitrary lua execution, then you would need set_privileges to log |
| 07:15 |
Hijiri |
by should be I mean is in the code |
| 07:15 |
Hijiri |
not as in it would be good to put there |
| 07:15 |
Hijiri |
(though it's good that it is) |
| 07:15 |
Hijiri |
maybe you have some other chat command in mind though that might be sensitive to leak |
| 07:43 |
|
YuGiOhJCJ joined #minetest-dev |
| 07:49 |
|
kilbith joined #minetest-dev |
| 07:51 |
Hijiri |
oh shit |
| 07:51 |
Hijiri |
I think I know where the exploit is |
| 07:51 |
Hijiri |
not quit sure though |
| 07:59 |
nerzhul |
? |
| 08:00 |
nerzhul |
VanessaE, do you have worldedit_gui ? |
| 08:04 |
VanessaE |
not anymore |
| 08:07 |
Hijiri |
yeah that's where I saw it too |
| 08:08 |
nerzhul |
it's why mod_securitu should be enabled, to prevent those crap usages |
| 08:10 |
VanessaE |
wouldn't have helped -- mod security is already turned on on my servers. |
| 08:10 |
Hijiri |
well, it keeps it from turning into an exploit that can make your whole computer vulnerable |
| 08:11 |
Hijiri |
(assuming no way to break out of the mod security sandbox) |
| 08:11 |
VanessaE |
true, thank G*d |
| 08:17 |
|
Krock joined #minetest-dev |
| 08:17 |
|
Krock joined #minetest-dev |
| 08:29 |
|
cx384 joined #minetest-dev |
| 08:46 |
nerzhul |
merging #5752 in ~10 mins, thanks for the reviews :) |
| 08:46 |
ShadowBot |
https://github.com/minetest/minetest/issues/5752 -- Move KeyList & InputHandler from game.h to client/inputhandler.h by nerzhul |
| 08:46 |
VanessaE |
meanwhile, can someone please tell me the disposition of game#1732 > |
| 08:46 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/1732 -- redo new open chests to use all single textures by VanessaE |
| 08:46 |
VanessaE |
is this going to be merged or not? one way or the other, I need to know. |
| 08:48 |
|
davisonio left #minetest-dev |
| 08:48 |
|
davisonio joined #minetest-dev |
| 08:55 |
|
davisonio joined #minetest-dev |
| 09:04 |
nerzhul |
i send #5753 to fix #5026 problem, can you look at this tiny patch ? |
| 09:04 |
ShadowBot |
https://github.com/minetest/minetest/issues/5753 -- Limit properly the sound setting at updateSound runtime step by nerzhul |
| 09:04 |
ShadowBot |
https://github.com/minetest/minetest/issues/5026 -- sound_volume is not limited |
| 09:26 |
nerzhul |
merging #5753 in ~10 mins |
| 09:26 |
ShadowBot |
https://github.com/minetest/minetest/issues/5753 -- Limit properly the sound setting at updateSound runtime step by nerzhul |
| 09:33 |
|
lisac joined #minetest-dev |
| 09:50 |
|
Warr1024 joined #minetest-dev |
| 10:25 |
Krock |
Merging #1733 in 10 mins |
| 10:25 |
ShadowBot |
https://github.com/minetest/minetest/issues/1733 -- /home/minetest/Server/src/connection.cpp:2088: virtual void* con::ConnectionReceiveThread::Thread(): Assertion '0' failed. |
| 10:25 |
Krock |
game#1733 |
| 10:25 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/1733 -- Change the selection_box of bush stems by cx384 |
| 10:42 |
Zeno` |
I just got a message from the NSA and they are using it to create botnets |
| 10:43 |
red-002 |
I wonder was it all the same person |
| 10:43 |
red-002 |
someone finds an exploit and uses it on all the servers they can find |
| 10:44 |
Zeno` |
I think maybe the CIA are involved |
| 10:44 |
Zeno` |
I saw some Men In Black anyway |
| 10:45 |
Zeno` |
It's an easy fix. Just wear a black suit and dark sunglasses to confuse the MIB |
| 10:47 |
|
Fixer joined #minetest-dev |
| 11:01 |
red-002 |
for #5554 maybe it would be better to enable mods by default? |
| 11:01 |
ShadowBot |
https://github.com/minetest/minetest/issues/5554 -- [CSM] Allow enabling and disabling mods. by red-001 |
| 11:04 |
VanessaE |
disable by default, keep the same behavior as for server mods |
| 11:32 |
nerzhul |
merging android deps update #5755 (tested on my phone, it's perfect) |
| 11:32 |
ShadowBot |
https://github.com/minetest/minetest/issues/5755 -- Android dependencies updates by nerzhul |
| 11:39 |
kilbith |
https://hastebin.com/gesikocota.txt |
| 11:39 |
kilbith |
huh, wth |
| 11:39 |
kilbith |
what kind of unstable engine is that |
| 11:40 |
red-002 |
map block version got increased a while back |
| 11:41 |
kilbith |
so what about my old worlds |
| 11:41 |
kilbith |
I cannot play them |
| 11:42 |
red-002 |
it stops old versions from loading new worlds |
| 11:42 |
kilbith |
it's up-to-date with upsteam |
| 11:43 |
red-002 |
well maybe the world got corrupted some how does it also happen with other worlds? |
| 11:59 |
Krock |
sfan5, would you please be so nice and have a look at #5533 and test if you have some spare time? |
| 11:59 |
ShadowBot |
https://github.com/minetest/minetest/issues/5533 -- Sneak: Strip down version by SmallJoker |
| 11:59 |
Krock |
kilbith, have you tested some pulls recently? |
| 11:59 |
kilbith |
no |
| 12:02 |
Krock |
the last bump was in https://github.com/minetest/minetest/commit/071e114 |
| 12:03 |
Krock |
about 3 days ago |
| 12:05 |
kilbith |
I just pulled today |
| 12:22 |
|
jwheare joined #minetest-dev |
| 12:24 |
|
jwheare left #minetest-dev |
| 12:38 |
red-002 |
#5757 |
| 12:39 |
ShadowBot |
https://github.com/minetest/minetest/issues/5757 -- Improve password change menu by red-001 |
| 12:46 |
|
rubenwardy joined #minetest-dev |
| 12:50 |
|
davisonio left #minetest-dev |
| 12:55 |
|
paramat joined #minetest-dev |
| 13:18 |
|
Warr1024 joined #minetest-dev |
| 13:27 |
|
Darcidride joined #minetest-dev |
| 13:46 |
|
cx384 joined #minetest-dev |
| 13:48 |
|
Warr1024 joined #minetest-dev |
| 13:54 |
|
nerzhul joined #minetest-dev |
| 14:16 |
|
Warr1024 joined #minetest-dev |
| 14:22 |
|
Warr1024 joined #minetest-dev |
| 15:05 |
|
rubywarden joined #minetest-dev |
| 15:22 |
|
DS-minetest joined #minetest-dev |
| 15:30 |
nerzhul |
Krock, i think now you can merge #5754 when you want, both tested on UNIX & Windows |
| 15:30 |
ShadowBot |
https://github.com/minetest/minetest/issues/5754 -- No cursor lock when window inactive by SmallJoker |
| 15:31 |
Krock |
ack |
| 15:31 |
Krock |
rather trivial fix, thus, merging in 10 mins ^ |
| 15:49 |
|
rubywarden joined #minetest-dev |
| 15:59 |
|
troller joined #minetest-dev |
| 16:45 |
ShadowNinja |
The gateway/web quiet was a bit broad, since it includes irccloud, a bouncer service that isn't likely to have spam issues. |
| 16:48 |
|
davisonio joined #minetest-dev |
| 16:48 |
red-002 |
welcome back |
| 16:48 |
davisonio |
thanks |
| 17:21 |
red-002 |
updated #5757 |
| 17:21 |
ShadowBot |
https://github.com/minetest/minetest/issues/5757 -- Improve password change menu by red-001 |
| 17:21 |
red-002 |
(fixed random newlines) |
| 17:25 |
|
YuGiOhJCJ joined #minetest-dev |
| 17:33 |
|
Warr1024 joined #minetest-dev |
| 17:41 |
red-002 |
could someone review #5554? |
| 17:41 |
ShadowBot |
https://github.com/minetest/minetest/issues/5554 -- [CSM] Allow enabling and disabling mods. by red-001 |
| 17:44 |
Krock |
haven't tested it but +1 on the concept |
| 17:47 |
|
Warr1024 joined #minetest-dev |
| 17:48 |
rubenwardy |
red-002: does it add a menu, or is it only from the configuration? |
| 17:48 |
rubenwardy |
looks like the later |
| 17:48 |
rubenwardy |
*latter |
| 17:48 |
red-002 |
you would be correct |
| 17:49 |
rubenwardy |
ok, changed comment |
| 17:50 |
red-002 |
it would be pretty useful for anyone that is using csm right now |
| 17:51 |
red-002 |
makes it easy to disable the preview mod |
| 17:51 |
red-002 |
which tends to spam a good bit |
| 17:52 |
rubenwardy |
yeah |
| 18:04 |
ShadowNinja |
Alright, the developer meeting starts now. celeron55, nore, rubenwardy, sfan5, sofar, Krock: ping. Public meeting notes: http://sprunge.us/QQOa |
| 18:04 |
ShadowNinja |
Krock: any progress on #5647? |
| 18:04 |
ShadowBot |
https://github.com/minetest/minetest/issues/5647 -- Lua API: Add more inventory callbacks by SmallJoker |
| 18:05 |
Krock |
no sorry :/ would be glad if someone could take it over |
| 18:05 |
ShadowNinja |
We also need to make a decision on #1489. Opinions? |
| 18:05 |
ShadowBot |
https://github.com/minetest/minetest/issues/1489 -- Timed move by sapier |
| 18:06 |
Krock |
I'd say rebase |
| 18:06 |
VanessaE |
and game#1732 |
| 18:06 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/1732 -- redo new open chests to use all single textures by VanessaE |
| 18:06 |
ShadowNinja |
sofar: Are you around? If so, and opinions on the list_predict formspec item? (#1988) |
| 18:06 |
ShadowBot |
https://github.com/minetest/minetest/issues/1988 -- Fix #1374 by adding a listpredict piece to the formspec by MinerDad7 |
| 18:10 |
ShadowNinja |
(Hello, anyone else here?) |
| 18:10 |
Krock |
looks quite dead |
| 18:10 |
Krock |
VanessaE, testing now |
| 18:11 |
red-002 |
a bit offtopic but could someone add lables to 5757? |
| 18:12 |
red-002 |
labels* |
| 18:12 |
Krock |
any other? |
| 18:14 |
ShadowNinja |
Alright, well how about "New screenshots for website" (web#78) |
| 18:14 |
ShadowBot |
https://github.com/minetest/minetest.github.io/issues/78 -- Add better screenshots, and more screenshots |
| 18:15 |
ShadowNinja |
I think we should just assign someone to pick and install new screenshots. Opinions? |
| 18:15 |
Krock |
VanessaE, looks good to me. Works as expected |
| 18:16 |
|
paramat joined #minetest-dev |
| 18:17 |
Krock |
VanessaE, did you update the texture copyrights yet? I can't see them on your repo |
| 18:17 |
VanessaE |
Krock: no, forgot. |
| 18:17 |
VanessaE |
though they shouldn't change, they're still the old textures from before the UV-mapped chest? |
| 18:18 |
Krock |
will give +1 from my side once the old texture notices are removed and the new ones added |
| 18:18 |
* VanessaE |
looks |
| 18:18 |
Krock |
no, I mean the UV-mapped textures |
| 18:20 |
paramat |
nerzhul suggested we prioritise milestones for this and next meeting |
| 18:20 |
VanessaE |
Krock: how's that look? |
| 18:20 |
VanessaE |
(changed README) |
| 18:22 |
DS-minetest |
VanessaE: when digging a open chest, why isn't the crack texture overlay normal on the inside sides? |
| 18:22 |
Krock |
VanessaE, +1 |
| 18:22 |
VanessaE |
DS-minetest: that's an engine irrlicht issue |
| 18:22 |
Krock |
ShadowNinja, picking someone who has a good design knowledge is a good idea |
| 18:23 |
VanessaE |
I think the texture gets scaled to the size of the actual texture file first, rather than per-face |
| 18:23 |
DS-minetest |
ok |
| 18:23 |
VanessaE |
Krock: shall I squash? |
| 18:23 |
Krock |
since not all screenshots there are good candidates |
| 18:23 |
Krock |
VanessaE, can be squashed on merge |
| 18:23 |
VanessaE |
ok. |
| 18:23 |
ShadowNinja |
Krock: Yeah, of course. |
| 18:24 |
DS-minetest |
(btw pause menu has to be translated correctly, it's mixed now eg. mode:Einzelspieler) |
| 18:24 |
Krock |
but I don't know who's got time to look at all of them. We'll need a way to find volunteers |
| 18:24 |
ShadowNinja |
paramat: Any opinions on the PRs I've posted (We'll cover milestone stuff next). |
| 18:24 |
Krock |
DS-minetest, will be done in the next weblate update |
| 18:24 |
Krock |
we don't have much to do with the translations |
| 18:25 |
DS-minetest |
ok |
| 18:25 |
Krock |
the partwise translation is caused by words that are already contain in the dictionary when the pause menu change was done |
| 18:26 |
paramat |
ShadowNinja, i looked at logs, no comments for those |
| 18:26 |
DS-minetest |
yep, i just wanted that it isnt forgotten :) |
| 18:26 |
nore |
uhh the dev meeting, I'll look at bit but I'm quite tired |
| 18:26 |
nore |
1489: I'd say rebase |
| 18:27 |
Krock |
2x rebase, 1x cancel |
| 18:29 |
nore |
game 1732 is more neutral from me, while backwards compatibility is a important, extra flexibility is also good and we can't have both at the same time with how the engine works currently, so let's say +0.5 |
| 18:30 |
nore |
about screenshots: assigning someone (or a group of people) would be good I think; they don't have to be core devs but could just be a group of regular players |
| 18:30 |
paramat |
1732 doesn't actually improve compat |
| 18:31 |
paramat |
(see my comments) |
| 18:31 |
ShadowNinja |
How about Fix 'alpha' property for liquid nodes (#5494) |
| 18:31 |
ShadowBot |
https://github.com/minetest/minetest/issues/5494 -- Fix 'alpha' property for liquid nodes by juhdanad |
| 18:31 |
paramat |
just makes texturing easier as it's 16x16 instead of a texture map |
| 18:32 |
DS-minetest |
VanessaE: i think, the inside texture uvs should be turned |
| 18:32 |
VanessaE |
paramat: exactly. |
| 18:32 |
paramat |
oh 5494, i need to test that, will do |
| 18:32 |
ShadowNinja |
Also, CSM: Fix undocumented API calls (#5756) |
| 18:32 |
ShadowBot |
https://github.com/minetest/minetest/issues/5756 -- CSM: Document forgotten functions by SmallJoker |
| 18:32 |
VanessaE |
DS-minetest: I'll leave that up to whoever merges it; the textures are already "upright" |
| 18:33 |
VanessaE |
paramat: 16px single-tile textures should always be used wherever possible. texture maps should not be used if they aren't needed. |
| 18:34 |
paramat |
i was going to test 5494 anyway so consider me 'on it' |
| 18:34 |
DS-minetest |
IMO the the the texture should touch the other half where the open chest is connected |
| 18:35 |
VanessaE |
DS-minetest: you mean like a pair of hinges or something? |
| 18:35 |
DS-minetest |
yep |
| 18:35 |
paramat |
ah the insides texture, vertical would be clearer |
| 18:35 |
VanessaE |
I can change it to vertical if you want. |
| 18:36 |
DS-minetest |
i think, that would be better |
| 18:36 |
VanessaE |
ok |
| 18:36 |
VanessaE |
doing it now. |
| 18:36 |
paramat |
and applied so that the vertical appearence is what you see with a wide-opened chest |
| 18:37 |
DS-minetest |
btw, what is changed at top.png? |
| 18:38 |
VanessaE |
ok, vertical tiling implemented for the inside image |
| 18:38 |
VanessaE |
top.png should be unchanged, might need to run the images through pngcrush or something maybe |
| 18:39 |
Krock |
or just undo the change |
| 18:39 |
Krock |
that will ensure that git doesn't mark them as changed |
| 18:39 |
Krock |
s/them/it/ |
| 18:39 |
VanessaE |
I don't recall editing those images at all actually. |
| 18:40 |
VanessaE |
oh wait, it's not changed, it's just restored from deleted. |
| 18:42 |
Fixer |
about particles, very interesting |
| 18:42 |
|
kilbith joined #minetest-dev |
| 18:43 |
DS-minetest |
(crack also looks acceptable now) |
| 18:43 |
Fixer |
i connected to Hometown and particle count was >200 for very long time, i've reconnected and it suddenly dropped to 20-30 |
| 18:43 |
Fixer |
are there problems with particle expiration or something? |
| 18:44 |
Fixer |
this clearly need investigation |
| 18:44 |
Fixer |
if you want to check particle count, use this code: https://github.com/numberZero/minetest/commit/f2ada9784a1cfefb013b1b925e5b3b4404776483.diff |
| 18:44 |
paramat |
maybe something to do with particle spawners, i seem to remember some discussion about poor behaviour |
| 18:46 |
Fixer |
first connect to server, number of particles raises quickly and stabilises at 200-300, topping at 700 once iirc, now, I do quick restart and it goes back to 20-30 particles... this huge particle count may also be linked to my poor fps at times |
| 18:46 |
VanessaE |
someone needs to resurrect jin-xi's irrlicht particles work. |
| 18:46 |
Fixer |
coincidence. don't think so (c) |
| 18:46 |
|
rubenwardy joined #minetest-dev |
| 18:47 |
VanessaE |
with a decent GPU, you could have 10'000 particles on-screen and barely see a fps drop |
| 18:48 |
ShadowNinja |
rubenwardy: Any comments on any PRs I've mentioned? |
| 18:48 |
Fixer |
i know i repeated myself, but that was very suggestive to me that something is going on wrong |
| 18:51 |
rubenwardy |
particles are so unoptimised |
| 18:51 |
rubenwardy |
I don't know how they got merged in that state |
| 18:52 |
rubenwardy |
you need to batch particles when sending them to the GPU |
| 18:52 |
rubenwardy |
but our custom code uses an individual scene node per particle |
| 18:52 |
VanessaE |
wat |
| 19:03 |
VanessaE |
now, let's talk about the PB&J Pup again... |
| 19:04 |
VanessaE |
why not just put the mod back in, without the sounds or animated candies? |
| 19:04 |
kilbith |
oh no, not again... |
| 19:05 |
kilbith |
sorry Vanessa |
| 19:05 |
Fixer |
minetest crash when pressed /, msvcrt.dll related |
| 19:05 |
red-002 |
I would prefer to talk about sn*ak then that |
| 19:05 |
VanessaE |
fine :P |
| 19:06 |
DS-minetest |
there seems to be a invisible box as the upper part of the door |
| 19:08 |
paramat |
there's a narrow nodebox hidden in the hinged edge |
| 19:09 |
VanessaE |
I just don't understand why you guys hate that thing so much |
| 19:10 |
DS-minetest |
VanessaE: IMHO it doesn't really fir to minetset_game's style |
| 19:10 |
VanessaE |
neither did what it replaced :P |
| 19:14 |
|
kaeza joined #minetest-dev |
| 19:16 |
* DS-minetest |
doesn't understand, why is doors:hidden a nodebox? the collision box could be changed without that it's look (which is invisible :P) is changed) |
| 19:27 |
Krock |
hmm.. particles that don't expire |
| 19:27 |
Krock |
this memory issue should be fixed before 0.4.16 if possible |
| 19:28 |
Krock |
red-002, sn*ak? *triggered* |
| 19:58 |
red-002 |
could someone review #4962? |
| 19:58 |
ShadowBot |
https://github.com/minetest/minetest/issues/4962 -- Save the name of the world in world.mt and remove invalid characters from the directory name by red-001 |
| 20:00 |
red-002 |
at this rate I'm wondering if it will get merged at all |
| 20:05 |
|
Master_Kikou joined #minetest-dev |
| 20:07 |
|
Fritigern joined #minetest-dev |
| 20:12 |
Fixer |
if I get msvcrt.dll related minetest.exe crash, will I get useful backtrace in gdb? |
| 20:16 |
Krock |
hopefully there's a debug database around to produce helpful output |
| 20:52 |
paramat |
1 week until freeze :O |
| 21:51 |
red-002 |
#5757 also needs a bugfix lable |
| 21:51 |
ShadowBot |
https://github.com/minetest/minetest/issues/5757 -- Improve password change menu by red-001 |
| 21:51 |
red-002 |
label* |
| 21:54 |
|
proller__ joined #minetest-dev |
| 21:58 |
|
DI3HARD139 joined #minetest-dev |
| 22:02 |
Fixer |
so remember my permanent fps drop bug? I have a clue |
| 22:02 |
Fixer |
very probable reason is this: https://i.imgur.com/JWx8ran.png |
| 22:02 |
Fixer |
low fps along with it |
| 22:03 |
Fixer |
thats probably the main reason, huge amount of particles that decrease fps a lot |
| 22:04 |
Fixer |
i'm confident it is this |
| 22:04 |
Fixer |
vrange 20, looking at sky, barely 60 fps |
| 22:04 |
Fixer |
400 particles right now |
| 22:05 |
Fixer |
cpu bound |
| 22:07 |
Fixer |
is it possible to disable particles completely on client, i need this for testing? |
| 22:07 |
Fixer |
without ? |
| 22:16 |
paramat |
do you still get the problem with particles disabled in basic settings? |
| 22:16 |
Fixer |
enable_particles = false does not disable them completely I still get them in graph |
| 22:17 |
Fixer |
paramat: it is for dig particles only |
| 22:19 |
paramat |
i thought that checkbox disabled all particles |
| 22:20 |
|
rubenwardy joined #minetest-dev |
| 22:21 |
paramat |
oops i see the docs now |
| 22:21 |
Fixer |
i wonder if i can write simple lua mod that creates particles like TNT does and then just put second player and start increasing number to control FPS |
| 22:21 |
paramat |
yes |
| 22:22 |
Fixer |
i will be in another part of map ofc |
| 22:22 |
Fixer |
paramat: actually i can use your weather mod =] |
| 22:23 |
Fixer |
paramat: the trick is to use two players, one with rain particles, another - without, standing far away |
| 22:23 |
Fixer |
since particles are rendered for everybody |
| 22:23 |
paramat |
precipitation is guaranteed to be disabled in any desert |
| 22:23 |
Fixer |
paramat: how is that mod named? |
| 22:24 |
paramat |
https://github.com/paramat/snowdrift |
| 22:24 |
paramat |
just do not use in mgv6, not compatible |
| 22:28 |
paramat |
and you can edit mod settings to make rain/snow continuous for the other player .. |
| 22:29 |
Fixer |
too dumb |
| 22:29 |
paramat |
local PRECOFF = 10 |
| 22:29 |
paramat |
easy |
| 22:29 |
Fixer |
searching for desert |
| 22:29 |
paramat |
heh good luck |
| 22:30 |
paramat |
and of course edit FLAKES and DROPS to alter number of particles |
| 22:31 |
Fixer |
hmmm https://i.imgur.com/bTe3sM3.png |
| 22:32 |
Fixer |
g_profiler->graphAdd("particles", m_particles.size()); |
| 22:32 |
paramat |
mod creates a batch of particles every 0.5s |
| 22:33 |
paramat |
the overlap of the cycles creates the spike to 320 |
| 22:34 |
paramat |
any effect by facing away from the other player? |
| 22:37 |
Fixer |
paramat: your mod does not render entities for other people |
| 22:37 |
Fixer |
interesting |
| 22:37 |
Fixer |
let me use some tnt |
| 22:37 |
|
Icedream joined #minetest-dev |
| 22:38 |
paramat |
yes because of 'playername = player:get_player_name()' |
| 22:38 |
Fixer |
tnt disabled :S |
| 22:38 |
Fixer |
sigh |
| 22:38 |
paramat |
try commenting that out |
| 22:38 |
Fixer |
ok |
| 22:38 |
paramat |
.. in 'add particle' |
| 22:39 |
Fixer |
ready |
| 22:39 |
Fixer |
lets try |
| 22:40 |
paramat |
obviously many mods show particles to all players, but a distance limit is needed |
| 22:40 |
Fixer |
tnt is enabled in settings but not in game? o.O |
| 22:41 |
Fixer |
paramat: yes, detecting particles now |
| 22:41 |
Fixer |
from desert |
| 22:42 |
Fixer |
https://i.imgur.com/wH0nDqY.png |
| 22:42 |
Fixer |
fps jitters a lot on server due to particles |
| 22:43 |
Fixer |
let me increase amount |
| 22:43 |
Fixer |
local DROPS = 128 |
| 22:44 |
Fixer |
paramat: yes it does strongly influence fps |
| 22:45 |
Fixer |
https://i.imgur.com/ALaqHBW.png |
| 22:55 |
paramat |
good work |
| 22:55 |
paramat |
this really needs fixing, i think it is high priority |
| 22:56 |
Fixer |
another question is why when I reconnect 400 particles washes away into 20, despawn problems? |
| 22:57 |
paramat |
not sure, particles should not persist to another game session |
| 22:57 |
Fixer |
they don't |
| 22:59 |
paramat |
added blocker label |
| 22:59 |
paramat |
should be straightforward to fix, hopefully |
| 23:00 |
paramat |
added to milestone |
| 23:02 |
paramat |
and facing away from other player does not help? |
| 23:02 |
Fixer |
nope, still renders |
| 23:03 |
Fixer |
i don't think it is a blocker, it does not really hold release, but will be nice to fix |
| 23:04 |
paramat |
seems a huge issue to me |
| 23:05 |
Fixer |
hmmm |
| 23:07 |
Fixer |
paramat: basicly it draws same amount of particles for everybody |
| 23:07 |
Fixer |
if someone joins and have rain with 1000 particle... well you will have them too :D |
| 23:08 |
Fixer |
https://i.imgur.com/eIEu6ey.png |
| 23:08 |
Hijiri |
for that case you could use a spawner with the player option set |
| 23:09 |
Hijiri |
if you want to attach the weather spawner to a player you probably want to anyway to avoid overlapping rains |
| 23:09 |
Fixer |
my guy leaves rain zone = particle count drops to 0 :} |
| 23:09 |
Fixer |
for everyone |
| 23:10 |
Fixer |
top kek |
| 23:10 |
Fixer |
lets move away from this topic and look at TNT |
| 23:11 |
rom1504 |
boom |
| 23:11 |
Fixer |
paramat: where is TNT in singleplayer? i see only gun powder |
| 23:11 |
Fixer |
paramat: close to newest mtg |
| 23:12 |
Fixer |
hold on |
| 23:12 |
Fixer |
it is disabled here |
| 23:17 |
Fixer |
-------- |
| 23:17 |
Fixer |
clean install |
| 23:17 |
Fixer |
in settings TNT is enabled |
| 23:18 |
Fixer |
appears in singleplayer |
| 23:18 |
Fixer |
appears on server |
| 23:18 |
Fixer |
very strange |
| 23:23 |
Fixer |
not strange anymore, probably messed up my config, so it did not appear in inventory, now it does |
| 23:24 |
paramat |
https://github.com/minetest/minetest/blob/master/src/server.cpp#L1702 |
| 23:24 |
paramat |
"// This sucks and should be replaced by a better solution in a refactor:" |
| 23:24 |
paramat |
that is where particles are sent to all clients, no check on distance |
| 23:29 |
Fixer |
yeah |
| 23:30 |
Fixer |
posted nice screenshot over there |
| 23:36 |
Hijiri |
any reviewers for #5612 |
| 23:36 |
Fixer |
so probably source of that low fps drop is confirmed (particles), that fps drop appared to me on hometown only that also suggests particles, only thing what i need to catch is rare crash in some way related to chat opening (?) |
| 23:36 |
ShadowBot |
https://github.com/minetest/minetest/issues/5612 -- Allow overriding tool capabilities through itemstack metadata by raymoo |
| 23:37 |
Fixer |
instadig should be fixed before release |
| 23:54 |
paramat |
yes |
