| Time |
Nick |
Message |
| 00:51 |
rubenwardy |
rebased #4713 |
| 00:51 |
ShadowBot |
https://github.com/minetest/minetest/issues/4713 -- Add on_grant and on_revoke callbacks by rubenwardy |
| 01:06 |
|
bigfoot547 joined #minetest-dev |
| 01:06 |
rubenwardy |
red-001, you have quite a few useful PRs open :) |
| 01:22 |
|
silwol joined #minetest-dev |
| 01:27 |
|
silwol joined #minetest-dev |
| 01:49 |
VanessaE |
what's the disposition of https://github.com/minetest/minetest_game/pull/1826 ? |
| 01:50 |
VanessaE |
I can't test it - I don't track dev/git for my mods anymore, so I'm waiting for the next release. |
| 01:56 |
rubenwardy |
:( |
| 02:06 |
|
DI3HARD139 joined #minetest-dev |
| 02:14 |
VanessaE |
that also applies to #6042 |
| 02:14 |
ShadowBot |
https://github.com/minetest/minetest/issues/6042 -- Make dropped items colorable by juhdanad |
| 02:14 |
VanessaE |
I need these merged before 0.4.17 release cycle starts |
| 02:16 |
rubenwardy |
oh, that's lua only |
| 02:16 |
rubenwardy |
I thought it was C++ rendering |
| 02:17 |
rubenwardy |
which isn't something I know much about, which is why I skipped that PR |
| 02:17 |
rubenwardy |
anyway, I best sleep |
| 02:17 |
VanessaE |
no worries, rubenwardy |
| 02:17 |
VanessaE |
night |
| 02:31 |
|
Tmanyo joined #minetest-dev |
| 04:28 |
|
ssieb joined #minetest-dev |
| 06:17 |
|
Hunterz joined #minetest-dev |
| 07:08 |
sofar |
merging game#1869 |
| 07:08 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/1869 -- [Trivial] Make furnace info text look nicer by JRottm |
| 07:09 |
|
DI3HARD139 joined #minetest-dev |
| 07:29 |
|
Krock joined #minetest-dev |
| 08:02 |
|
RichardTheTurd joined #minetest-dev |
| 09:05 |
|
fwhcat joined #minetest-dev |
| 10:45 |
|
Fixer joined #minetest-dev |
| 11:27 |
Krock |
Merging game#1859 game#1868 game#1871 and game#1872 in 15 minutes |
| 11:27 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/1859 -- default_desert_cobble.png with darker mortar by TumeniNodes |
| 11:27 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/1868 -- TNT's tnt:boom cleanup by tenplus1 |
| 11:27 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/1871 -- Boats: Fix player position by Rui-Minetest |
| 11:27 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/1872 -- Carts: Fix player position by Rui-Minetest |
| 11:37 |
|
Warr1024 joined #minetest-dev |
| 12:30 |
|
paramat joined #minetest-dev |
| 12:43 |
paramat |
can anyone approve #4703 and we go with 'special'? i might just merge it as trivial |
| 12:43 |
ShadowBot |
https://github.com/minetest/minetest/issues/4703 -- Rename “Use†key to “Special†by Wuzzy2 |
| 12:45 |
sfan5 |
sounds fine to me |
| 12:47 |
paramat |
great, it's the word most consistent with existing code |
| 12:51 |
paramat |
is anyone +1 on #6042 if i fix the code style on merge? seems to be only minor code style delaying it |
| 12:51 |
ShadowBot |
https://github.com/minetest/minetest/issues/6042 -- Make dropped items colorable by juhdanad |
| 12:52 |
|
YuGiOhJCJ joined #minetest-dev |
| 12:53 |
paramat |
#5918 is actually quite trivial, i might merge it later |
| 12:53 |
ShadowBot |
https://github.com/minetest/minetest/issues/5918 -- L-system: Fix leaves cutting through stems by HybridDog |
| 14:15 |
|
zorman2000 joined #minetest-dev |
| 14:16 |
|
MoNTE48 joined #minetest-dev |
| 14:16 |
|
paramat joined #minetest-dev |
| 15:32 |
|
DI3HARD139 joined #minetest-dev |
| 16:17 |
|
Natechip joined #minetest-dev |
| 16:18 |
|
Natechip joined #minetest-dev |
| 16:41 |
|
paramat joined #minetest-dev |
| 16:46 |
|
nerzhul joined #minetest-dev |
| 16:55 |
|
Player_2 joined #minetest-dev |
| 18:03 |
|
Beton joined #minetest-dev |
| 18:03 |
|
Beton joined #minetest-dev |
| 18:10 |
|
lisac joined #minetest-dev |
| 18:18 |
paramat |
#6247 easy and quick to make the advanced setting menu much easier to use, mapgen done |
| 18:18 |
ShadowBot |
https://github.com/minetest/minetest/issues/6247 -- Settingtypes.txt: Separate and re-organise mapgen settings by paramat |
| 18:19 |
|
torgdor joined #minetest-dev |
| 18:21 |
paramat |
to avoid conflicts i'll merge that asap a few hours from now, if no objections |
| 18:26 |
paramat |
but |
| 18:26 |
paramat |
i'll merge a bunch of engine PRs first in case my PR causes conflicts for those |
| 18:27 |
paramat |
there are 5 with 2 approvals, will merge those in an hour if no-one else has |
| 18:48 |
|
YuGiOhJCJ joined #minetest-dev |
| 19:15 |
|
bigfoot547 joined #minetest-dev |
| 19:37 |
|
CalebDavis joined #minetest-dev |
| 19:51 |
|
paramat joined #minetest-dev |
| 20:00 |
|
Wuzzy joined #minetest-dev |
| 20:01 |
Wuzzy |
Quote: “The schematic documentation is really horrible.†Is this true? |
| 20:01 |
Wuzzy |
https://github.com/octacian/advschem/issues/1#issuecomment-322047723 |
| 20:01 |
paramat |
erm |
| 20:01 |
Wuzzy |
octarian claims that the docs are false about the meaning of schematic node probability 0-255 |
| 20:01 |
Wuzzy |
WTF? |
| 20:01 |
paramat |
ah |
| 20:01 |
paramat |
possibly |
| 20:01 |
Wuzzy |
O_O |
| 20:02 |
Wuzzy |
so probability 127 does not equal 50%? O_O |
| 20:02 |
paramat |
i need to double check, octacian and i were discussing exactly this a while back |
| 20:02 |
Wuzzy |
wow |
| 20:03 |
Wuzzy |
note there actually is is a "force_placement" boolean |
| 20:05 |
paramat |
actually i suspect the docs are right, see our discussion a while back, i can't remember our conclusions |
| 20:05 |
paramat |
btw slippery needs 2 small code style fixes |
| 20:06 |
paramat |
if you fix that now i'll merge it |
| 20:06 |
paramat |
i'm about to merge 3 others |
| 20:06 |
Wuzzy |
i didnt know you can merge without the magical 2 approvals first :D |
| 20:07 |
paramat |
it has 2 |
| 20:07 |
Wuzzy |
oh |
| 20:07 |
Wuzzy |
awesome |
| 20:08 |
Wuzzy |
what linter did you use btw? |
| 20:08 |
paramat |
i'll merge #4703 #4735 #6232 and hopefully #6237 in a few mins |
| 20:08 |
ShadowBot |
https://github.com/minetest/minetest/issues/4703 -- Rename “Use†key to “Special†by Wuzzy2 |
| 20:08 |
ShadowBot |
https://github.com/minetest/minetest/issues/4735 -- Add short description for disabled texture packs by Wuzzy2 |
| 20:08 |
ShadowBot |
https://github.com/minetest/minetest/issues/6232 -- Trigger on_rightclick regardless on the formspec meta field by SmallJoker |
| 20:08 |
paramat |
no idea, the built in one |
| 20:08 |
ShadowBot |
https://github.com/minetest/minetest/issues/6237 -- Add slippery group for nodes (players/items slide) (take 3) by Wuzzy2 |
| 20:09 |
Wuzzy |
paramat: will u merge 6237 even without me squashing everything? |
| 20:09 |
VanessaE |
#6042 also? :) |
| 20:09 |
paramat |
it shows up as a travis failure |
| 20:09 |
ShadowBot |
https://github.com/minetest/minetest/issues/6042 -- Make dropped items colorable by juhdanad |
| 20:09 |
VanessaE |
(I'm gonna keep harassing people until it's merged :P ) |
| 20:09 |
paramat |
erm, a squash would be nice if you can |
| 20:10 |
paramat |
sfan5 if i fix the minor code style issues on merge do you +1 6042? |
| 20:12 |
paramat |
anyway 6042 seems close to a merge |
| 20:12 |
|
Raven262 joined #minetest-dev |
| 20:14 |
Wuzzy |
coding style fixed are on the way... i am currently re-compiling cuz I'm paranoid. |
| 20:19 |
paramat |
it's good to check |
| 20:26 |
Wuzzy |
paramat: ready. |
| 20:28 |
paramat |
thanks |
| 20:30 |
paramat |
ok will merge all 4 now |
| 20:39 |
|
Megaf joined #minetest-dev |
| 20:48 |
|
lisac joined #minetest-dev |
| 20:49 |
paramat |
all done |
| 20:50 |
VanessaE |
not all ;) |
| 20:53 |
nerzhul |
all correctly approved done* |
| 20:55 |
VanessaE |
:P |
| 20:55 |
nerzhul |
ouch |
| 20:55 |
nerzhul |
slippery PR is ugly |
| 20:56 |
nerzhul |
void LocalPlayer::applyControl(float dtime, ClientEnvironment *env) |
| 20:56 |
nerzhul |
this proto is bad |
| 20:58 |
nerzhul |
i'm pushing a cleanup on this function proto in 5-10 mins |
| 21:03 |
paramat |
nice |
| 21:03 |
nerzhul |
d_wanted = target_speed * 0.1f - m_speed * 0.1f; |
| 21:03 |
nerzhul |
i also factorize this calcul on another commit |
| 21:03 |
nerzhul |
oh better |
| 21:04 |
nerzhul |
v3f d_wanted = target_speed - m_speed; |
| 21:04 |
nerzhul |
d_wanted *= 0.1f |
| 21:04 |
nerzhul |
it' s already calculated |
| 21:05 |
paramat |
i'm trying to auto-generate conf.example but get 'ERROR[Main]: ...n/../builtin/mainmenu/generate_from_settingtypes.lua:96: src/settings_translation_file.cpp: No such file or directory' |
| 21:05 |
nerzhul |
are you in the right folder ? maybe it works only in RUN_IN_PLACE ? |
| 21:06 |
paramat |
i have a run in place build |
| 21:07 |
paramat |
this actually happened tome before but i can't remember the fix |
| 21:07 |
paramat |
* to me |
| 21:08 |
nerzhul |
i never used it sorry |
| 21:08 |
paramat |
no problem. rubenwardy? |
| 21:08 |
nerzhul |
factorization pushed |
| 21:09 |
paramat |
i remember there was a simple solution |
| 21:10 |
paramat |
ok, solved by force :] |
| 21:12 |
paramat |
hm didn't work .. |
| 21:17 |
paramat |
nuts, this is meant to be easy but there's an undocumented trick to it, will search back in github |
| 21:18 |
nerzhul |
paramat, dev wiki ? |
| 21:21 |
paramat |
will look |
| 21:26 |
paramat |
ah solved |
| 21:27 |
paramat |
had to search through IRC dev channel logs, the files are written into my bin folder |
| 21:29 |
paramat |
i'll add a comment about this for next time |
| 21:31 |
nerzhul |
update dev wiki it can help everybody |
| 21:46 |
Wuzzy |
nerzhul: paramat does not have dev wiki account yet ... |
| 21:47 |
Wuzzy |
so, paramat, how is the schematic probability REALLY defined? |
| 21:52 |
paramat |
looking for the discussion |
| 21:53 |
Wuzzy |
thx |
| 21:58 |
paramat |
added links to your issue, looks like docs may be right |
| 22:02 |
|
Lone-Star joined #minetest-dev |
| 22:05 |
|
fwhcat joined #minetest-dev |
| 22:06 |
Lone-Star |
I have made a few edits to the default fence, how can I take that and make a separate mod? |
| 22:06 |
|
proller joined #minetest-dev |
| 22:16 |
rubenwardy |
Lone-Star, -> #minetest |
| 22:16 |
rubenwardy |
(I'll answer you there) |
| 22:22 |
paramat |
#6247 is ready to go but i'll merge tomorrow, too tired |
| 22:22 |
ShadowBot |
https://github.com/minetest/minetest/issues/6247 -- Settingtypes.txt: Separate and re-organise mapgen settings by paramat |
| 22:40 |
nerzhul |
i'm pushing another little patchset on for loop C++11 style |
| 22:40 |
nerzhul |
(on server step function) |
| 23:04 |
nerzhul |
pushing a second for-loop/stl usage patchset in server.cpp (+ various codestyle on path) |
| 23:04 |
nerzhul |
(many issues reported by clang-tidy hopefully) |
| 23:05 |
nerzhul |
somes will enhance a little bit performance, tiny but easy-win |
| 23:08 |
|
CalebDavis joined #minetest-dev |
