| Time |
Nick |
Message |
| 00:02 |
rubenwardy |
It may be worth discussing cleaning up player related flags |
| 00:03 |
rubenwardy |
we currently have HUD flags, player object properties, and privileges |
| 00:05 |
paramat |
oh crumbs, it needs a lot of justification though |
| 00:05 |
paramat |
it works ok so why? |
| 00:06 |
rubenwardy |
it may be worth making HUD flags just flags |
| 00:07 |
rubenwardy |
means you can reuse the sending code |
| 00:08 |
paramat |
ok, no harm discussing |
| 00:09 |
rubenwardy |
it's best to do this before 0.5, to not break zoom and minimap too much |
| 00:10 |
paramat |
yes, consider now is best, but it needs a reason |
| 00:11 |
rubenwardy |
makes it easier to add flag like properties in the future |
| 00:12 |
rubenwardy |
should reduce code |
| 00:13 |
|
Fritigern joined #minetest-dev |
| 00:51 |
|
Tmanyo joined #minetest-dev |
| 01:50 |
|
ThomasMonroe joined #minetest-dev |
| 01:53 |
|
paramat joined #minetest-dev |
| 01:54 |
paramat |
will merge game#1911 in a moment |
| 01:54 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/1911 -- Map mod: Remove confusing 'use', reduce update interval by paramat |
| 02:05 |
paramat |
done |
| 02:51 |
|
troller joined #minetest-dev |
| 04:34 |
|
jordan4ibanez joined #minetest-dev |
| 05:15 |
|
Hunterz joined #minetest-dev |
| 05:43 |
|
nerzhul joined #minetest-dev |
| 06:15 |
Hijiri |
#5612 just needs one more approval |
| 06:15 |
ShadowBot |
https://github.com/minetest/minetest/issues/5612 -- Allow overriding tool capabilities through itemstack metadata by raymoo |
| 07:37 |
|
AntumDeluge joined #minetest-dev |
| 07:40 |
|
Krock joined #minetest-dev |
| 07:47 |
|
nerzhul joined #minetest-dev |
| 07:48 |
|
AntumDeluge joined #minetest-dev |
| 08:02 |
|
nerzhul joined #minetest-dev |
| 08:47 |
|
nerzhul joined #minetest-dev |
| 08:49 |
|
Krock joined #minetest-dev |
| 09:03 |
|
proller joined #minetest-dev |
| 09:31 |
|
ThomasMonroe joined #minetest-dev |
| 09:35 |
|
ThomasMonroe joined #minetest-dev |
| 09:59 |
|
Krock joined #minetest-dev |
| 10:01 |
|
YuGiOhJCJ joined #minetest-dev |
| 10:22 |
|
Fixer joined #minetest-dev |
| 10:32 |
|
CalebDavis joined #minetest-dev |
| 11:25 |
|
Gundul joined #minetest-dev |
| 11:31 |
|
lisac joined #minetest-dev |
| 11:46 |
|
Wuzzy joined #minetest-dev |
| 11:51 |
|
ThomasMonroe joined #minetest-dev |
| 12:36 |
|
troller joined #minetest-dev |
| 12:59 |
|
Raven262 joined #minetest-dev |
| 13:28 |
|
antims joined #minetest-dev |
| 13:40 |
|
Raven262 joined #minetest-dev |
| 14:22 |
|
ThomasMonroe joined #minetest-dev |
| 14:33 |
|
srifqi joined #minetest-dev |
| 14:55 |
|
troller joined #minetest-dev |
| 15:08 |
|
Darcidride joined #minetest-dev |
| 15:16 |
|
Hunterz joined #minetest-dev |
| 15:23 |
|
troller joined #minetest-dev |
| 15:33 |
|
YuGiOhJCJ joined #minetest-dev |
| 16:04 |
|
paramat joined #minetest-dev |
| 16:12 |
|
troller joined #minetest-dev |
| 16:55 |
|
troller joined #minetest-dev |
| 17:10 |
|
t7 joined #minetest-dev |
| 17:11 |
|
t7_ joined #minetest-dev |
| 17:14 |
|
troller joined #minetest-dev |
| 17:14 |
|
cx384 joined #minetest-dev |
| 17:19 |
|
DTA7 joined #minetest-dev |
| 17:21 |
DTA7 |
Is it ok to make a setting variable thread_local? |
| 17:21 |
DTA7 |
Like in https://github.com/minetest/minetest/blob/4e19791cde6b203ad853905d8c1481c43004a7ea/src/mapblock_mesh.cpp#L259-L260 |
| 17:22 |
sfan5 |
yes |
| 17:23 |
DTA7 |
Ok, thanks |
| 17:30 |
paramat |
on that subject. in rapidly used code, is 'static const thing = g_settings->get..()' just as optimal as using a cache variable that does 'g_settings->get..()' once outside the rapidly used code? |
| 17:32 |
DTA7 |
Yes, it is only initialized once per thread |
| 17:34 |
DTA7 |
http://en.cppreference.com/w/cpp/language/storage_duration |
| 17:35 |
DTA7 |
In the section "Static local variables" |
| 17:38 |
DTA7 |
(with thread_local I mean, otherwise once per program) |
| 17:48 |
paramat |
yea i know, but i was wondering if despite that one is slightly more optimal than the other |
| 17:51 |
|
jordan4ibanez joined #minetest-dev |
| 18:08 |
|
ThomasMonroe joined #minetest-dev |
| 18:09 |
|
DTA7 joined #minetest-dev |
| 18:15 |
|
nerzhul joined #minetest-dev |
| 18:15 |
|
t7 joined #minetest-dev |
| 18:15 |
|
Puka joined #minetest-dev |
| 18:32 |
DTA7 |
Oh ok, I don't know, where else would you cache the setting? |
| 18:39 |
|
Krock joined #minetest-dev |
| 18:40 |
|
Krock joined #minetest-dev |
| 19:09 |
|
t7 joined #minetest-dev |
| 19:15 |
|
troller joined #minetest-dev |
| 19:38 |
paramat |
dunno :} |
| 19:54 |
|
DTA7 joined #minetest-dev |
| 20:24 |
|
bigfoot547 joined #minetest-dev |
| 20:24 |
|
bigfoot547 joined #minetest-dev |
| 20:27 |
|
bigfoot547 joined #minetest-dev |
| 20:39 |
|
proller joined #minetest-dev |
| 20:43 |
|
troller joined #minetest-dev |
| 21:02 |
|
ThomasMonroe joined #minetest-dev |
| 21:12 |
|
Fixer joined #minetest-dev |
| 22:08 |
|
johnnyjoy joined #minetest-dev |
| 22:49 |
|
troller joined #minetest-dev |
| 23:09 |
|
troller joined #minetest-dev |
| 23:10 |
|
Natechip joined #minetest-dev |
| 23:13 |
|
troller joined #minetest-dev |
| 23:21 |
|
troller joined #minetest-dev |
| 23:23 |
|
AntumD joined #minetest-dev |
| 23:26 |
|
troller joined #minetest-dev |
| 23:28 |
|
AntumDeluge joined #minetest-dev |
| 23:29 |
|
troller joined #minetest-dev |
| 23:32 |
|
troller joined #minetest-dev |
| 23:36 |
|
troller joined #minetest-dev |
| 23:41 |
|
troller joined #minetest-dev |
