| Time |
Nick |
Message |
| 00:00 |
|
EvergreenTree joined #minetest-dev |
| 00:09 |
|
Darcidride joined #minetest-dev |
| 01:04 |
|
BakerPrime joined #minetest-dev |
| 01:42 |
|
^v joined #minetest-dev |
| 01:45 |
|
EvergreenTree joined #minetest-dev |
| 01:55 |
|
sfan5 joined #minetest-dev |
| 02:01 |
|
Sockbat joined #minetest-dev |
| 02:34 |
|
nepugia joined #minetest-dev |
| 02:54 |
|
EvergreenTree joined #minetest-dev |
| 03:30 |
|
Robby joined #minetest-dev |
| 03:31 |
|
crazyR joined #minetest-dev |
| 03:32 |
|
davisonio joined #minetest-dev |
| 03:32 |
|
popey joined #minetest-dev |
| 03:33 |
|
fireglow joined #minetest-dev |
| 03:36 |
|
Sockbat joined #minetest-dev |
| 04:18 |
|
dzho_ joined #minetest-dev |
| 04:21 |
|
dzho_ joined #minetest-dev |
| 04:48 |
|
Darcidride_ joined #minetest-dev |
| 04:48 |
|
Darcidride__ joined #minetest-dev |
| 04:58 |
|
dzho joined #minetest-dev |
| 05:19 |
|
Sokomine joined #minetest-dev |
| 06:26 |
|
nerzhul joined #minetest-dev |
| 07:12 |
|
Lone-Star joined #minetest-dev |
| 08:48 |
|
nerzhul joined #minetest-dev |
| 12:30 |
|
Fixer joined #minetest-dev |
| 12:45 |
|
Lunatrius joined #minetest-dev |
| 13:00 |
|
CBugDCoder joined #minetest-dev |
| 13:35 |
|
nerzhul joined #minetest-dev |
| 13:49 |
|
YuGiOhJCJ joined #minetest-dev |
| 14:07 |
|
antims joined #minetest-dev |
| 14:18 |
|
YuGiOhJCJ joined #minetest-dev |
| 14:39 |
|
twoelk joined #minetest-dev |
| 14:43 |
|
lisac_ joined #minetest-dev |
| 14:48 |
|
Raven262 joined #minetest-dev |
| 15:03 |
|
Fixer joined #minetest-dev |
| 15:10 |
|
RobbieF joined #minetest-dev |
| 15:11 |
|
RobbieF left #minetest-dev |
| 16:29 |
|
CBugDCoder joined #minetest-dev |
| 16:43 |
|
dzho joined #minetest-dev |
| 17:05 |
|
Gael-de-Sailly joined #minetest-dev |
| 17:09 |
|
EvergreenTree joined #minetest-dev |
| 17:26 |
|
Krock joined #minetest-dev |
| 17:35 |
|
YuGiOhJCJ joined #minetest-dev |
| 17:59 |
|
YuGiOhJCJ joined #minetest-dev |
| 18:23 |
|
Darcidride joined #minetest-dev |
| 18:33 |
|
numzero joined #minetest-dev |
| 18:34 |
nerzhul |
Krock, hello, i fixed your points on #6884 & rebased :) |
| 18:34 |
ShadowBot |
https://github.com/minetest/minetest/issues/6884 -- Game refactor: reduce game.cpp size by moving objects in the right places by nerzhul |
| 18:39 |
Krock |
nerzhul, okay. There is no rule for how many indents there should be for each new line of a function parameter list, so I wonder why you re-formatted some of them |
| 18:39 |
Krock |
same for other multi-line instructions |
| 18:40 |
nerzhul |
Krock, oh i let clang-format doing the boring work on compatible files for me as they respect our rules :p |
| 18:41 |
Krock |
the changes look good, will wait for Travis to finish |
| 19:11 |
Krock |
nerzhul, clang, FREETYPE=0 failed |
| 19:13 |
|
bigfoot548 joined #minetest-dev |
| 19:17 |
nerzhul |
Krock, ty i will look later :) |
| 19:32 |
|
Fixer joined #minetest-dev |
| 19:50 |
pgimeno |
nerzhul: about your review: I'm afraid of backwards compatibility consequences if using unordered_map instead of map. The original code used set, not unordered_set, and that order influences what gets passed to addMods. |
| 19:51 |
pgimeno |
If I deciphered properly the algorithm used by addMods, then I think that the only consequence would be differences in the logs, but I'm not 100% sure. |
| 19:52 |
pgimeno |
In particular, I'm not sure what happens when the game or the world has a conflicting mod or modpack. |
| 19:54 |
pgimeno |
If you've checked that and think it's safe, then I'll go ahead and change it. |
| 20:01 |
pgimeno |
Actually, scratch that. I was confusing it with addon_mods_in_path. |
| 20:01 |
|
Fixer joined #minetest-dev |
| 20:02 |
pgimeno |
The only potential consequence is that the order in which they are reported when not found may not be alphabetical. |
| 20:15 |
|
CBugDCoder joined #minetest-dev |
| 20:28 |
|
Fixer joined #minetest-dev |
| 21:14 |
|
Gael-de-Sailly joined #minetest-dev |
| 21:41 |
|
fwhcat joined #minetest-dev |
| 21:56 |
|
twoelk left #minetest-dev |
| 22:04 |
|
Xio joined #minetest-dev |
| 22:23 |
|
ThomasMonroe joined #minetest-dev |
| 22:28 |
|
EvergreenTree joined #minetest-dev |
| 23:39 |
|
Tmanyo joined #minetest-dev |
