| Time |
Nick |
Message |
| 00:00 |
|
paramat joined #minetest-dev |
| 00:36 |
|
torgdor joined #minetest-dev |
| 01:56 |
|
paramat joined #minetest-dev |
| 02:57 |
paramat |
will merge #7135 #7136 in a few mins, both trivial |
| 02:57 |
ShadowBot |
https://github.com/minetest/minetest/issues/7135 -- Biomes: Fix vertical blend by paramat |
| 02:57 |
ShadowBot |
https://github.com/minetest/minetest/issues/7136 -- Lua_api.txt: Split long lines part 5, fix hardware colouring docs by paramat |
| 03:01 |
paramat |
merging |
| 03:04 |
|
BakerPrime joined #minetest-dev |
| 03:05 |
paramat |
done |
| 03:12 |
|
Cornelia joined #minetest-dev |
| 03:44 |
|
AndroBuilder joined #minetest-dev |
| 06:22 |
|
__vy joined #minetest-dev |
| 07:18 |
nerzhul |
paramat, where is the approval for the fix ? |
| 07:39 |
nerzhul |
i push a trivial if -> else if fix on master |
| 07:40 |
|
troller joined #minetest-dev |
| 07:41 |
nerzhul |
merging #7131 (approved by Krock yesterday, the change has been added) |
| 07:41 |
ShadowBot |
https://github.com/minetest/minetest/issues/7131 -- Server: delegate mod management & config to ServerModConfiguration by nerzhul |
| 07:52 |
|
troller joined #minetest-dev |
| 08:11 |
nerzhul |
i push a little trivial refactor for ServerEnv::loadmeta (default should be handled by server env itself) |
| 08:16 |
|
Raven262 joined #minetest-dev |
| 08:16 |
|
lisac joined #minetest-dev |
| 09:17 |
|
corvus_ joined #minetest-dev |
| 09:18 |
|
lisac_ joined #minetest-dev |
| 09:32 |
|
lisac_ joined #minetest-dev |
| 09:38 |
|
Raven262 joined #minetest-dev |
| 09:41 |
|
corvus_ joined #minetest-dev |
| 09:41 |
|
lisac__ joined #minetest-dev |
| 09:53 |
|
Fixer joined #minetest-dev |
| 10:00 |
|
book` joined #minetest-dev |
| 12:04 |
|
proller joined #minetest-dev |
| 12:09 |
|
Wuzzy joined #minetest-dev |
| 12:10 |
|
Krock joined #minetest-dev |
| 12:18 |
|
YuGiOhJCJ joined #minetest-dev |
| 12:28 |
|
ProN00b joined #minetest-dev |
| 13:24 |
|
antims joined #minetest-dev |
| 13:45 |
|
p_gimeno joined #minetest-dev |
| 13:57 |
|
pauloue joined #minetest-dev |
| 14:09 |
|
proller joined #minetest-dev |
| 14:17 |
|
AntumD joined #minetest-dev |
| 14:35 |
|
Darcidride joined #minetest-dev |
| 14:49 |
|
proller joined #minetest-dev |
| 15:08 |
|
twoelk joined #minetest-dev |
| 16:04 |
|
ircSparky joined #minetest-dev |
| 16:08 |
|
Xio joined #minetest-dev |
| 16:16 |
|
fwhcat joined #minetest-dev |
| 16:18 |
|
Lunatrius joined #minetest-dev |
| 16:23 |
|
Lunatrius joined #minetest-dev |
| 16:24 |
|
proller joined #minetest-dev |
| 17:11 |
|
Gael-de-Sailly joined #minetest-dev |
| 17:14 |
|
pauloue joined #minetest-dev |
| 17:35 |
|
proller joined #minetest-dev |
| 17:44 |
|
Darcidride joined #minetest-dev |
| 17:49 |
|
fwhcat joined #minetest-dev |
| 18:06 |
|
paramat joined #minetest-dev |
| 18:22 |
|
AndroBuilder joined #minetest-dev |
| 18:30 |
paramat |
please can this high priority bugfix be reviewed? #7061 i will review it soon and will probably +1 as it tests ok |
| 18:30 |
ShadowBot |
https://github.com/minetest/minetest/issues/7061 -- Fix node-nodebox lighting difference in direct sunlight by numberZero |
| 18:31 |
Krock |
I already did a few tests, nothing suspicious so +1 |
| 18:31 |
paramat |
thanks, i'll review soon |
| 18:33 |
nerzhul |
I need to fix a crash on the Krock asking for reseting env :p |
| 18:34 |
nerzhul |
the valgrind unittests show it |
| 18:34 |
nerzhul |
Krock thanks for the review yesterday |
| 18:36 |
Krock |
resetting the env var results in a crash? |
| 18:37 |
Krock |
nerzhul, well done: _putenv(subgame_path.c_str()); |
| 18:37 |
Krock |
https://github.com/minetest/minetest/commit/e800684ead56#diff-15e19c2bc1babc9123e823c0691a4cffR76 |
| 18:37 |
Krock |
amend quickly |
| 18:38 |
Krock |
oh nevermind me |
| 18:39 |
Krock |
it's saved_env_mt_subgame_path which is a pointer, not subgame_path |
| 18:43 |
|
pauloue joined #minetest-dev |
| 19:01 |
|
YuGiOhJCJ joined #minetest-dev |
| 19:25 |
nerzhul |
yes :) |
| 19:25 |
nerzhul |
travis is green too, it's good |
| 19:39 |
|
RobbieF joined #minetest-dev |
| 19:59 |
|
Gael-de-Sailly joined #minetest-dev |
| 20:30 |
|
Jordach joined #minetest-dev |
| 20:31 |
|
Jordach joined #minetest-dev |
| 20:37 |
paramat |
Krock any idea how this works https://github.com/minetest/minetest/pull/7061/files#r175207280 ? |
| 20:41 |
|
Lunatrius joined #minetest-dev |
| 20:42 |
paramat |
updated that comment |
| 20:51 |
Krock |
paramat, by looking at the code, this seems to be for the case there are nodes stacked vertically |
| 20:52 |
Krock |
for bright sides, I believe |
| 20:56 |
paramat |
stacked vertexes you mean? see PR description |
| 20:59 |
paramat |
well nevermind hopefully author will explain |
| 21:19 |
|
proller joined #minetest-dev |
| 21:40 |
p_gimeno |
paramat, ^ is xor, not power |
| 21:41 |
p_gimeno |
if the vertexes are organized so that the bits indicate the direction, then probably k ^ 2 toggles the Y position bit |
| 21:52 |
paramat |
ah |
| 21:52 |
paramat |
of course |
| 21:53 |
paramat |
thanks |
| 21:55 |
paramat |
+1 will merge later |
| 21:56 |
|
fwhcat joined #minetest-dev |
| 21:59 |
nerzhul |
Seems HibridDog likes my mod refactor to propose a feature PR heh |
| 22:01 |
nerzhul |
HybridDog* |
| 22:02 |
|
Beton joined #minetest-dev |
| 22:07 |
|
pauloue joined #minetest-dev |
| 22:07 |
|
Lone-Star joined #minetest-dev |
| 22:14 |
|
Xio joined #minetest-dev |
| 22:18 |
|
Jordach joined #minetest-dev |
| 22:19 |
|
Jordach joined #minetest-dev |
| 23:12 |
|
pauloue joined #minetest-dev |
| 23:27 |
|
pauloue joined #minetest-dev |
| 23:28 |
|
pauloue left #minetest-dev |
