| Time |
Nick |
Message |
| 01:27 |
|
DI3HARD139 joined #minetest-dev |
| 02:19 |
|
ANAND joined #minetest-dev |
| 02:34 |
|
TC01 joined #minetest-dev |
| 03:05 |
|
ANAND joined #minetest-dev |
| 03:15 |
|
AndroBuilder joined #minetest-dev |
| 03:37 |
|
AndroBuilder joined #minetest-dev |
| 03:39 |
|
AndroBuilder_ joined #minetest-dev |
| 03:48 |
|
AndroBuilder joined #minetest-dev |
| 03:54 |
|
AndroBuilder joined #minetest-dev |
| 04:13 |
|
AndroBuilder joined #minetest-dev |
| 04:26 |
|
Darcidride_ joined #minetest-dev |
| 04:26 |
|
RichardTheTurd joined #minetest-dev |
| 04:44 |
|
Darcidride joined #minetest-dev |
| 05:30 |
|
RichardTheTurd joined #minetest-dev |
| 06:49 |
|
chon joined #minetest-dev |
| 08:47 |
|
DI3HARD139 joined #minetest-dev |
| 09:11 |
|
Wuzzy joined #minetest-dev |
| 10:36 |
|
fwhcat joined #minetest-dev |
| 11:17 |
|
Fixer joined #minetest-dev |
| 11:28 |
|
Krock joined #minetest-dev |
| 11:46 |
|
Raven262 joined #minetest-dev |
| 11:52 |
|
Fixer joined #minetest-dev |
| 12:07 |
|
longerstaff13 joined #minetest-dev |
| 12:22 |
|
lumberJ joined #minetest-dev |
| 12:29 |
|
Kalvo joined #minetest-dev |
| 12:31 |
Kalvo |
Hey everyone quick question. Does node metadata get destroyed when a node gets destroyed? (Or when using set_node()) |
| 12:33 |
rubenwardy |
yes with set_node |
| 12:33 |
rubenwardy |
which is how nodes are dug under the hood |
| 12:33 |
rubenwardy |
swap_node and LVMs don't do this, and don't run callbacks either |
| 12:52 |
|
Foz joined #minetest-dev |
| 13:37 |
|
antims joined #minetest-dev |
| 13:50 |
|
Beton joined #minetest-dev |
| 13:55 |
|
troller joined #minetest-dev |
| 14:22 |
|
proller joined #minetest-dev |
| 14:31 |
|
proller joined #minetest-dev |
| 14:33 |
|
troller joined #minetest-dev |
| 15:22 |
|
proller__ joined #minetest-dev |
| 15:39 |
|
twoelk joined #minetest-dev |
| 16:08 |
|
Player-2 joined #minetest-dev |
| 16:16 |
|
Darcidride_ joined #minetest-dev |
| 16:18 |
|
Fixer joined #minetest-dev |
| 16:29 |
|
Krock joined #minetest-dev |
| 16:40 |
|
Krock joined #minetest-dev |
| 16:49 |
|
lumberJ joined #minetest-dev |
| 17:03 |
|
longerstaff13 joined #minetest-dev |
| 17:19 |
Krock |
rubenwardy, do you have any opinion/reply for this comment? https://github.com/minetest/minetest/pull/7214/files#r182687246 If not, I will merge the PR this evening |
| 17:19 |
rubenwardy |
it will never be null |
| 17:19 |
rubenwardy |
hmmm |
| 17:20 |
Krock |
it can be null when the reference is kept in Lua |
| 17:20 |
rubenwardy |
issue is, it should be documented if it ever turns null |
| 17:20 |
rubenwardy |
no, all the providers use pointers |
| 17:20 |
rubenwardy |
so it'll just be a garbage pointer |
| 17:20 |
rubenwardy |
it's probably best to change that to return 0; to futue proof it |
| 17:20 |
rubenwardy |
needs to be documented as well |
| 17:21 |
|
Foz joined #minetest-dev |
| 17:21 |
Krock |
for the sake of completeness `nil` is appropriate there. Do you have time to update it or shall I take care of it? |
| 17:24 |
rubenwardy |
won't have time today |
| 17:26 |
|
Foz joined #minetest-dev |
| 17:32 |
|
rubenwardy joined #minetest-dev |
| 17:45 |
Krock |
I see. The NodeMetaRef::getmeta function is safe and NULL return values are possible there, whereas it looks quite bad with other MetaData types |
| 17:49 |
|
Raven262 joined #minetest-dev |
| 18:04 |
|
proller__ joined #minetest-dev |
| 18:28 |
|
Foz joined #minetest-dev |
| 18:42 |
|
chon joined #minetest-dev |
| 18:50 |
|
rubenwardy joined #minetest-dev |
| 19:03 |
|
Foz joined #minetest-dev |
| 19:05 |
|
Foz joined #minetest-dev |
| 19:14 |
|
proller joined #minetest-dev |
| 20:16 |
|
Foz joined #minetest-dev |
| 20:30 |
|
nerzhul joined #minetest-dev |
| 21:27 |
|
Gael-de-Sailly joined #minetest-dev |
