| Time |
Nick |
Message |
| 00:01 |
Shara |
paramat: pine bushes fine by me :) |
| 00:03 |
paramat |
good thanks |
| 00:09 |
paramat |
merging in 5mins then |
| 00:15 |
paramat |
merging |
| 00:17 |
paramat |
done |
| 01:41 |
|
Cornelia joined #minetest-dev |
| 01:59 |
|
BakerPrime_ joined #minetest-dev |
| 02:00 |
|
BakerPrime joined #minetest-dev |
| 02:21 |
|
ANAND joined #minetest-dev |
| 02:58 |
|
YuGiOhJCJ joined #minetest-dev |
| 03:04 |
|
ssieb joined #minetest-dev |
| 03:58 |
|
paramat joined #minetest-dev |
| 04:27 |
|
Player-2 joined #minetest-dev |
| 04:56 |
|
ensonic joined #minetest-dev |
| 05:35 |
|
AntumDeluge joined #minetest-dev |
| 05:36 |
|
Gael-de-Sailly joined #minetest-dev |
| 05:55 |
|
Gael-de-Sailly joined #minetest-dev |
| 06:40 |
ANAND |
Update: For now, I'm implementing server->client fov sending. Added a packet type for that. Will implement client->server fov ack once this is approved |
| 06:41 |
ANAND |
Since client does not send any acknowledgment, the server needs to store each player's fov somewhere. Could someone suggest a way to achieve this? |
| 06:42 |
ANAND |
PlayerSAO already has set/getFov() methods which set/get a private var 'm_fov' |
| 06:44 |
ANAND |
So is it a good idea to store a player's current fov in their respective PlayerSAO itself? |
| 06:58 |
|
ensonic joined #minetest-dev |
| 07:49 |
|
proller joined #minetest-dev |
| 08:56 |
|
Krock joined #minetest-dev |
| 09:17 |
ANAND |
I've completed the networking and packet handling part, but can't yet figure out how to actually effect an immediate change in the player's fov. |
| 09:17 |
Krock |
camera.cpp |
| 09:21 |
ANAND |
there are two instances of setFOV() in camera.cpp, and both the methods are of the I_CameraSceneNode class |
| 09:22 |
ANAND |
This is what I'm using in clientpackethandler.cpp to try to set the FOV: getCamera()->getCameraNode()->setFOV(fov); |
| 09:25 |
Krock |
look at what zoom does |
| 09:25 |
Krock |
the problem with your code is that it's overwritten each frame |
| 09:29 |
ANAND |
Oh I see.. |
| 09:40 |
|
proller joined #minetest-dev |
| 09:40 |
ANAND |
Krock: This is what I could find... I assume there's much more |
| 09:40 |
ANAND |
https://github.com/minetest/minetest/blob/master/src/game.cpp#L2320 |
| 09:41 |
ANAND |
grepped keyDown(KeyType::ZOOM) |
| 09:52 |
|
lhofhansl joined #minetest-dev |
| 09:52 |
lhofhansl |
Hi all... I'd like to merge #7549 |
| 09:52 |
ShadowBot |
https://github.com/minetest/minetest/issues/7549 -- Adjust some settings to modern environments and networks. by lhofhansl |
| 09:53 |
lhofhansl |
Since this is perhaps more controversial (changing a bunch of defaults) I'll wait for more comments here or on the PR. |
| 09:55 |
|
ensonic joined #minetest-dev |
| 09:57 |
|
Darcidride joined #minetest-dev |
| 10:04 |
Krock |
I'd like to have paramat's opinion on the multithread mapgen |
| 10:20 |
|
entuland joined #minetest-dev |
| 10:22 |
ANAND |
Krock, did you mean this when you referred to zoom? |
| 10:22 |
ANAND |
https://github.com/minetest/minetest/blob/master/src/game.cpp#L2320 |
| 10:23 |
Krock |
ANAND: https://github.com/minetest/minetest/blob/master/src/camera.cpp#L452-L469 |
| 10:26 |
ANAND |
So I'll have to set m_cache_fov, right? |
| 10:29 |
Krock |
no, fov_degrees. m_cache_* is for settings |
| 10:31 |
ANAND |
Oh |
| 10:34 |
ANAND |
Good thing I've already added get/set fov methods to LocalPlayer |
| 10:34 |
ANAND |
Just a little tweak to the part you showed me and it should work :D |
| 10:40 |
ANAND |
Compiling |
| 10:44 |
|
Lymkwi joined #minetest-dev |
| 10:51 |
ANAND |
Hmm.. still does not work. I'll test it further |
| 10:57 |
|
Foz joined #minetest-dev |
| 10:57 |
|
lhofhansl joined #minetest-dev |
| 11:00 |
|
proller joined #minetest-dev |
| 11:04 |
|
proller joined #minetest-dev |
| 11:07 |
|
behalebabo joined #minetest-dev |
| 11:07 |
|
entuland joined #minetest-dev |
| 11:12 |
|
proller joined #minetest-dev |
| 12:02 |
|
Krock joined #minetest-dev |
| 12:04 |
Krock |
lhofhansl: would you please be so nice and announce it here when you've got a trivial patch to merge? |
| 12:05 |
Krock |
see also https://dev.minetest.net/Git_Guidelines#Rule_1_in_practice |
| 12:05 |
sfan5 |
there was an approval by me, but yea it would've been nice to announce it here |
| 12:06 |
Krock |
Actually I meant https://github.com/minetest/minetest/commit/8d629cf65 |
| 12:08 |
lhofhansl |
Sorry, that was such an obvious bug fix that I thought it was OK. |
| 12:08 |
lhofhansl |
Won't do that again. |
| 12:09 |
sfan5 |
oh |
| 12:09 |
Krock |
Usually there are no comments on such trivial fixes, but just for the case it's helpful when there might be an issue with the commit |
| 12:09 |
lhofhansl |
fair rnough |
| 12:09 |
lhofhansl |
enough |
| 12:21 |
|
Fixer joined #minetest-dev |
| 12:23 |
ANAND |
Can Server::printToConsoleOnly() be called from anywhere? It's a great way to troubleshoot without having to use debuggers... |
| 12:26 |
Krock |
heh. std::cout << "Professional debugging line with " << "relevant information" << std::endl; |
| 12:26 |
Krock |
or use a printf boi |
| 12:31 |
ANAND |
Oh right, missed that... :D |
| 12:59 |
|
AndroBuilder joined #minetest-dev |
| 14:21 |
|
proller joined #minetest-dev |
| 15:00 |
|
Taoki joined #minetest-dev |
| 16:10 |
|
AndroBuilder joined #minetest-dev |
| 16:40 |
|
lhofhansl joined #minetest-dev |
| 16:44 |
|
troller joined #minetest-dev |
| 16:52 |
|
proller__ joined #minetest-dev |
| 17:03 |
|
proller__ joined #minetest-dev |
| 17:15 |
|
proller joined #minetest-dev |
| 18:25 |
|
ssieb joined #minetest-dev |
| 18:29 |
|
longerstaff13-m joined #minetest-dev |
| 18:30 |
|
longerstaff13 joined #minetest-dev |
| 19:16 |
|
antims joined #minetest-dev |
| 19:58 |
|
nerzhul joined #minetest-dev |
| 20:08 |
|
nerzhul joined #minetest-dev |
| 20:11 |
nerzhul |
merging #7549 |
| 20:11 |
ShadowBot |
https://github.com/minetest/minetest/issues/7549 -- Adjust some settings to modern environments and networks. by lhofhansl |
| 20:13 |
|
lisac_ joined #minetest-dev |
| 20:28 |
|
Raven262 joined #minetest-dev |
| 21:05 |
|
Lone-Star joined #minetest-dev |
| 21:06 |
|
Cornelia joined #minetest-dev |
| 21:25 |
|
Wuzzy joined #minetest-dev |
| 21:31 |
|
lhofhansl joined #minetest-dev |
| 21:59 |
lhofhansl |
I'd like to merge an amendment to #7549. Forgot to change minetest.conf.example accordingly. |
| 21:59 |
ShadowBot |
https://github.com/minetest/minetest/issues/7549 -- Adjust some settings to modern environments and networks. by lhofhansl |
| 22:05 |
lhofhansl |
It's a textfile only change, matching what's documented in minetest.conf.example, will make the change in a few. |
| 22:07 |
sfan5 |
sounds good |
| 22:10 |
lhofhansl |
done |
| 23:35 |
|
pipo joined #minetest-dev |
| 23:41 |
|
pipo left #minetest-dev |
| 23:50 |
|
YuGiOhJCJ joined #minetest-dev |
