| Time |
Nick |
Message |
| 00:38 |
|
paramat joined #minetest-dev |
| 01:13 |
ANAND |
Will make the FOV PR today... |
| 01:13 |
ANAND |
Once the code has been finalized, I'll update the documentation |
| 01:58 |
|
Miner_48er joined #minetest-dev |
| 01:59 |
ANAND |
PR made: #7557 |
| 01:59 |
ShadowBot |
https://github.com/minetest/minetest/issues/7557 -- [WIP] Expose player FOV to Lua API by ClobberXD |
| 02:32 |
|
EvergreenTree joined #minetest-dev |
| 03:05 |
|
bugzapper joined #minetest-dev |
| 03:05 |
|
Tmanyo joined #minetest-dev |
| 03:39 |
|
Player-2 joined #minetest-dev |
| 04:04 |
|
Corvus_ joined #minetest-dev |
| 04:37 |
|
shacharr joined #minetest-dev |
| 07:13 |
ANAND |
Any issues that remain to be fixed in #7554? |
| 07:13 |
ShadowBot |
https://github.com/minetest/minetest/issues/7554 -- Check if player exists on use of /privs by ClobberXD |
| 07:36 |
|
AndroBuilder joined #minetest-dev |
| 08:01 |
|
Krock joined #minetest-dev |
| 08:08 |
Krock |
!tell paramat is it just me or are lava caves rare in mgv7? |
| 08:08 |
ShadowBot |
Krock: O.K. |
| 09:23 |
|
ensonic joined #minetest-dev |
| 09:26 |
|
red-001 joined #minetest-dev |
| 09:26 |
|
Krock joined #minetest-dev |
| 10:13 |
|
Gael-de-Sailly joined #minetest-dev |
| 10:24 |
|
entuland joined #minetest-dev |
| 11:03 |
|
lhofhansl joined #minetest-dev |
| 11:03 |
lhofhansl |
Hi all... #7555 could use some review/feedback. ABM savings are pretty significant. |
| 11:04 |
ShadowBot |
https://github.com/minetest/minetest/issues/7555 -- Reduce ABM checks. by lhofhansl |
| 11:57 |
|
ensonic joined #minetest-dev |
| 12:05 |
|
Wuzzy joined #minetest-dev |
| 12:13 |
|
Fixer joined #minetest-dev |
| 12:26 |
Krock |
lhofhansl: neither 64 bytes nor 128 bytes matter per mapblock. the actual mapblock contents take much more memory than that |
| 12:27 |
Krock |
lhofhansl: also consider testing it on mapblocks which are used for buildings |
| 12:34 |
lhofhansl |
Krock: That's what I thought. 64 seems to be pretty good. Is there a mod I can use for building testing? |
| 12:34 |
lhofhansl |
I mean 64 content types, a.k.a. 128 bytes. |
| 12:35 |
Krock |
just turn on the local map saving and jump into a random online world |
| 12:35 |
lhofhansl |
Cool... Will try that a bit later. |
| 12:38 |
Fixer |
not random! |
| 12:38 |
Fixer |
try Dreambuilder Survival, it has toons of stuff loaded, save it and then run it with dreambuilder |
| 12:39 |
Fixer |
or whatever |
| 14:01 |
|
entuland joined #minetest-dev |
| 14:05 |
p_gimeno |
villages would work well for that too |
| 14:06 |
nerzhul |
lhofhansl, nice job for the PR, i hope you will finish it soon |
| 14:45 |
|
ensonic joined #minetest-dev |
| 14:45 |
|
AndroBuilder joined #minetest-dev |
| 14:52 |
|
YuGiOhJCJ joined #minetest-dev |
| 15:17 |
|
Lymkwi joined #minetest-dev |
| 16:14 |
|
Gael-de-Sailly joined #minetest-dev |
| 17:01 |
|
entuland joined #minetest-dev |
| 18:17 |
|
Sokomine joined #minetest-dev |
| 18:18 |
|
Sokomine joined #minetest-dev |
| 18:40 |
|
YuGiOhJCJ joined #minetest-dev |
| 18:49 |
|
paramat joined #minetest-dev |
| 19:02 |
|
ensonic joined #minetest-dev |
| 19:09 |
|
Sokomine joined #minetest-dev |
| 19:13 |
paramat |
!tell Krock rarity of lava caves is the same for all non-mgv6 mapgens and hasn't changed for years |
| 19:13 |
ShadowBot |
paramat: O.K. |
| 19:20 |
paramat |
#7532 is ready to go. unravelled some of the mess in mgvalleys |
| 19:20 |
ShadowBot |
https://github.com/minetest/minetest/issues/7532 -- Mgvalleys: Make river depth variation and humidity drop optional by paramat |
| 19:21 |
|
Krock joined #minetest-dev |
| 19:22 |
Krock |
ah okay. then it's always been this rarity |
| 19:23 |
paramat |
yes for several years i think |
| 19:24 |
paramat |
although, 2 years back the highest lava was moved down to -256 |
| 19:25 |
Krock |
oh well, the mapgen settings are getting a little out of hand. already three line wraps for the single setting options |
| 19:26 |
Krock |
I'm not sure how a big impact the river PR has for existing worlds but the code seems ok |
| 19:29 |
|
Lone-Star joined #minetest-dev |
| 19:30 |
paramat |
the maps show the typical change |
| 19:31 |
paramat |
best sort the mess out now before it becomes officially stable |
| 19:31 |
paramat |
otherwise this mapgen will continue to be hell to work on |
| 19:34 |
paramat |
for a long time this code has been so messy i haven't wanted to touch it |
| 19:35 |
paramat |
we (mostly i) made a big mistake allowing mgvalleys to be merged in the state it was in |
| 19:40 |
paramat |
game#2175 should be ok, see my latest comment |
| 19:40 |
|
Cornelia joined #minetest-dev |
| 19:40 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/2175 -- Boats: Use driver name string instead of objectref by paramat |
| 19:42 |
paramat |
oh also, for the mgvalleys PR, i'll make a news post in the forum explaining how to edit map_meta.txt to avoid any biome changes |
| 19:45 |
|
AndroBuilder joined #minetest-dev |
| 19:56 |
|
lhofhansl joined #minetest-dev |
| 19:57 |
Krock |
paramat: nobody said that valleys was stable |
| 19:58 |
Krock |
paramat: you could reduce it by 1 indent. local driver_objref = self.driver and minetest.get_player_by_name(self.driver) |
| 19:58 |
Krock |
then check if driver_objref then |
| 20:02 |
Krock |
can also be kept as-is, if you prefer that |
| 20:02 |
paramat |
hmm |
| 20:03 |
paramat |
that won't work because sometimes self.driver exists but the objref does not |
| 20:04 |
paramat |
it's also less readable so i'l leave it s is |
| 20:04 |
paramat |
*as is |
| 20:04 |
Krock |
okay |
| 20:19 |
paramat |
so i can merge? |
| 20:21 |
Krock |
sure, go on. |
| 20:21 |
Krock |
LGTM |
| 20:21 |
paramat |
thanks! |
| 20:21 |
paramat |
in 5 mins |
| 20:35 |
|
Sokomine joined #minetest-dev |
| 20:44 |
paramat |
oh, merging now |
| 20:51 |
paramat |
done |
| 21:21 |
paramat |
Krock are you +1 for the mgvalleys PR? looked like you might be |
| 21:21 |
Krock |
didn't test it. will do that tomorrow if there are yet no other reviews |
| 21:22 |
Krock |
will have to study this code a bit more |
| 21:23 |
paramat |
ok :) |
| 22:13 |
|
Sokomine joined #minetest-dev |
| 22:15 |
|
lhofhansl joined #minetest-dev |
| 22:19 |
|
lhofhansl left #minetest-dev |
| 22:43 |
|
paramat joined #minetest-dev |
