| Time |
Nick |
Message |
| 00:04 |
|
Ruslan1 joined #minetest-dev |
| 01:10 |
|
ANAND joined #minetest-dev |
| 03:30 |
|
Ruslan1 joined #minetest-dev |
| 04:13 |
|
jas_ joined #minetest-dev |
| 05:39 |
|
ssieb joined #minetest-dev |
| 06:33 |
|
paramat joined #minetest-dev |
| 06:36 |
paramat |
!tell nerzhul with PR 7820 'Update Android java-part', are you waiting for the formatting changes to be split from functional changes before you review? or have you reviewed and the decrement loop is the only remaining issue? |
| 06:36 |
ShadowBot |
paramat: O.K. |
| 07:45 |
|
Wayward_One joined #minetest-dev |
| 08:28 |
|
nerzhul joined #minetest-dev |
| 08:40 |
rubenwardy |
You didn't announce the me |
| 08:40 |
rubenwardy |
*merge |
| 09:37 |
|
nerzhul joined #minetest-dev |
| 10:53 |
|
longerstaff13-m joined #minetest-dev |
| 10:53 |
|
proller joined #minetest-dev |
| 10:55 |
|
Mensious joined #minetest-dev |
| 11:31 |
|
proller joined #minetest-dev |
| 11:46 |
|
Mensious joined #minetest-dev |
| 11:50 |
|
proller joined #minetest-dev |
| 11:54 |
|
Fixer joined #minetest-dev |
| 12:13 |
|
calcul0n joined #minetest-dev |
| 13:04 |
|
proller joined #minetest-dev |
| 13:07 |
|
AndroBuilder joined #minetest-dev |
| 13:08 |
Unarelith |
game.cpp: 4218 lines, omg |
| 13:09 |
Unarelith |
*omfg |
| 13:11 |
Unarelith |
ok I'm starting to cry |
| 13:11 |
|
AndroBuilder_ joined #minetest-dev |
| 13:12 |
Unarelith |
this can't stay that way |
| 13:12 |
* T4im |
has seen way worse |
| 13:13 |
Unarelith |
me too, but it's still very very bad |
| 13:13 |
T4im |
it's not as bad until github stops displaying the file :P |
| 13:13 |
Unarelith |
nerzhul, please check #7902 so I can work on this stuff |
| 13:13 |
ShadowBot |
https://github.com/minetest/minetest/issues/7902 -- Client-specific files moved to 'src/client' by Quent42340 |
| 13:13 |
Unarelith |
T4im, oh damn |
| 13:22 |
Unarelith |
I'll just start a new branch from 7902 and wait its merge for the game.cpp PR |
| 13:23 |
Unarelith |
I just can't do anything else after seeing that |
| 13:42 |
Unarelith |
"GameGlobalShaderConstantSetterFactory" funny, a 37 characters long class name |
| 13:43 |
rubenwardy |
Unarelith: yup |
| 13:43 |
rubenwardy |
I hate game.* |
| 13:44 |
Unarelith |
so please merge 7902 quick so I can make another PR :p |
| 13:44 |
Unarelith |
I'm working on splitting game.cpp right now, based on 7902 branch |
| 13:44 |
Unarelith |
it's worse than I imagined |
| 13:45 |
* rubenwardy |
looks up file(GLOB) |
| 13:46 |
rubenwardy |
the CMake docs discourage using it because it will cause make not to call cmake again when new files are added |
| 13:47 |
Unarelith |
rubenwardy, I can remove the last commit and make a separate PR if you want |
| 13:47 |
Unarelith |
the typical usage is 'cmake && make' |
| 13:47 |
Unarelith |
so you usually cmake each time, instead of adding manually the file into cmake |
| 13:48 |
Unarelith |
that's way better to do "cmake && make" each time than to add each file manually to CMakeLists.txt |
| 13:49 |
Unarelith |
I used `file(GLOB)` in all of my previous CMake projects, and I never had a problem with it since 4 years |
| 13:49 |
rubenwardy |
the sort of errors that this will give will be linking errors, which isn't very obvious for the user to release that it's because cmake . wasn't run |
| 13:49 |
rubenwardy |
I do like the idea of this though, I just predict some "bug" reports from it :) |
| 13:50 |
Unarelith |
the user WILL have to do `cmake .` anyway |
| 13:50 |
Unarelith |
the contributor can figure it out if we write it somewhere |
| 13:51 |
Unarelith |
the only downside is to run 'cmake' before 'make' when a change is made (I usually run it each time since it's less than 1 second) |
| 13:52 |
T4im |
i believe they also offer a better solution instead of glob by now |
| 13:52 |
Unarelith |
rubenwardy, but as I said, I can move this commit to a separate PR if this slows my original PR |
| 13:53 |
rubenwardy |
that would be good |
| 13:53 |
Unarelith |
T4im, maybe, but CMake version we're using (2.6) doesn't even support `target_compile_feature` to set C++ standard so... :/ |
| 13:53 |
T4im |
also cmake alone won't be enough, you'll have to touch CmakeLists.txt each time when you want the glob outcome to change |
| 13:53 |
T4im |
apparently |
| 13:54 |
Unarelith |
rubenwardy, I'll do that then, but I'll need to wait #7902 to be merged before I can make the new PR |
| 13:54 |
ShadowBot |
https://github.com/minetest/minetest/issues/7902 -- Client-specific files moved to 'src/client' by Quent42340 |
| 14:00 |
rubenwardy |
merging game#2214 in 10 |
| 14:00 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/2214 -- Add sfinv.get_page() by rubenwardy |
| 14:08 |
Unarelith |
rubenwardy, #7902 should be ok now |
| 14:08 |
ShadowBot |
https://github.com/minetest/minetest/issues/7902 -- Client-specific files moved to 'src/client' by Quent42340 |
| 14:10 |
|
proller joined #minetest-dev |
| 15:14 |
Unarelith |
so much unused header inclusions in game.cpp ._. |
| 15:24 |
|
proller joined #minetest-dev |
| 15:51 |
|
proller joined #minetest-dev |
| 16:59 |
|
jas_ joined #minetest-dev |
| 17:32 |
|
Ruslan1 joined #minetest-dev |
| 18:21 |
|
Fixer joined #minetest-dev |
| 18:21 |
Unarelith |
rubenwardy, I made a new PR for file(GLOB) but it depends on #7902 |
| 18:21 |
ShadowBot |
https://github.com/minetest/minetest/issues/7902 -- Client-specific files moved to 'src/client' by Quent42340 |
| 18:24 |
|
Krock joined #minetest-dev |
| 18:27 |
* Krock |
strikes out 7395 from his ToDo list |
| 18:28 |
* rubenwardy |
cries in consistency |
| 18:32 |
Krock |
rubenwardy: elaborate please |
| 18:33 |
rubenwardy |
object rotation when attached is in degrees, when not attached is in radians |
| 18:34 |
rubenwardy |
this will be fun to explain |
| 18:34 |
Unarelith |
why this behaviour? |
| 18:34 |
rubenwardy |
"Minetest uses degrees for rotation, except for object rotation which uses rotation, except when attaching to another object which uses degrees" |
| 18:35 |
rubenwardy |
"Minetest uses degrees for rotation, except for object rotation which uses radians, except when attaching to another object which uses degrees" |
| 18:36 |
rubenwardy |
I get that you're move likely to do calculations when rotating and entity, but that doesn't excuse an inconsistent API when the conversion is trivial |
| 18:36 |
rubenwardy |
you could add a set_rotation_rad for this purpose if it really bothers you |
| 18:36 |
Unarelith |
+1 |
| 18:36 |
Unarelith |
+2 |
| 18:36 |
rubenwardy |
having Minetest use degrees, and Math use radians makes a lot of sense and is easy to remember |
| 18:37 |
Krock |
testing #7902 |
| 18:37 |
ShadowBot |
https://github.com/minetest/minetest/issues/7902 -- Client-specific files moved to 'src/client' by Quent42340 |
| 18:37 |
rubenwardy |
but, whatever |
| 18:37 |
Unarelith |
I agree, and making `set_rotation_rad` is still an option so why not trying to keep consistency |
| 18:37 |
rubenwardy |
I've clearly been outvoted on this |
| 18:38 |
Unarelith |
? |
| 18:38 |
rubenwardy |
it's 2 : 1 on radians to degrees for this |
| 18:38 |
Krock |
deg/rad is messed up in Minetest |
| 18:39 |
Krock |
thx irrlicht |
| 18:39 |
rubenwardy |
disclaimer: I prefer radians as it's a ton more mathematical, but our API and our rendering engine both use degrees |
| 18:39 |
rubenwardy |
listed all the angle uses, only objects use radians and in a mixed way |
| 18:43 |
mmuller |
hey, can someone take a look at https://github.com/minetest/minetest/pull/7854 ? |
| 18:43 |
mmuller |
it's a pretty simple fix; I'm happy to try to add instructions for reproducing it if needed. |
| 18:43 |
mmuller |
(or even a test case with some guidance) |
| 18:45 |
rubenwardy |
nice debugging |
| 18:45 |
Krock |
yet another forgotten PR |
| 18:45 |
rubenwardy |
didn't even see that PR |
| 18:46 |
mmuller |
rubenwardy: thanks! |
| 18:46 |
Krock |
seen it, labelled it, forgot it. |
| 18:47 |
mmuller |
and no worries. I miss shit all the time :-) |
| 18:47 |
Krock |
merging #7854 and #7902 in 13 minutes |
| 18:47 |
ShadowBot |
https://github.com/minetest/minetest/issues/7854 -- Clean up stack after script_get_backtrace. by mindhog |
| 18:47 |
ShadowBot |
https://github.com/minetest/minetest/issues/7902 -- Client-specific files moved to 'src/client' by Quent42340 |
| 18:47 |
Krock |
^ nerzhul, latter might be interesting for you. outdated review |
| 18:48 |
Krock |
I hope the Android build works too |
| 18:48 |
Krock |
(as in "compiles too") |
| 18:49 |
Unarelith |
I hope too, and review is outdated on #7903 too |
| 18:49 |
ShadowBot |
https://github.com/minetest/minetest/issues/7903 -- File 'content_sao' splitted into folder 'src/server/object'. by Quent42340 |
| 18:49 |
* Krock |
hopes for srifqi and stujones to shout loud as soon it breaks |
| 18:49 |
Unarelith |
won't be hard to make a fix tho |
| 18:50 |
Unarelith |
and I'm gonna replace filenames by a basic wildcard usage at some point to prevent this kind of issue |
| 18:50 |
Krock |
#7905 just rebrand the "stars" to black holes |
| 18:50 |
ShadowBot |
https://github.com/minetest/minetest/issues/7905 -- Star glitch |
| 18:52 |
|
Wuzzy joined #minetest-dev |
| 18:52 |
|
Ruslan1 joined #minetest-dev |
| 18:55 |
|
Mensious joined #minetest-dev |
| 18:56 |
Krock |
Unarelith: can #7902 be squashed on merge or would you prefer to keep the commits? |
| 18:56 |
ShadowBot |
https://github.com/minetest/minetest/issues/7902 -- Client-specific files moved to 'src/client' by Quent42340 |
| 18:57 |
Unarelith |
Krock, I don't really care |
| 18:58 |
Unarelith |
I can squash it if you want |
| 19:00 |
Krock |
merging.. |
| 19:00 |
Krock |
ok |
| 19:01 |
Krock |
200 |
| 19:03 |
Unarelith |
perfect, thx Krock |
| 19:03 |
Unarelith |
7903 could be merged too I guess |
| 19:04 |
Unarelith |
but some code-style commits could still be added if needed |
| 19:07 |
Krock |
ok.. if somebody has plenty of time: there are many PRs to mark as "rebase needed" |
| 19:07 |
Krock |
including all of mine |
| 19:12 |
Unarelith |
Krock, well, I have plenty of time, so I can probably do this |
| 19:13 |
Krock |
no need. I prefer to do it myself since I'm familiar with the code and could actually carry on the development in case there are concerns |
| 19:13 |
Unarelith |
ok then |
| 19:21 |
|
nerzhul_ joined #minetest-dev |
| 19:24 |
Unarelith |
rubenwardy, Krock, sfan5, #7906, #7908 and #7909 are open for discussion, when you have enough time I'm here |
| 19:24 |
ShadowBot |
https://github.com/minetest/minetest/issues/7906 -- CircleCI config file added by Quent42340 |
| 19:24 |
ShadowBot |
https://github.com/minetest/minetest/issues/7908 -- File 'client/game' splitted into new folder by Quent42340 |
| 19:24 |
ShadowBot |
https://github.com/minetest/minetest/issues/7909 -- CMakeLists: Use file(GLOB) instead of manually writing filenames by Quent42340 |
| 19:24 |
Krock |
I'd be happier about some feature or bugfix PRs now |
| 19:29 |
Unarelith |
Krock, me too, but I just can't work on getting familiar with MT codebase seeing how it's organized, so I'm fixing some things and learning the code in the way |
| 19:31 |
Unarelith |
I just want to do a f*king animated barrel and I spent 3 days moving files, writing config file (CircleCI), making things work, doing the same exact things 4 times (PR splits, rebases) |
| 19:32 |
Unarelith |
I'm just not having fun, I'm actually trying to make life better for everyone |
| 19:33 |
Unarelith |
if the code is better organized it'll be easier to submit PRs, to review them, to refactor things |
| 19:34 |
Unarelith |
a lot of MT codebase hasn't moved since a long time, and it needs to be modernized in a way, or it'll end up even worse than it already is |
| 19:36 |
Krock |
conflict party |
| 19:36 |
Krock |
I wonder when your animation thingy will get into the engine |
| 19:36 |
Krock |
or.. if at all |
| 19:37 |
Unarelith |
my animation thing? |
| 19:37 |
Krock |
> f*king animated barrel |
| 19:38 |
Krock |
or how does the barrel relate to the code structure? |
| 19:38 |
Unarelith |
oh, well, it's related to #6963 and has to be done at some point |
| 19:38 |
ShadowBot |
https://github.com/minetest/minetest/issues/6963 -- Node bound entities |
| 19:38 |
|
Mensious joined #minetest-dev |
| 19:41 |
Unarelith |
so I'll do this later, I'm free the whole month so if I spend a week on code organization, I can spend three weeks on bug/features |
| 19:49 |
|
Fixer joined #minetest-dev |
| 19:51 |
|
Krock joined #minetest-dev |
| 19:52 |
Krock |
nice :) |
| 19:52 |
|
troller joined #minetest-dev |
| 19:54 |
Krock |
#7348 is again ready for review |
| 19:54 |
ShadowBot |
https://github.com/minetest/minetest/issues/7348 -- Protocol cleanups: Remove legacy access denied, legacy HUDs; improve damage & HP values by SmallJoker |
| 20:17 |
|
Fixer_ joined #minetest-dev |
| 20:47 |
|
ssieb joined #minetest-dev |
| 20:52 |
|
proller joined #minetest-dev |
| 20:55 |
|
troller joined #minetest-dev |
| 21:00 |
|
Gael-de-Sailly joined #minetest-dev |
| 21:05 |
|
fwhcat joined #minetest-dev |
| 21:14 |
|
proller joined #minetest-dev |
| 21:27 |
|
jas_ joined #minetest-dev |
| 21:48 |
Unarelith |
rubenwardy, nerzhul, can you take a look to #3473, #3827 and #4343 please? These are old and they probably have been forgotten but I actually think they could be merged soon |
| 21:48 |
ShadowBot |
https://github.com/minetest/minetest/issues/3473 -- Automatically enable depends of mods when enabling the mods in the world config menu by HybridDog |
| 21:48 |
ShadowBot |
https://github.com/minetest/minetest/issues/3827 -- Clean up NCursesW finder by ShadowNinja |
| 21:48 |
ShadowBot |
https://github.com/minetest/minetest/issues/4343 -- Profiler: Better structures, count calls, measure relative usage by t4im |
| 22:04 |
sfan5 |
"old and forgotten but could be merged soon" describes lots of Minetest PRs |
| 22:21 |
Unarelith |
sfan5, yep, I made a small list: https://gist.github.com/Quent42340/62ae591da5c75872908a8032113ae85a |
| 22:37 |
nerzhul |
Unarelith sorry but no :) |
| 22:55 |
|
proller__ joined #minetest-dev |
| 23:00 |
|
troller joined #minetest-dev |
| 23:00 |
Unarelith |
nerzhul, what do you mean by "no"? |
| 23:47 |
|
paramat joined #minetest-dev |
